[Linuxdcpp-team] [Bug 2110291] Re: One time small updates in the share may not trigger a Bloom filter update request which makes such updated files unsearchable by TTH for other hub users

2025-06-04 Thread maksis
Hopefully the protocol-related talk will be recovered from the old forum as I also made calculations regarding the poor scalability of the Bloom filters. The extension was tested in a few hubs several years ago and it caused complaints from the users which in my opinion can't be solved with the cur

[Linuxdcpp-team] [Bug 2110291] Re: One time small updates in the share may not trigger a Bloom filter update request which makes such updated files unsearchable by TTH for other hub users

2025-06-02 Thread maksis
The Bloom extension is disabled by default in AirDC++, as I believe it causes more issues than it solves, as discussed on the DCBase forum. Possibly the feature could be removed altogether. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to D

[Linuxdcpp-team] [Bug 309402] Re: ipv6 support

2024-09-25 Thread maksis
As it seems like the feature won't be added in ADCH++, I've created my own ADCH++ fork that supports the HBRI extension and handles validation for the secondary IP protocol: https://github.com/maksis/adchpp-hbri (HBRI support is also implemented in AirDC++) -- You received this bug no

[Linuxdcpp-team] [Bug 2081649] Re: An invalid I4/I6 field received from a client crashes the hub

2024-09-25 Thread maksis
an be triggered by sending a malformed I4 param (e.g. 999.999.999.999) to the hub. Fixed in commit https://github.com/maksis/adchpp- hbri/commit/d24e8972f9d1f2268fb8b1dec0dc3676f62fad17 of my HBRI fork. To manage notifications about this bug go to: https://bugs.launchpad.net/adchpp/+bug/20

[Linuxdcpp-team] [Bug 2081649] Re: An invalid I4/I6 field received from a client crashes the hub

2024-09-25 Thread maksis
(e.g. 999.999.999.999) to the hub. Fixed in commit https://github.com/maksis/adchpp- hbri/commit/d24e8972f9d1f2268fb8b1dec0dc3676f62fad17 of my HBRI fork. To manage notifications about this bug go to: https://bugs.launchpad.net/adchpp/+bug/2081649/+subscrip

[Linuxdcpp-team] [Bug 2081649] [NEW] An invalid I4/I6 field received from a client crashes the hub

2024-09-22 Thread maksis
ing a malformed I4 param (e.g. 999.999.999.999) to the hub. Fixed in commit https://github.com/maksis/adchpp- hbri/commit/d24e8972f9d1f2268fb8b1dec0dc3676f62fad17 of my HBRI fork. ** Affects: adchpp Importance: Undecided Status: New -- You received this bug notification because you

[Linuxdcpp-team] [Bug 2078913] [NEW] Failed to remove port mappings with the NAT-PMP interface

2024-09-04 Thread maksis
Public bug reported: https://datatracker.ietf.org/doc/html/rfc6886#section-3.4: "When a mapping is destroyed successfully as a result of the client explicitly requesting the deletion, the NAT gateway MUST send a response packet that is formatted as defined in Section 3.3, "Requesting a Mapping".

[Linuxdcpp-team] [Bug 2019497] Re: Handling of CTM/search DDoS triggered by a malicious hub

2023-06-02 Thread maksis
t/issues/450 https://github.com/airdcpp/airdcpp-windows/issues/63 While inspecting the issue more closely, I noticed that the client receives about 300 search/CTM requests per second from the hub, similar to these: $Search 82.146.38.183:80 F?F?0?1?t $ConnectToMe maksis 82.146.38.183:443 $Sear

[Linuxdcpp-team] [Bug 2019497] Re: Handling of CTM/search DDoS triggered by a malicious hub

2023-05-17 Thread maksis
arch/CTM requests per second from the hub, similar to these: $Search 82.146.38.183:80 F?F?0?1?t $ConnectToMe maksis 82.146.38.183:443 $Search 82.146.38.183:443 F?F?0?1?p $ConnectToMe maksis 82.146.38.183:80 $Search 82.146.38.183:80 F?F?0?1?t $ConnectToMe maksis 82.146.38.183:443

[Linuxdcpp-team] [Bug 2019497] Re: Handling of CTM/search DDoS triggered by a malicious hub

2023-05-15 Thread maksis
cting the issue more closely, I noticed that the client receives about 300 search/CTM requests per second from the hub, similar to these: $Search 82.146.38.183:80 F?F?0?1?t $ConnectToMe maksis 82.146.38.183:443 $Search 82.146.38.183:443 F?F?0?1?p $ConnectToMe maksis 82.146.38.183:80 $S

[Linuxdcpp-team] [Bug 2019497] [NEW] Handling of CTM/search DDoS triggered by a malicious hub

2023-05-14 Thread maksis
While inspecting the issue more closely, I noticed that the client receives about 300 search/CTM requests per second from the hub, similar to these: $Search 82.146.38.183:80 F?F?0?1?t $ConnectToMe maksis 82.146.38.183:443 $Search 82.146.38.183:443 F?F?0?1?p $ConnectToMe maksis 82.146.38.183:80 $S

[Linuxdcpp-team] [Bug 1952754] Re: [Hublist] tankafett[.]biz is no more a hublist

2022-07-17 Thread maksis
** Changed in: airdcpp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1952754 Title: [Hublist] tankafett[.]biz is no more a hublist Status in AirDC++:

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2021-10-03 Thread maksis
My original issue was about sending the TL -1 parameter and thus telling the clients to never reconnect in case of overflow (even though the error message shown to the user conflicts with that). If that is the way how it's supposed to work, I'd rather set a different status for the issue. Documenta

[Linuxdcpp-team] [Question #690223]: Status of bug #1088638 changed to 'Won't Fix' in ADCH++

2021-10-03 Thread maksis
Bug #1088638 status changed in ADCH++: Fix Committed => Won't Fix https://bugs.launchpad.net/adchpp/+bug/1088638 "Not enough bandwidth available, please try again later" This bug is linked to #690223. Not enough bandwidth available, please try again later https://answers.launchpad.net/adchpp

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2021-01-21 Thread maksis
Looks like local file/directory names may also contain invalid characters on non-Windows operating systems (at least on Linux). Those may cause crashes and other issues, such as std::bad_alloc exceptions when generating XML files. https://github.com/airdcpp-web/airdcpp-webclient/issues/382 https:/

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-10 Thread maksis
Looks like the benchmarks that you linked use 4-16 KB block sizes for reading, which is far from optimal when doing regular sequential file reads for larger files. "Do you have any idea why in your Ubuntu 20.04 setup, 4MB buffers performed notably worse than 1MB buffers?" I'm not really sure, but

[Linuxdcpp-team] [Bug 1910274] [NEW] Incomplete trees can be added in hash database

2021-01-05 Thread maksis
Public bug reported: Steps to reproduce: 1. Start hashing a large file 2. Exit the application while the hashing is still in progress 3. Open HashIndex.xml and you'll find the file from there Looks like the application isn't happy with the saved data as it begins to hash the file again on next s

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-05 Thread maksis
I ran some additional tests with different read buffer sizes on different platforms. Cached hashing speed on macOS is CPU-bound and the same most likely applies to Windows results as well (both disks are able to read 1000 MB/s+). 1024 KB buffer size looks quite good based on the tests. macOS 11 (

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-03 Thread maksis
FileReader::readDirect implementation with O_DIRECT/F_NOCACHE: https://github.com/airdcpp/airdcpp- windows/commit/eb1e075d5a69862c4f2255f9ea2f204bb70921ba However, I don't think that the main point of the low-level FileReader::readDirect implementation for Windows is skipping of the OS buffers (co

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-02 Thread maksis
AirDC++ actually has some kind of support for opening files O_DIRECT: https://github.com/airdcpp/airdcpp- windows/blob/b863d8626d95d0ee483572a5139f8f569b558c3f/airdcpp/airdcpp/File.cpp#L380-L394 (BUFFER_NONE isn't currently being used anywhere though when opening files) FileReader::readCached curr

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-02 Thread maksis
Yeah this crash only happened for people using the Linux version of AirDC++. FileReader::readMapped has always been disabled on Windows. I'm not sure if mapped reading even makes sense in cases where the file is only being read sequentially through once (maybe things were different back in the day

[Linuxdcpp-team] [Bug 1909861] [NEW] FileReader is not thread safe on Linux

2021-01-02 Thread maksis
Public bug reported: FileReader::readMapped currently modifies the global SIGBUS handler in order to catch read errors: https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/FileReader.cpp#l289 Since the function can be called concurrently from different threads (currently hashing/queue

[Linuxdcpp-team] [Bug 1909853] [NEW] Don't use custom socket buffer sizes by default

2021-01-02 Thread maksis
Public bug reported: Modern operating systems (Linux 2.4+, Windows Vista+) should support TCP tuning (https://en.wikipedia.org/wiki/TCP_tuning) to enable higher per- thread speeds with fast connections. However, the current default socket buffer size (65536 bytes) set by the client will prevent th

[Linuxdcpp-team] [Bug 1682791] Re: Unencrypted CCPM connections are not being rejected

2020-08-24 Thread maksis
I wonder how it was tested. Did you check the protocol communication or confirm that the connection was actually rejected (instead of having an unrelated connectivity issue, possibly because of the modifications)? -- You received this bug notification because you are a member of Dcplusplus-team,

[Linuxdcpp-team] [Bug 1856087] Re: Socks 5 Proxy do not work properly on ADC(S)

2020-08-24 Thread maksis
I spent some time on the socks-related code and I was able to spot a few issues: Socket::socksUpdated (UDP, initialization) - the function wasn't called on startup so the UDP functionality was initialized only after updating settings - waitConnected was missing after connect, causing the initiali

[Linuxdcpp-team] [Bug 988891] Re: socks does not seem to work (with putty acting as socks server)

2020-08-24 Thread maksis
I believe that this specific problem has already been fixed ** Changed in: airdcpp Status: Incomplete => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/988891 Title: socks does

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread maksis
I don't see how "TL-1" would protect from misbehavior in the IDENTIFY state, as the error is not being sent in that state. I don't even believe that the author of that code had a clear intention to send TL-1 in that case, and I'd rather consider it to be a bug (which would be fixed by my patch). Th

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread maksis
"dropping protection against clients possibly misbehaving in the IDENTIFY state and so endangering the hub stability" What kind of misbehavior are you thinking? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpa

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-29 Thread maksis
Hmm, I don't follow. How does increasing OverflowTimeout help with this issue? I can't spot any explanation from the code for that. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1088638 Title: N

[Linuxdcpp-team] [Bug 1088638] Re: Not enough bandwidth available, please try again later

2020-04-28 Thread maksis
I'm getting a feeling that the context of this issue isn't being understood. I'm aware of it happening only after the hub has been restarted (and there are lots of users reconnecting). As someone who used to run hubs with 10k+ users, I remember that the hub is under heavy load after the restart. I

[Linuxdcpp-team] [Bug 1860365] Re: GeoIP database is not free any more

2020-01-20 Thread maksis
There's a separate (closed) report for AirDC++: https://bugs.launchpad.net/airdcpp/+bug/1858229 -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1860365 Title: GeoIP database is not free any more St

[Linuxdcpp-team] [Bug 1850053] Re: dh key too small

2019-10-27 Thread maksis
Related: https://github.com/airdcpp-web/airdcpp-webclient/issues/333 ** Bug watch added: github.com/airdcpp-web/airdcpp-webclient/issues #333 https://github.com/airdcpp-web/airdcpp-webclient/issues/333 -- You received this bug notification because you are a member of Dcplusplus-team, which is

[Linuxdcpp-team] [Bug 1818825] Re: Use ALPN for protocol negotiation over TLS

2019-03-06 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1818825 Title: Use ALPN for protocol negotiation over TLS Status in AirDC++: N

[Linuxdcpp-team] [Bug 919424] Re: /rebuild does not update HashData

2018-04-21 Thread maksis
"Of course your motive is to make it easy to move *to* Air and not away from it (hence the import feature for the old DB format), but still..." My motivation was to make it possible for people using older versions of the application to upgrade without losing their data... Regarding comment #14:

[Linuxdcpp-team] [Bug 919424] Re: /rebuild does not update HashData

2018-04-21 Thread maksis
You make it sound like the file formats have been changed without proper reasons. No, the hash database format wasn't changed because of this issue (I just wanted to report my findings here while making the rewrite). Dealing with a hash index XML file that could be several gigabytes in size and bei

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-12 Thread maksis
Ah right, the empty string check should have been added there as well (even though empty data seems to be currently discarded at https://sourceforge.net/p/dcplusplus/code/ci/f8540557bd5c28a9d0b3879b3e6b26f50ab670a6/tree/dcpp/SearchManager.cpp#l132). The old NMDC code was moved as it was as I don't

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-11 Thread maksis
Yeah, I took the code from AdcHub where it was public for some reason. Here's a patch for DC++. ** Patch added: "udp.patch" https://bugs.launchpad.net/dcplusplus/+bug/1722364/+attachment/4967758/+files/udp.patch -- You received this bug notification because you are a member of Dcplusplus-tea

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-10 Thread maksis
AirDC++ now uses the regular dispatch function for parsing ADC UDP commands that should fix the issue: https://github.com/airdcpp/airgit/blob/6a40613788e7ed8a7478f4f1789bbd142a98d231/airdcpp/airdcpp/UDPServer.cpp#L130-L175 ** Changed in: airdcpp Status: New => Fix Released -- You received

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-09 Thread maksis
** Also affects: flylinkdc Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1722364 Title: Invalid ADC commands sent via UDP will crash the app Status in

[Linuxdcpp-team] [Bug 1722364] [NEW] Invalid ADC commands sent via UDP will crash the app

2017-10-09 Thread maksis
*** This bug is a security vulnerability *** Private security bug reported: The AdcCommand parsing function will throw ParseException on invalid commands: https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/AdcCommand.cpp#l37 However, SearchManager (UDPServer in AirDC++) won't catch t

[Linuxdcpp-team] [Bug 1682798] [NEW] CCPM connections are accepted from users that don't advertise CCPM support

2017-04-14 Thread maksis
Public bug reported: This can be used by spam bots and other malicious clients to randomly establish CCPM connections in hubs that have disabled the CCPM feature. ** Affects: airdcpp Importance: Undecided Status: New ** Affects: dcplusplus Importance: Undecided Status

[Linuxdcpp-team] [Bug 1682791] [NEW] Unencrypted CCPM connections are not being rejected

2017-04-14 Thread maksis
Public bug reported: The application still incorrectly shows that direct encrypted channel has been established. AirDC++ also shouldn't allow establishing direct encrypted channels when transfer encryption has been disabled. ** Affects: airdcpp Importance: Undecided Status: New **

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2017-02-23 Thread maksis
Non-Windows versions of Text::utf8ToWide and Text::wideToUtf8 won't obviously handle UTF-16 surrogate pairs at all, thus producing incorrect results. See the following test case for 🌍: string toUtf8(const wstring& str) { string tgt; string::size_type n = str.length(); for (

[Linuxdcpp-team] [Bug 1665900] Re: Case-sensitivity in filelists

2017-02-18 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1665900 Title: Case-sensitivity in filelists Status in AirDC++: New Status in

[Linuxdcpp-team] [Bug 1665900] [NEW] Case-sensitivity in filelists

2017-02-18 Thread maksis
Public bug reported: Starting from version 3.30, AirDC++ refuses to load filelists that contain directories with duplicate names in case-insensitive context (since such lists are malformed according to ADC/NMDC specs). However, this has caused some problems, since at least Eiskalt and Flylink will

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.11

2017-02-01 Thread maksis
** Changed in: airdcpp Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1656050 Title: Compression errors with zlib 1.2.11 Status in AirDC++: Fix Released

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.11

2017-01-25 Thread maksis
** Summary changed: - Compression errors with zlib 1.2.10 + Compression errors with zlib 1.2.11 -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1656050 Title: Compression errors with zlib 1.2.11 S

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.10

2017-01-21 Thread maksis
That's one way to do it. For anyone using the code on Linux, it's very much impossible to notice that such split is needed (before they actually run into problems and try to figure out what's wrong). I'd strongly avoid such caveats that rely on internal functionality changes of a library instead o

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.10

2017-01-20 Thread maksis
Should the check for "zs.avail_out == 0" still be kept in case zlib's error policy is changed again in future and for compatibility with older zlib versions? The code can't really be tied to a specific zlib version on Linux. -- You received this bug notification because you are a member of Dcplus

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.10

2017-01-19 Thread maksis
No errors with a previously failing folder transfer after applying that patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1656050 Title: Compression errors with zlib 1.2.10 Status in AirDC++:

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.10

2017-01-17 Thread maksis
Yeah, it still happens with files as well. The next stable version AirDC++ will be released with zlib 1.2.8 regardless of what happens with this issue. ** Changed in: airdcpp Status: New => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.10

2017-01-15 Thread maksis
I haven't experienced any errors with zlib 1.2.11 yet -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1656050 Title: Compression errors with zlib 1.2.10 Status in AirDC++: New Status in ApexDC++:

[Linuxdcpp-team] [Bug 1656049] [NEW] Compression errors with zlib 1.2.10

2017-01-12 Thread maksis
*** This bug is a duplicate of bug 1656050 *** https://bugs.launchpad.net/bugs/1656050 Public bug reported: After updating zlib to version 1.2.10, transfers randomly fail because of compression errors. Such errors happening on uploader's side won't reported anywhere, the upload just gets disc

[Linuxdcpp-team] [Bug 1656050] [NEW] Compression errors with zlib 1.2.10

2017-01-12 Thread maksis
Public bug reported: After updating zlib to version 1.2.10, transfers randomly fail because of compression errors. Such errors happening on uploader's side won't reported anywhere, the upload just gets disconnected. Based on some debugging with AirDC++, the actual location where the error happens

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2017-01-09 Thread maksis
** Changed in: airdcpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1649066 Title: Invalid UTF-8 data is not always being rejected Status in AirDC++: Fix Rel

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-30 Thread maksis
AirDC++ now implements the latter version. This issue has also been partially discussed earlier: https://sourceforge.net/p/dcplusplus/mailman/message/797137/ -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-22 Thread maksis
An alternative patch that should sanitize the string instead ** Patch added: "utf8_replace.patch" https://bugs.launchpad.net/dcplusplus/+bug/1649066/+attachment/4795240/+files/utf8_replace.patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subsc

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-22 Thread maksis
Similar patch for DC++ with test included. Seems that the non-Windows version of Text::utf8ToWide could be used to sanitize invalid characters already. I'm not sure that why there is a separate implementation for Windows as the other code doesn't call any platform-specific functions (the same appl

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-20 Thread maksis
AirDC++ will now just replace invalid data when loading config files: https://github.com/airdcpp/airgit/commit/6ab6e22770d1c6d61a5c25a6d58fb6cdedc67858 Since I generally expect this to affect only (a small number of) favorite hub names and descriptions (and recent hubs in AirDC++), I find the solu

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-19 Thread maksis
The validation function is cheap and there is effectively no difference in filelist loading times. Since it's possible to add favorite hubs directly from the hublist, it's quite likely that there are users with malformed data in their Favorites.xml as well. Disabling the validity check for certain

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-18 Thread maksis
This patch for DC++ addresses 1) and 3) ** Patch added: "utf8.patch" https://bugs.launchpad.net/dcplusplus/+bug/1649066/+attachment/4793524/+files/utf8.patch -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-18 Thread maksis
I've implemented UTF-8 validation for XML parsing in AirDC++: https://github.com/airdcpp/airgit/commit/82e02ff9f7023a4aa5a35b61c4cd313b9fed59a6 The only issue I've noticed is that the default hublist (http://dchublist.com/hublist.xml.bz2) won't pass the validation. -- You received this bug notif

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-11 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1649066 Title: Invalid UTF-8 data is not always being rejected Status in AirDC++

[Linuxdcpp-team] [Bug 1649066] [NEW] Invalid UTF-8 data is not always being rejected

2016-12-11 Thread maksis
Public bug reported: There are various cases where invalid UTF-8 data is being consumed by the core: 1. Text::convert will return the original string in case of errors (Linux only, respective Windows-specific functions will return an empty string in case of errors) 2. When using "utf-8" encodin

[Linuxdcpp-team] [Bug 1620100] Re: NSIS 3

2016-09-05 Thread maksis
I'd be more strict with the allowed NSIS version: https://textslashplain.com/2015/12/18/dll-hijacking-just-wont-die/ -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1620100 Title: NSIS 3 Status in

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-09-04 Thread maksis
Apart from https://github.com/airdcpp/airgit/commit/775bdc1fc1a58a2d0720cc4a8122f3e85897b8b6, I haven't really made notable changes to detection-related code during the last few years. I just noticed that there was a need to make some of the functions a bit more "universal" after reading your detec

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-08-30 Thread maksis
Yeah, automatic detection in AirDC++ won't do any port mapping because of the reasons above. It's unclear to me that who's using NAT with IPv6 but I still implemented port mapping code for manual (experimental) use since MiniUPNPc had support for IPv6. Maybe it can be used for opening ports from th

[Linuxdcpp-team] [Bug 1543595] Re: Issues with encrypted transfers

2016-04-10 Thread maksis
** Changed in: airdcpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1543595 Title: Issues with encrypted transfers Status in AirDC++: Fix Released Status in

[Linuxdcpp-team] [Bug 1445330] Re: CCPM and hub connection encryption

2016-03-12 Thread maksis
** Changed in: airdcpp Status: New => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1445330 Title: CCPM and hub connection encryption Status in AirDC++: Fix Released Status

[Linuxdcpp-team] [Bug 1543595] [NEW] Issues with encrypted transfers

2016-02-09 Thread maksis
Public bug reported: 1. Join an ADCS hub with at least two ncdc users 2. Download filelist from both users 3. Disconnect both connections 4. Download filelist from both users again The second download will fail. I suspect that this is because ncdc generates certificates with a hardcoded subject (

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2015-10-15 Thread maksis
"while it successfully connects through IPv4 to other clients like AirDC, StrongDC++, etc... (ones that have different IPv6 low level socket code implementation than us)." The low-level socket implementation in AirDC++ should be very similar as in DC++. "If it's enabled and the user doesn't have

[Linuxdcpp-team] [Bug 1307313] Re: ADLSearch can no longer show different files with the same name

2015-10-09 Thread maksis
See https://github.com/airdcpp/airgit/blob/master/windows/DirectoryListingFrm.cpp#L1792 -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1307313 Title: ADLSearch can no longer show different files wi

[Linuxdcpp-team] [Bug 1445330] Re: CCPM and hub connection encryption

2015-04-17 Thread maksis
Ah, but isn't KEYP meant to prevent connection hijacking, so even that doesn't seem possible. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1445330 Title: CCPM and hub connection encryption Statu

[Linuxdcpp-team] [Bug 1445330] Re: CCPM and hub connection encryption

2015-04-17 Thread maksis
I understand requiring the CCPM connection to be encrypted but not why the _hub_ connection needs to be encrypted. Because someone could snoop the token that is sent through the hub and hijack the connection? The same applies to encrypted transfer connections as well, but they can still be establi

[Linuxdcpp-team] [Bug 1445330] [NEW] CCPM and hub connection encryption

2015-04-16 Thread maksis
Public bug reported: I don't understand that why does DC++ require the hub connection be encrypted before the user can initiate CCPM connections. There's no such limitation for encrypted file transfers and I don't see it being mentioned in the extension specs either. DC++ won't even disallow CCPM

[Linuxdcpp-team] [Bug 1225930] Re: [WishList] Change the system-tray client call behavoir

2014-01-23 Thread maksis
When using a recent operating system, applications generally stay in taskbar while they are minimized. Because of that, I'd assume that the tray icon is mainly used for notifications or quick operations (i.e. changing the limiter value) instead of minimizing/maximizing the main window. Double-click

[Linuxdcpp-team] [Bug 1265889] Re: Return more relevant search results

2014-01-18 Thread maksis
Only changing the search responses wasn't that complete idea as clients will still less relevant replies if there is nothing better available :p I also made it order the displayed search replies based on a combination of the word matching scores and the number of hits. This also makes it much easie

[Linuxdcpp-team] [Bug 1265889] Re: Return more relevant search results

2014-01-11 Thread maksis
https://github.com/airdcpp/airgit/commit/c395d994b87f55c35a4584551d65a2c34df574a2 My implementation will also ignore partial matches from the parent directory names if they are all less than 3 characters long (I can't cases where such matches would be wanted). It won't go deeper when all words are

[Linuxdcpp-team] [Bug 190964] Re: Rare connection hang, on joining a hub

2014-01-06 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New ** Changed in: airdcpp Status: New => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/190964 Title: Rare connec

[Linuxdcpp-team] [Bug 1265889] Re: Return more relevant search results

2014-01-06 Thread maksis
It seems quite clear that the client should move on to other locations when the list of search terms to match gets empty after matching a directory name. But what should happen if there aren't enough matching items to reach the maximum result count? Should it then enter those fully matched director

[Linuxdcpp-team] [Bug 1265889] Re: Return more relevant search results

2014-01-06 Thread maksis
** Also affects: dcplusplus Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1265889 Title: Return more relevant search results Status in AirDC++: Confi

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-10 Thread maksis
It doesn't, now the function throws if the IP is set :p ** Changed in: dcplusplus Status: Fix Committed => New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Title: Resolving addres

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-10 Thread maksis
It's still doesn't work in the same way as my original patch. Please read this: https://bugs.launchpad.net/dcplusplus/+bug/309402/comments/23 It should try connect via both protocols according to the original idea, and I'd say that it's worth of keeping like that (for some reason I've had quite a

[Linuxdcpp-team] [Bug 988891] Re: socks does not seem to work (with putty acting as socks server)

2013-12-10 Thread maksis
Or actually DC++ isn't able to connect to any NMDC hub but my patch for https://bugs.launchpad.net/dcplusplus/+bug/1245179 seems to fix that issue as well (when it's applied without poy's modification) -- You received this bug notification because you are a member of Dcplusplus-team, which is sub

[Linuxdcpp-team] [Bug 988891] Re: socks does not seem to work (with putty acting as socks server)

2013-12-10 Thread maksis
I think I saw someone else reporting this as well, but now when I tested it, everything to work just fine with AirDC++ and DC++ ** Changed in: airdcpp Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
... and what comes to the bug description, this is more about fixing connections to IPv4 addresses when IPv6 isn't available/functioning properly (it's not often the other way around) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. h

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
my bad, even clearing the error wouldn't work, as one of the later attempts may still set it (I've already forgotten what I was thinking when I made that fix...). That fix is part of the latest stable versions of AirDC++ and AirDC++ nano so I consider it to be reliable. The version URL used by

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
Or the purpose of "lastError" was to explain that it only stores the last error that was received... there may have been other errors as well -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Ti

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
The edit that you made is wrong so the problem remains. If resolving the first address fails, lastError gets set. The client will still continue with the other addresses and they may success, but since the error was set, the function will throw. Maybe lastError isn't a good name for it though. You

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
"In Progress: The assigned person is working on it." Hmm? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Title: Resolving addresses with A and entries may fail in some cases Status i

[Linuxdcpp-team] [Bug 395400] Re: Hub lists fail to cache on Linux

2013-12-04 Thread maksis
** Changed in: airdcpp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/395400 Title: Hub lists fail to cache on Linux Status in AirDC++: Fix Released

[Linuxdcpp-team] [Bug 988891] Re: socks does not seem to work (with putty acting as socks server)

2013-12-02 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New ** Changed in: airdcpp Importance: Undecided => Low ** Changed in: airdcpp Status: New => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. http

[Linuxdcpp-team] [Bug 363092] Re: TLS port should not be allowed to be the same as regular ports

2013-12-02 Thread maksis
** Changed in: airdcpp Status: New => Confirmed ** Changed in: airdcpp Importance: Undecided => Medium -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/363092 Title: TLS port should not be

[Linuxdcpp-team] [Bug 395400] Re: Hub lists fail to cache on Linux

2013-12-02 Thread maksis
https://github.com/airdcpp/airgit/commit/d101c6a81ba7913a10867aa6a2063e50cb1abf09 ** Changed in: airdcpp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/39540

[Linuxdcpp-team] [Bug 395400] Re: Hub lists fail to cache on Linux

2013-12-01 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New ** Changed in: airdcpp Status: New => Confirmed ** Changed in: airdcpp Importance: Undecided => Low -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. http

[Linuxdcpp-team] [Bug 804559] Re: portable semaphore implementation

2013-12-01 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New ** Changed in: airdcpp Status: New => Confirmed ** Changed in: airdcpp Importance: Undecided => Low -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. http

[Linuxdcpp-team] [Bug 246080] Re: Infinite connecting to untrusted user when only trusted users are allowed

2013-12-01 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New ** Changed in: airdcpp Status: New => Confirmed ** Changed in: airdcpp Importance: Undecided => Low -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. http

[Linuxdcpp-team] [Bug 363092] Re: TLS port should not be allowed to be the same as regular ports

2013-12-01 Thread maksis
** Also affects: airdcpp Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/363092 Title: TLS port should not be allowed to be the same as regular ports Sta

[Linuxdcpp-team] [Bug 309815] Re: [Feature Request] Different hub icons for different user status (User/Reg/Admin)

2013-11-20 Thread maksis
Ah... I missed the change in r3366 (which isn't the cheapest way to do this). New results with 10 million iterations: Comparison (CID), took 19 ms Comparison (UserPtr), took 22 ms ClientManagerListener::ClientDisconnected(), took 427 ms isSelf(), took 96 ms (not that any of this would make a

[Linuxdcpp-team] [Bug 309815] Re: [Feature Request] Different hub icons for different user status (User/Reg/Admin)

2013-11-20 Thread maksis
Improving performance wasn't fully correct... but there's no actual difference -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/309815 Title: [Feature Request] Different hub icons for different user

  1   2   >