Looks like local file/directory names may also contain invalid characters on non-Windows operating systems (at least on Linux). Those may cause crashes and other issues, such as std::bad_alloc exceptions when generating XML files.
https://github.com/airdcpp-web/airdcpp-webclient/issues/382 https://github.com/airdcpp/airdcpp-windows/commit/a92bf8263b2a12c0258d1306d33e0915ff21d994 ** Bug watch added: github.com/airdcpp-web/airdcpp-webclient/issues #382 https://github.com/airdcpp-web/airdcpp-webclient/issues/382 -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1649066 Title: Invalid UTF-8 data is not always being rejected Status in AirDC++: Fix Released Status in DC++: New Bug description: There are various cases where invalid UTF-8 data is being consumed by the core: 1. Text::convert will return the original string in case of errors (Linux only, respective Windows-specific functions will return an empty string in case of errors) 2. When using "utf-8" encoding in NMDC hubs, the original string will always be returned by conversion functions without validation (generally Linux only since "utf-8" can't be selected from DC++'s GUI) 3. UTF-8 validation is not performed for strings parsed from XML (specifically file/directory names in filelists) This will cause issues especially when the data is processed by external sources/libraries that expect to receive valid UTF-8 data (https://github.com/airdcpp-web/airdcpp-webclient/issues/204). I'm not sure about security implications. Another note: messages that fail UTF-8 validation in ADC hubs are ignored silently. At least Flexhub seems to be having problems with data validation which currently goes unnoticed. To manage notifications about this bug go to: https://bugs.launchpad.net/airdcpp/+bug/1649066/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
