AirDC++ now uses the regular dispatch function for parsing ADC UDP
commands that should fix the issue:
https://github.com/airdcpp/airgit/blob/6a40613788e7ed8a7478f4f1789bbd142a98d231/airdcpp/airdcpp/UDPServer.cpp#L130-L175
** Changed in: airdcpp
Status: New => Fix Released
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1722364
Title:
Invalid ADC commands sent via UDP will crash the app
Status in AirDC++:
Fix Released
Status in ApexDC++:
New
Status in DC++:
New
Status in FlylinkDC++:
New
Bug description:
The AdcCommand parsing function will throw ParseException on invalid
commands:
https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/AdcCommand.cpp#l37
However, SearchManager (UDPServer in AirDC++) won't catch those
exceptions at all:
https://sourceforge.net/p/dcplusplus/code/ci/default/tree/dcpp/SearchManager.cpp#l286
As a result, you should be able to crash the app by sending the following raw
text to the UDP port:
ARES T\n
(I used https://packetsender.com for testing)
To manage notifications about this bug go to:
https://bugs.launchpad.net/airdcpp/+bug/1722364/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~linuxdcpp-team
Post to : linuxdcpp-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~linuxdcpp-team
More help : https://help.launchpad.net/ListHelp
