Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On April 5, 2012, 11:28 a.m., Cristian Oneț wrote: > > Ship It! This commit is available for viewing at: remote: http://commits.kde.org/kmymoney/79451a82f2040cae8b09896ba304d9bbfb14f2db To ssh://g...@git.kde.org/kmymoney 0928b53..79451a8 master -> master - Allan ---

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/#review12188 --- Ship it! Ship It! - Cristian Oneț On March 14, 2012, 6:03 p

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > > > Allan Anderson wrote: > I know you must be busy, but just a quick query in case it's been > overlooked. Is this now OK to commit, please? > > Cristian Oneț wrote: > Well, the diff still lacks the call to 's.setCodec("UTF-8")

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On April 5, 2012, 10:24 a.m., Cristian Oneț wrote: > > kmymoney/converter/mymoneyqifwriter.cpp, line 43 > > > > > > Why is this include needed if a QVarLengthArray is not used from what I > > can see. I'm utterly

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > > > Allan Anderson wrote: > I know you must be busy, but just a quick query in case it's been > overlooked. Is this now OK to commit, please? > > Cristian Oneț wrote: > Well, the diff still lacks the call to 's.setCodec("UTF-8")

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/#review12184 --- kmymoney/converter/mymoneyqifwriter.cpp

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > > > Allan Anderson wrote: > I know you must be busy, but just a quick query in case it's been > overlooked. Is this now OK to commit, please? Well, the diff still lacks the call to 's.setCodec("UTF-8");' so I guess it's not updated

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > I know you must be busy, but just a quick query in case it's been overlooked. Is this now OK to commit, please? - Allan --- This is an automatically generated e-mail. To reply,

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > kmymoney/converter/mymoneyqifwriter.cpp, line 63 > > > > > > Why was this line removed? AFAIK Thomas added it as a fix for a > > reported issue (the exported

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > kmymoney/converter/mymoneyqifwriter.cpp, line 63 > > > > > > Why was this line removed? AFAIK Thomas added it as a fix for a > > reported issue (the exported

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/#review11627 --- kmymoney/converter/mymoneyqifwriter.cpp

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/ --- (Updated March 14, 2012, 6:03 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Add support for export of investment accounts.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/#review11338 --- kmymoney/converter/mymoneyqifwriter.h

[Kmymoney-devel] Review Request: Add support for export of investment accounts.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/ --- Review request for KMymoney. Description --- This was never implement