> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote:
> >
>
> Allan Anderson wrote:
> I know you must be busy, but just a quick query in case it's been
> overlooked. Is this now OK to commit, please?
>
> Cristian Oneț wrote:
> Well, the diff still lacks the call to 's.setCodec("UTF-8");' so I guess
> it's not updated.
No, I didn't think a new diff would be required just for a one-line
re-instatement. It's definitely in back here. Happy to do another diff though.
- Allan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104059/#review11627
-----------------------------------------------------------
On March 14, 2012, 6:03 p.m., Allan Anderson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104059/
> -----------------------------------------------------------
>
> (Updated March 14, 2012, 6:03 p.m.)
>
>
> Review request for KMymoney.
>
>
> Description
> -------
>
> This was never implemented.
>
> Remove unused parameter. Ran astyle.
>
>
> This addresses bug 213284.
> http://bugs.kde.org/show_bug.cgi?id=213284
>
>
> Diffs
> -----
>
> kmymoney/converter/mymoneyqifwriter.h 2f66f9b
> kmymoney/converter/mymoneyqifwriter.cpp 3f76484
>
> Diff: http://git.reviewboard.kde.org/r/104059/diff/
>
>
> Testing
> -------
>
> Numerous qif files imported, exported and re-imported successfully.
> Astyle run.
>
>
> Thanks,
>
> Allan Anderson
>
>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
