----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/#review11338 -----------------------------------------------------------
kmymoney/converter/mymoneyqifwriter.h <http://git.reviewboard.kde.org/r/104059/#comment9077> Please remove this member. kmymoney/converter/mymoneyqifwriter.cpp <http://git.reviewboard.kde.org/r/104059/#comment9078> This should also be removed. kmymoney/converter/mymoneyqifwriter.cpp <http://git.reviewboard.kde.org/r/104059/#comment9080> findSubAccounts is a pretty weird name considering that this function actually exports the sub accounts to the text stream. kmymoney/converter/mymoneyqifwriter.cpp <http://git.reviewboard.kde.org/r/104059/#comment9079> Make it a local variable and pass it to writeInvestmentEntry as a parameter. kmymoney/converter/mymoneyqifwriter.cpp <http://git.reviewboard.kde.org/r/104059/#comment9082> I would not use centered text. kmymoney/converter/mymoneyqifwriter.cpp <http://git.reviewboard.kde.org/r/104059/#comment9081> Unneded extra space in front of 'isXfer' - Cristian Oneț On Feb. 24, 2012, 1:09 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104059/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2012, 1:09 a.m.) > > > Review request for KMymoney. > > > Description > ------- > > This was never implemented. > > Remove unused parameter. Ran astyle. > > > This addresses bug 213284. > http://bugs.kde.org/show_bug.cgi?id=213284 > > > Diffs > ----- > > kmymoney/converter/mymoneyqifwriter.h 2f66f9b > kmymoney/converter/mymoneyqifwriter.cpp 3f76484 > > Diff: http://git.reviewboard.kde.org/r/104059/diff/ > > > Testing > ------- > > Numerous qif files imported, exported and re-imported successfully. > Astyle run. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
