> On March 19, 2012, 6:22 p.m., Cristian Oneț wrote: > > kmymoney/converter/mymoneyqifwriter.cpp, line 63 > > <http://git.reviewboard.kde.org/r/104059/diff/2/?file=53128#file53128line63> > > > > Why was this line removed? AFAIK Thomas added it as a fix for a > > reported issue (the exported data was not UTF-8). > > Allan Anderson wrote: > To be honest, I have absolutely no idea. I do remember noticing it, but > had no issues with it to cause me to disable it. I can only assume it was an > error somehow. > > I'll add it back and test again, but don't expect any issues. >
I think I know what probably happened. I started work on these changes some months back, but didn't want to commit them until the csvimporter work was finalised. When I picked up again, and not what I normally do, I copied the revised file over the original one, because the old one hadn't changed for ages. In the meantime, though, that setCodec line had been added, and I must have missed it, or rather saw it but failed to realise what had happened. It's now back in here and has no impact on my tests. - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104059/#review11627 ----------------------------------------------------------- On March 14, 2012, 6:03 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104059/ > ----------------------------------------------------------- > > (Updated March 14, 2012, 6:03 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > This was never implemented. > > Remove unused parameter. Ran astyle. > > > This addresses bug 213284. > http://bugs.kde.org/show_bug.cgi?id=213284 > > > Diffs > ----- > > kmymoney/converter/mymoneyqifwriter.h 2f66f9b > kmymoney/converter/mymoneyqifwriter.cpp 3f76484 > > Diff: http://git.reviewboard.kde.org/r/104059/diff/ > > > Testing > ------- > > Numerous qif files imported, exported and re-imported successfully. > Astyle run. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
