Re: Review Request 125098: Fix date string displayed in timeline:/ address bar due to porting to QDate

2015-09-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125098/ --- (Updated Sept. 8, 2015, 12:13 a.m.) Review request for Baloo and Vishesh

Review Request 125098: Fix date string when porting to QDate

2015-09-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125098/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Pinak Ahuja
> On Sept. 7, 2015, 2:45 p.m., Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 94 > > > > > > Maybe set the delay to 0 here? That does make sense, since we didn't index a file, might as well call the nex

Re: Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/ --- (Updated Sept. 7, 2015, 5:52 p.m.) Status -- This change has been ma

Re: Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/#review84962 --- Ship it! Seems about right. src/file/extractor/app.cpp (lin

Re: Love for Konqueror

2015-09-07 Thread Allan Sandfeld Jensen
On Monday 07 September 2015, Dāvis Mosāns wrote: > 2015-09-07 12:10 GMT+03:00 Allan Sandfeld Jensen : > >> I think using [1] CEF (Chromium Embedded Framework) could be good idea > >> as then both [2] Blink and [3] Servo can be used. > > > > CEF also doesn't appear to have had an update since Janua

Re: Love for Konqueror

2015-09-07 Thread Dāvis Mosāns
2015-09-07 12:10 GMT+03:00 Allan Sandfeld Jensen : >> I think using [1] CEF (Chromium Embedded Framework) could be good idea as >> then both [2] Blink and [3] Servo can be used. >> > CEF also doesn't appear to have had an update since January 2015. It doesn't > appear regularly maintained. I don't

Re: Desktop file renaming: ark, dolphin, dragonplayer, kig, kiriki, kshisen and picmi

2015-09-07 Thread Matthias Klumpp
2015-09-07 17:35 GMT+02:00 Luigi Toscano : > On Monday 07 of September 2015 17:19:01 Matthias Klumpp wrote: >> Hi there! >> Just FYI, while the specification doesn't demand but only suggests the >> name change, it seems to be essential for the Fedora AppStream data >> generator. >> For that and to

Re: Desktop file renaming: ark, dolphin, dragonplayer, kig, kiriki, kshisen and picmi

2015-09-07 Thread Luigi Toscano
On Monday 07 of September 2015 17:19:01 Matthias Klumpp wrote: > Hi there! > Just FYI, while the specification doesn't demand but only suggests the > name change, it seems to be essential for the Fedora AppStream data > generator. > For that and to do sane naming of the data files, renaming the fil

Re: Desktop file renaming: ark, dolphin, dragonplayer, kig, kiriki, kshisen and picmi

2015-09-07 Thread Matthias Klumpp
Hi there! Just FYI, while the specification doesn't demand but only suggests the name change, it seems to be essential for the Fedora AppStream data generator. For that and to do sane naming of the data files, renaming the files makes sense - although, for the KDE l10n team this means some annoyanc

Re: Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/#review84956 --- src/file/extractor/app.cpp (line 88)

Re: Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/ --- (Updated Sept. 7, 2015, 12:33 p.m.) Review request for Baloo and Vishesh

Re: Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/ --- (Updated Sept. 7, 2015, 12:32 p.m.) Review request for Baloo and Vishesh

Review Request 125090: Add delay after each file instead of each batch

2015-09-07 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Love for Konqueror

2015-09-07 Thread Allan Sandfeld Jensen
On Monday 07 September 2015, Dāvis Mosāns wrote: > > So choice is between which actively maintained web engine to use. > Gecko, Servo, Blink or WebKit2? (QtWebEngine is basically > Chromium/Blink wrapper) > QtWebEngine is not just a wrapper. It is a continously rebased fork and stable API (just

Desktop file renaming: ark, dolphin, dragonplayer, kig, kiriki, kshisen and picmi

2015-09-07 Thread Richard Hughes
Hi, The following apps changed their desktop name (and not updated the AppData file at the same time) in the last few weeks: * ark -> org.kde.ark * dolphin -> org.kde.dolphin * dragonplayer -> org.kde.dragonplayer * kig -> org.kde.kig * kiriki -> org.kde.kiriki * kshisen -> org.kde.kshisen

Re: Review Request 125075: Remove Qt::Widgets dependency from baloo_file

2015-09-07 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125075/ --- (Updated Sept. 7, 2015, 7:15 a.m.) Status -- This change has been ma