> On Sept. 7, 2015, 2:45 p.m., Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 94 > > <https://git.reviewboard.kde.org/r/125090/diff/1/?file=402145#file402145line94> > > > > Maybe set the delay to 0 here?
That does make sense, since we didn't index a file, might as well call the next interation without delay. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125090/#review84956 ----------------------------------------------------------- On Sept. 7, 2015, 5:52 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125090/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2015, 5:52 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > The while loops has been removed as it blocked the event loop and prevented > IdleStateMonitor to update it's state while processing a batch. We have a 10 > ms delay after each file instead of a 500 ms delay after each batch if user > is not idle. > > > Diffs > ----- > > src/file/extractor/app.h f2fa169 > src/file/extractor/app.cpp 8261c62 > > Diff: https://git.reviewboard.kde.org/r/125090/diff/ > > > Testing > ------- > > Manual testing: baloo seems to be working. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
