[GitHub] [maven] filipelautert commented on pull request #1038: [3.9.x] [MNG-7720] Wrong build order of forked projects

filipelautert commented on PR #1038: URL: https://github.com/apache/maven/pull/1038#issuecomment-1458567573 Liquibase build started failing when we switcthed to Maven 3.9.0 , it's a similar issue using the aggregate-jar javadoc goal. Here is a failed build link: https://github.com/liquibas

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #248: MavenITmng5669ReadPomsOnce and BF collector

michael-o commented on code in PR #248: URL: https://github.com/apache/maven-integration-testing/pull/248#discussion_r1128338514 ## .github/workflows/maven-verify.yml: ## @@ -49,7 +49,7 @@ jobs: cache: 'maven' - name: Set up Maven -run: mvn --errors

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1040: [MNG-7720] Wrong build order of forked projects

slawekjaranowski commented on code in PR #1040: URL: https://github.com/apache/maven/pull/1040#discussion_r1128339820 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java: ## @@ -90,7 +90,11 @@ public LifecycleDependencyResolver(

[GitHub] [maven] cstamas commented on a diff in pull request #1040: [MNG-7720] Wrong build order of forked projects

cstamas commented on code in PR #1040: URL: https://github.com/apache/maven/pull/1040#discussion_r1128346697 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java: ## @@ -90,7 +90,11 @@ public LifecycleDependencyResolver( public

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #248: MavenITmng5669ReadPomsOnce and BF collector

slawekjaranowski commented on code in PR #248: URL: https://github.com/apache/maven-integration-testing/pull/248#discussion_r1128376592 ## .github/workflows/maven-verify.yml: ## @@ -49,7 +49,7 @@ jobs: cache: 'maven' - name: Set up Maven -run: mvn --

[GitHub] [maven] cstamas commented on a diff in pull request #1040: [MNG-7720] Wrong build order of forked projects

cstamas commented on code in PR #1040: URL: https://github.com/apache/maven/pull/1040#discussion_r1128379457 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java: ## @@ -90,7 +90,11 @@ public LifecycleDependencyResolver( public

[GitHub] [maven] gnodet commented on a diff in pull request #1033: replace deprecated methods that don't properly handle encoding

gnodet commented on code in PR #1033: URL: https://github.com/apache/maven/pull/1033#discussion_r1128428710 ## maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java: ## @@ -267,19 +266,17 @@ private boolean loadMetadata(

[GitHub] [maven] rmannibucau opened a new pull request, #1041: [MNG-7724] adjust log level for the message when no known binding is found in Slf4jConfigurationFactory

rmannibucau opened a new pull request, #1041: URL: https://github.com/apache/maven/pull/1041 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for

[GitHub] [maven] elharo commented on pull request #1033: replace deprecated methods that don't properly handle encoding

elharo commented on PR #1033: URL: https://github.com/apache/maven/pull/1033#issuecomment-1458804070 Test cases here would be iffy, because the behavior is system dependent and most of the time this will just work. However there can be flaky behavior with non-ASCII characters when the Local

[GitHub] [maven] elharo commented on a diff in pull request #1033: replace deprecated methods that don't properly handle encoding

elharo commented on code in PR #1033: URL: https://github.com/apache/maven/pull/1033#discussion_r1128539504 ## maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java: ## @@ -267,19 +266,17 @@ private boolean loadMetadata(

[GitHub] [maven-shared-utils] slachiewicz commented on pull request #132: Bump plexus-utils from 3.5.0 to 3.5.1

slachiewicz commented on PR #132: URL: https://github.com/apache/maven-shared-utils/pull/132#issuecomment-1458866719 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-shared-utils] slachiewicz merged pull request #132: [MSHARED-1197] Bump plexus-utils from 3.5.0 to 3.5.1

slachiewicz merged PR #132: URL: https://github.com/apache/maven-shared-utils/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [maven-filtering] slachiewicz merged pull request #69: [MSHARED-1198] Bump plexus-utils from 3.4.2 to 3.5.1

slachiewicz merged PR #69: URL: https://github.com/apache/maven-filtering/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[GitHub] [maven-surefire] olamy commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter

olamy commented on PR #617: URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1458889130 the change is larger than what the description says... especially dependencies resolves in a different way so jira PR title needs to be updated. such change can definitely breaks

[GitHub] [maven-filtering] slachiewicz closed pull request #61: Bump maven-shared-components from 36 to 39

slachiewicz closed pull request #61: Bump maven-shared-components from 36 to 39 URL: https://github.com/apache/maven-filtering/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-filtering] dependabot[bot] commented on pull request #61: Bump maven-shared-components from 36 to 39

dependabot[bot] commented on PR #61: URL: https://github.com/apache/maven-filtering/pull/61#issuecomment-1458890074 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [maven-filtering] slachiewicz merged pull request #70: [MSHARED-1199] Upgrade parent pom to 39

slachiewicz merged PR #70: URL: https://github.com/apache/maven-filtering/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[GitHub] [maven-resources-plugin] slachiewicz closed pull request #50: Bump plexus-utils from 3.4.2 to 3.5.1

slachiewicz closed pull request #50: Bump plexus-utils from 3.4.2 to 3.5.1 URL: https://github.com/apache/maven-resources-plugin/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-resources-plugin] dependabot[bot] commented on pull request #50: Bump plexus-utils from 3.4.2 to 3.5.1

dependabot[bot] commented on PR #50: URL: https://github.com/apache/maven-resources-plugin/pull/50#issuecomment-1458919016 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-resources-plugin] slachiewicz commented on pull request #51: Bump maven-resolver-api from 1.6.3 to 1.9.6

slachiewicz commented on PR #51: URL: https://github.com/apache/maven-resources-plugin/pull/51#issuecomment-1458920136 @dependabot ignore this minor version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-resources-plugin] dependabot[bot] closed pull request #51: Bump maven-resolver-api from 1.6.3 to 1.9.6

dependabot[bot] closed pull request #51: Bump maven-resolver-api from 1.6.3 to 1.9.6 URL: https://github.com/apache/maven-resources-plugin/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-resources-plugin] dependabot[bot] commented on pull request #51: Bump maven-resolver-api from 1.6.3 to 1.9.6

dependabot[bot] commented on PR #51: URL: https://github.com/apache/maven-resources-plugin/pull/51#issuecomment-1458920194 OK, I won't notify you about version 1.9.x again, unless you re-open this PR. 😢 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [maven-resources-plugin] slachiewicz merged pull request #52: [MRESOURCES-294] Upgrade plexus-utils to 3.5.1

slachiewicz merged PR #52: URL: https://github.com/apache/maven-resources-plugin/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven] gnodet opened a new pull request, #1042: [MNG-7710] Upgrade plexus-utils to 3.5.1

gnodet opened a new pull request, #1042: URL: https://github.com/apache/maven/pull/1042 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet commented on a diff in pull request #1005: Replace some old, pre-Java 7 Plexus code

gnodet commented on code in PR #1005: URL: https://github.com/apache/maven/pull/1005#discussion_r1128674018 ## maven-compat/pom.xml: ## @@ -100,6 +100,10 @@ under the License. org.apache.maven.wagon wagon-provider-api + + commons-io + commons-io

[GitHub] [maven] michael-o commented on a diff in pull request #1005: Replace some old, pre-Java 7 Plexus code

michael-o commented on code in PR #1005: URL: https://github.com/apache/maven/pull/1005#discussion_r1128684066 ## maven-compat/pom.xml: ## @@ -100,6 +100,10 @@ under the License. org.apache.maven.wagon wagon-provider-api + + commons-io + commons

[GitHub] [maven] gnodet commented on a diff in pull request #1005: Replace some old, pre-Java 7 Plexus code

gnodet commented on code in PR #1005: URL: https://github.com/apache/maven/pull/1005#discussion_r1128687681 ## maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java: ## @@ -48,11 +47,9 @@ public ProfilesRoot buildProfiles(File basedir) throws IOE

[GitHub] [maven] gnodet opened a new pull request, #1043: Fix callee closing streams and readers instead of callers

gnodet opened a new pull request, #1043: URL: https://github.com/apache/maven/pull/1043 For compatibility reason, the Xpp3DomBuilder will close those Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue

[GitHub] [maven] gnodet opened a new pull request, #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

gnodet opened a new pull request, #1044: URL: https://github.com/apache/maven/pull/1044 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

gnodet commented on PR #1005: URL: https://github.com/apache/maven/pull/1005#issuecomment-1458990021 > @gnodet Can we finally change the semantics here? The caller opens the stream then he must close it? I've raised #1043 to change the behaviour here. I've also raised #1044 to

[GitHub] [maven] gnodet commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

gnodet commented on PR #1005: URL: https://github.com/apache/maven/pull/1005#issuecomment-1458991569 I'm closing this PR which is superseded by #1043 and #1044. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven] gnodet closed pull request #1005: Replace some old, pre-Java 7 Plexus code

gnodet closed pull request #1005: Replace some old, pre-Java 7 Plexus code URL: https://github.com/apache/maven/pull/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [maven] michael-o commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

michael-o commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1128707959 ## maven-xml-impl/src/main/java/org/codehaus/plexus/util/xml/Xpp3DomBuilder.java: ## @@ -62,8 +64,10 @@ public static Xpp3Dom build(Reader reader, boolean trim) throws

[GitHub] [maven-mvnd] gnodet merged pull request #796: Provide distributions for both maven 3.9.x and 4.0.x

gnodet merged PR #796: URL: https://github.com/apache/maven-mvnd/pull/796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[GitHub] [maven-resolver] slawekjaranowski opened a new pull request, #267: [MRESOLVER-339] Preemptive auth fix

slawekjaranowski opened a new pull request, #267: URL: https://github.com/apache/maven-resolver/pull/267 Fix from 7c06f7045cf90012883002f41a5245402b00b849 was partially reverted by 28fec45f15f24bbee8b3584f09425e75ae7104ab -- This is an automated message from the Apache Git Service. To r

[GitHub] [maven] gnodet commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

gnodet commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1128725418 ## maven-xml-impl/src/main/java/org/codehaus/plexus/util/xml/Xpp3DomBuilder.java: ## @@ -62,8 +64,10 @@ public static Xpp3Dom build(Reader reader, boolean trim) throws Xm

[GitHub] [maven] michael-o commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

michael-o commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1128733052 ## maven-xml-impl/src/main/java/org/codehaus/plexus/util/xml/Xpp3DomBuilder.java: ## @@ -62,8 +64,10 @@ public static Xpp3Dom build(Reader reader, boolean trim) throws

[GitHub] [maven] michael-o commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

michael-o commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1128739066 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -60,7 +59,7 @@ public void validate(Settings settings,

[GitHub] [maven-invoker-plugin] slawekjaranowski opened a new pull request, #179: Add optional dependency for install ITs

slawekjaranowski opened a new pull request, #179: URL: https://github.com/apache/maven-invoker-plugin/pull/179 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVO

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #179: Add optional dependency for install ITs

slawekjaranowski commented on PR #179: URL: https://github.com/apache/maven-invoker-plugin/pull/179#issuecomment-1459038908 Install with optional dependencies - looks work. @olamy - do you had a similar case or another -- This is an automated message from the Apache Git Service. To res

[GitHub] [maven] elharo merged pull request #1033: Replace deprecated methods that don't properly handle encoding

elharo merged PR #1033: URL: https://github.com/apache/maven/pull/1033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven] elharo commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

elharo commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1128780743 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] adjust log level for the message when no known binding is found in Slf4jConfigurationFactory

elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1128785518 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(ILogg

[GitHub] [maven] elharo commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

elharo commented on PR #1005: URL: https://github.com/apache/maven/pull/1005#issuecomment-1459078533 I'm not sold on either #1043 or #1044. Just maybe we can kill the class completely but leaving it in place while making it return null seems the worst of both worlds. -- This is an autom

[GitHub] [maven] elharo commented on a diff in pull request #1005: Replace some old, pre-Java 7 Plexus code

elharo commented on code in PR #1005: URL: https://github.com/apache/maven/pull/1005#discussion_r1128791936 ## maven-compat/pom.xml: ## @@ -100,6 +100,10 @@ under the License. org.apache.maven.wagon wagon-provider-api + + commons-io + commons-io

[GitHub] [maven] gnodet commented on pull request #1043: Fix callee closing streams and readers instead of callers

gnodet commented on PR #1043: URL: https://github.com/apache/maven/pull/1043#issuecomment-1459625925 > I don't think every PR needs a JIRA, bu since this one changes behavior of a public method it's probably worth one and wider discussion. @elharo Fwiw, `XmlNodeBuilder` has been intro

[GitHub] [maven-apache-parent] hboutemy merged pull request #121: [MPOM-386] update documentation to match previous changes in pom.xml

hboutemy merged PR #121: URL: https://github.com/apache/maven-apache-parent/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on pull request #45: [MPIR-429] disable plugin processing when building projects

hboutemy commented on PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#issuecomment-1459647709 analysis done https://issues.apache.org/jira/browse/MDEP-630 : issue happens in Maven's lifecycle bindings injector = something that is optional, used when the eff

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

slawekjaranowski commented on PR #617: URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1459669226 @olamy jira issue updated - any remarks to change? As we see all ITs pass without changes -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-resolver] cstamas merged pull request #267: [MRESOLVER-339] Preemptive auth fix

cstamas merged PR #267: URL: https://github.com/apache/maven-resolver/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven] cstamas merged pull request #1038: [3.9.x] [MNG-7720] Wrong build order of forked projects

cstamas merged PR #1038: URL: https://github.com/apache/maven/pull/1038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] cstamas merged pull request #1039: [3.8.x] [MNG-7720] Wrong build order of forked projects

cstamas merged PR #1039: URL: https://github.com/apache/maven/pull/1039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] cstamas merged pull request #1040: [MNG-7720] Wrong build order of forked projects

cstamas merged PR #1040: URL: https://github.com/apache/maven/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] gnodet opened a new pull request, #1045: Remove references to Xpp3DomBuilder and use XmlNodeBuilder instead

gnodet opened a new pull request, #1045: URL: https://github.com/apache/maven/pull/1045 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

gnodet commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459705561 > I'm not sure I understand the purpose of this. This also is singificant enough to deserve a JIRA issue. The purpose is to: * remove references to plexus-utils * fix encoding

[GitHub] [maven] gnodet commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

gnodet commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459707799 > Does this make sense to fiddle with compat although we want to get rid of it? Well, we want to get rid of it, but I think that won't be tomorrow. So in the mean time -- This

[GitHub] [maven] michael-o commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

michael-o commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459747839 > > Does this make sense to fiddle with compat although we want to get rid of it? > > Well, we want to get rid of it, but I think that won't be tomorrow. So in the mean time

[GitHub] [maven] gnodet commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

gnodet commented on PR #1005: URL: https://github.com/apache/maven/pull/1005#issuecomment-1459770337 > I'm not sold on either #1043 or #1044. Just maybe we can kill the class completely but leaving it in place while making it return null seems the worst of both worlds. The autoclose

[GitHub] [maven] gnodet commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

gnodet commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459791564 @elharo would you prefer removing the `DefaultMavenProfilesBuilder` implementation class completely ? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] adjust log level for the message when no known binding is found in Slf4jConfigurationFactory

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129153394 ## maven-embedder/src/test/java/org/apache/maven/cli/logging/Slf4jConfigurationFactoryTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] adjust log level for the message when no known binding is found in Slf4jConfigurationFactory

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129155652 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(

[GitHub] [maven] gnodet commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

gnodet commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1129178097 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven-surefire] olamy commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

olamy commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129203092 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java: ## @@ -59,7 +62,10 @@ * @author Stephen Connolly * @auth

[GitHub] [maven-surefire] slachiewicz commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

slachiewicz commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129237191 ## maven-surefire-common/pom.xml: ## @@ -52,6 +52,12 @@ maven-core provided + + org.eclipse.aether + aether-util + Rev

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

slawekjaranowski commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299228 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java: ## @@ -59,7 +62,10 @@ * @author Stephen Connoll

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

slawekjaranowski commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299455 ## maven-surefire-common/pom.xml: ## @@ -52,6 +52,12 @@ maven-core provided + + org.eclipse.aether + aether-util +

[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #45: [MPIR-429] disable plugin processing when building projects

michael-o commented on PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#issuecomment-1460103694 Nice one. Does it make sense to revert MPIR-374? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven] elharo commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

elharo commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1129389367 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129397818 ## maven-embedder/src/test/java/org/apache/maven/cli/logging/Slf4jConfigurationFactoryTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r112947 ## maven-embedder/src/test/java/org/apache/maven/cli/logging/Slf4jConfigurationFactoryTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129400840 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(ILogg

[GitHub] [maven] elharo commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

elharo commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1460135546 When did we deprecate it? If we can simply remove it in 4.0.0, that solves all problems. I will raise a question on the dev mailing list about whether we should start ripping out the depreca

[GitHub] [maven] rmannibucau commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

rmannibucau commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1460149135 @elharo it already returns null in 99% of the cases so guess this is not a behavior change -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129421297 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129424545 ## maven-embedder/pom.xml: ## @@ -140,6 +140,12 @@ under the License. slf4j-simple true + + org.slf4j + slf4j-jdk14 Review Comment: D

[GitHub] [maven] gnodet commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

gnodet commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1129437408 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on pull request #45: [MPIR-429] disable plugin processing when building projects

hboutemy commented on PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#issuecomment-1460164276 I think that MPIR-374 still makes sense: no need to add eventual noise -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129441351 ## maven-embedder/pom.xml: ## @@ -140,6 +140,12 @@ under the License. slf4j-simple true + + org.slf4j + slf4j-jdk14 Review Comment:

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129443535 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/JDKConfiguration.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven-site] michael-o opened a new pull request, #395: Add release notes for Maven 3.8.8

michael-o opened a new pull request, #395: URL: https://github.com/apache/maven-site/pull/395 This closes #395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129447663 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/NoopConfiguration.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129448236 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/JDKConfiguration.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #45: [MPIR-429] disable plugin processing when building projects

michael-o commented on code in PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#discussion_r1129449003 ## src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java: ## @@ -206,6 +206,7 @@ private void renderSectionPluginManage

[GitHub] [maven-site] michael-o commented on pull request #395: Add release notes for Maven 3.8.8

michael-o commented on PR #395: URL: https://github.com/apache/maven-site/pull/395#issuecomment-1460200268 What I don't like is that 3.8.x is not visible anymore. I guess we should add a section for 3.8.x as well, at least until 3.9.x is stable. -- This is an automated message from the Ap

[GitHub] [maven-site] michael-o opened a new pull request, #396: Remove currentStableReleaseDate value

michael-o opened a new pull request, #396: URL: https://github.com/apache/maven-site/pull/396 This value was used in the days when the Maven distro included a buld date. This closes #396 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [maven-build-cache-extension] atsteffen commented on a diff in pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

atsteffen commented on code in PR #43: URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1129557444 ## src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java: ## @@ -173,11 +173,14 @@ public CacheResult findCachedBuild( LOGG

[GitHub] [maven-build-cache-extension] atsteffen commented on a diff in pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

atsteffen commented on code in PR #43: URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1129560328 ## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ## @@ -452,28 +453,29 @@ public boolean isEnabled() { @Override publ

[GitHub] [maven] rmannibucau commented on pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on PR #1041: URL: https://github.com/apache/maven/pull/1041#issuecomment-1460329789 @elharo jul is jdk14 one (the PR adds its support, was not there not sure why), noop is kind of built-in but defeats the fact to log a warning on a random logger (but this is another ti

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on a diff in pull request #45: [MPIR-429] disable plugin processing when building projects

hboutemy commented on code in PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#discussion_r1129631263 ## src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java: ## @@ -206,6 +206,7 @@ private void renderSectionPluginManagem

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on a diff in pull request #45: [MPIR-429] disable plugin processing when building projects

hboutemy commented on code in PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#discussion_r1129650811 ## src/main/java/org/apache/maven/report/projectinfo/PluginsReport.java: ## @@ -192,6 +192,7 @@ private void renderSectionPlugins( boolean isPlu

[GitHub] [maven-project-info-reports-plugin] hboutemy merged pull request #45: [MPIR-429] disable plugin processing when building projects

hboutemy merged PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [maven] elharo commented on pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

elharo commented on PR #1041: URL: https://github.com/apache/maven/pull/1041#issuecomment-1460414960 Why does Maven add that layer? Can it simply remove it instead? If I had a greenfield, I'd just use java.util.logging and not allow any other log libraries within ten dependency chains of co

[GitHub] [maven] rmannibucau commented on pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

rmannibucau commented on PR #1041: URL: https://github.com/apache/maven/pull/1041#issuecomment-1460420631 Fully agree JUL is way saner for products like maven but this is a long debate. If we remove it we drop the `--fail-on-severity` flag so not sure we can in 4.x. -- This is an auto

[GitHub] [maven] gnodet commented on pull request #1037: [MNG-7723] Upgrade to Maven Resolver 1.9.7

gnodet commented on PR #1037: URL: https://github.com/apache/maven/pull/1037#issuecomment-1460471083 Please create a similar PR for `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] cstamas opened a new pull request, #1046: [MNG-7723] Upgrade to Maven Resolver 1.9.7

cstamas opened a new pull request, #1046: URL: https://github.com/apache/maven/pull/1046 That carries mostly transport-http bugfixes and improvements. --- https://issues.apache.org/jira/browse/MNG-7723 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven] cstamas commented on pull request #1037: [MNG-7723] Upgrade to Maven Resolver 1.9.7

cstamas commented on PR #1037: URL: https://github.com/apache/maven/pull/1037#issuecomment-1460479206 Created https://github.com/apache/maven/pull/1046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-surefire] cstamas commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

cstamas commented on PR #617: URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1460572120 Another example of insane overhead of all legacy stuff: 800 lines less! Great job @slawekjaranowski -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-wrapper] slawekjaranowski opened a new pull request, #94: [MWRAPPER-85] Mention only-script type for binary less installations

slawekjaranowski opened a new pull request, #94: URL: https://github.com/apache/maven-wrapper/pull/94 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) file

[GitHub] [maven-help-plugin] slawekjaranowski closed pull request #80: Bump maven-plugins from 37 to 39

slawekjaranowski closed pull request #80: Bump maven-plugins from 37 to 39 URL: https://github.com/apache/maven-help-plugin/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #80: Bump maven-plugins from 37 to 39

dependabot[bot] commented on PR #80: URL: https://github.com/apache/maven-help-plugin/pull/80#issuecomment-1460796292 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

<    2   3   4   5   6   7   8   9   10   11   >