slawekjaranowski commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299228
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java:
##########
@@ -59,7 +62,10 @@
* @author Stephen Connolly
* @author Kristian Rosenvold
*/
-final class SurefireDependencyResolver {
+@Named
+@Singleton
+public class SurefireDependencyResolver {
Review Comment:
I changed to package private.
The best way will be introduce interface for this component and move
implementation to another place
but this class contains a static methods which is used in
AbstractSurefireMojo.
So usage is mixed, I would not extends this PR too more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
