gnodet commented on code in PR #1005:
URL: https://github.com/apache/maven/pull/1005#discussion_r1128687681
##########
maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java:
##########
@@ -48,11 +47,9 @@ public ProfilesRoot buildProfiles(File basedir) throws
IOException, XmlPullParse
if (profilesXml.exists()) {
Review Comment:
This method suffers from encoding problems and appears to not be used. I'd
rather just return null for this method and remove the dependency on
plexus-utils and the encoding problems altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
