gnodet commented on PR #1005: URL: https://github.com/apache/maven/pull/1005#issuecomment-1459770337
> I'm not sold on either #1043 or #1044. Just maybe we can kill the class completely but leaving it in place while making it return null seems the worst of both worlds. The autoclose mechanism implies that in the general case the responsibility of closing a stream lies in the caller's hand. Opening a resource in a _open-and-forget_ mode should be done only in very specific cases where this is actually required. I don't think reading an xml is such a use case (at least not in the context of maven) where the caller will use the parsed xml right away. So I think we should make things more intuitive and just do what is usually expected. Also, there are a bunch of use cases where one need to wrap input into a no-op closeable input because of such behaviours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
