davewichers commented on issue #189:
URL:
https://github.com/apache/maven-pmd-plugin/issues/189#issuecomment-2901349915
I need this too! I just ran into this problem yesterday and can't figure out
any way to configure the pmd-maven-plugin to only generate the XMLfindings
file, but NOT the
elharo commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2102727275
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##
@@ -109,8 +109,7 @@ private InnerInterpolator createInterpolator(
elharo commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2102736286
##
impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##
@@ -306,7 +306,7 @@ private void doExecute(MavenSession session, MojoExecution
elharo commented on code in PR #2370:
URL: https://github.com/apache/maven/pull/2370#discussion_r2102744708
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -95,7 +95,11 @@ pub
elharo commented on code in PR #2375:
URL: https://github.com/apache/maven/pull/2375#discussion_r2102738693
##
impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java:
##
@@ -79,6 +79,7 @@ void testAptConsistency() throws Exception {
elharo commented on code in PR #2368:
URL: https://github.com/apache/maven/pull/2368#discussion_r2102751676
##
its/core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/src/main/java/org/apache/maven/plugin/coreit/AbstractDependencyMojo.java:
##
@@ -222,11 +222,7
elharo closed pull request #2368: chore: `AbstractDependencyMojo` PMD-Rule:
`EmptyControlStatement`
URL: https://github.com/apache/maven/pull/2368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
desruisseaux commented on PR #2367:
URL: https://github.com/apache/maven/pull/2367#issuecomment-2901515985
This pull request provides small changes addressing exactly the discussion
point, while #2365 is a larger set of changes which includes questionable
changes (e.g. the introduction of t
desruisseaux commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2102767750
##
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##
@@ -50,8 +50,6 @@ public class DefaultUpdateCheckManager e
mhoffrog commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2901711652
@hboutemy I could move my PRs branch to commit
8b44e4f6745e7bd677428be093921267317b8fe8 of the current master and force push
my branch. Maybe GitHub would recognize it on this PR and mar
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953497#comment-17953497
]
ASF GitHub Bot commented on SCM-1028:
-
mhoffrog commented on PR #237:
URL: https://gith
gnodet opened a new pull request, #2378:
URL: https://github.com/apache/maven/pull/2378
JIRA issue: [MNG-8736](https://issues.apache.org/jira/browse/MNG-8736)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slawekjaranowski commented on issue #189:
URL:
https://github.com/apache/maven-pmd-plugin/issues/189#issuecomment-2901971671
I would like to try a refactor, simply `check` is not a report goal ... so
we should not call a report by directly `PmdExecutor` where is needed.
--
This is an aut
dependabot[bot] opened a new pull request, #243:
URL: https://github.com/apache/maven-scm/pull/243
Bumps
[org.eclipse.jgit:org.eclipse.jgit](https://github.com/eclipse-jgit/jgit) from
5.13.3.20240512-r to 7.2.1.202505142326-r.
Commits
https://github.com/eclipse-jgit/jgit/c
[
https://issues.apache.org/jira/browse/MNG-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8736:
-
Fix Version/s: 4.0.0-rc-4
> Incorrect profile activation for multi-module concurrent build
> --
[
https://issues.apache.org/jira/browse/MNG-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8736:
Assignee: Guillaume Nodet
> Incorrect profile activation for multi-module concurrent build
>
pzygielo commented on issue #189:
URL:
https://github.com/apache/maven-pmd-plugin/issues/189#issuecomment-2901387446
I had similar problem: https://issues.apache.org/jira/browse/MPMD-403 (for
different reason but I wanted similar outcome).
https://issues.apache.org/jira/browse/MPMD-
Bukama merged PR #603:
URL: https://github.com/apache/maven-deploy-plugin/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ma
Bukama merged PR #156:
URL: https://github.com/apache/maven-filtering/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.
Bukama commented on issue #189:
URL:
https://github.com/apache/maven-pmd-plugin/issues/189#issuecomment-2902389955
Haha talked with @khmarbaise about this confusing situation too at work.
Please do it for both `pmd` and `cpd` goals and try to avoid the need the
fork, so generating th
slawekjaranowski merged PR #205:
URL: https://github.com/apache/maven-pmd-plugin/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
slawekjaranowski opened a new pull request, #206:
URL: https://github.com/apache/maven-pmd-plugin/pull/206
Standard mojos and reports have different parent classes, so we need to
extract tasks which both will execute.
We cannot use one abstract for both.
--
This is an autom
slawekjaranowski opened a new pull request, #207:
URL: https://github.com/apache/maven-pmd-plugin/pull/207
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
slawekjaranowski commented on issue #189:
URL:
https://github.com/apache/maven-pmd-plugin/issues/189#issuecomment-2902514647
Firs step of refactor:
- #206
Will be easier use executors in reports and mojos
--
This is an automated message from the Apache Git Service.
To resp
gnodet merged PR #2355:
URL: https://github.com/apache/maven/pull/2355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
Guillaume Nodet created MNG-8737:
Summary: Bump xmlunitVersion from 2.10.0 to 2.10.1
Key: MNG-8737
URL: https://issues.apache.org/jira/browse/MNG-8737
Project: Maven
Issue Type: Task
[
https://issues.apache.org/jira/browse/MNG-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8737.
Resolution: Fixed
> Bump xmlunitVersion from 2.10.0 to 2.10.1
> -
[
https://issues.apache.org/jira/browse/MNG-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8737:
Assignee: Guillaume Nodet
> Bump xmlunitVersion from 2.10.0 to 2.10.1
>
[
https://issues.apache.org/jira/browse/MNG-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8737:
-
Fix Version/s: 4.0.0-rc-4
> Bump xmlunitVersion from 2.10.0 to 2.10.1
> ---
Guillaume Nodet created MNG-8738:
Summary: Bump mockitoVersion from 5.17.0 to 5.18.0
Key: MNG-8738
URL: https://issues.apache.org/jira/browse/MNG-8738
Project: Maven
Issue Type: Task
gnodet merged PR #2335:
URL: https://github.com/apache/maven/pull/2335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
Guillaume Nodet created MNG-8739:
Summary: Bump net.sourceforge.pmd:pmd-core from 7.12.0 to 7.13.0
Key: MNG-8739
URL: https://issues.apache.org/jira/browse/MNG-8739
Project: Maven
Issue Type:
[
https://issues.apache.org/jira/browse/MNG-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8739.
Fix Version/s: 4.0.0-rc-4
Assignee: Guillaume Nodet
Resolution: Fixed
> Bump net.sour
[
https://issues.apache.org/jira/browse/MNG-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8738:
-
Fix Version/s: 4.0.0-rc-4
> Bump mockitoVersion from 5.17.0 to 5.18.0
> ---
gnodet merged PR #2362:
URL: https://github.com/apache/maven/pull/2362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
dependabot[bot] commented on PR #2356:
URL: https://github.com/apache/maven/pull/2356#issuecomment-2902539826
Superseded by #2379.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
dependabot[bot] opened a new pull request, #2379:
URL: https://github.com/apache/maven/pull/2379
Bumps `jlineVersion` from 3.30.0 to 3.30.3.
Updates `org.jline:jline-reader` from 3.30.0 to 3.30.3
Release notes
Sourced from https://github.com/jline/jline3/releases";>org.jline:jlin
dependabot[bot] closed pull request #2356: Bump jlineVersion from 3.30.0 to
3.30.2
URL: https://github.com/apache/maven/pull/2356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
gnodet commented on code in PR #401:
URL:
https://github.com/apache/maven-plugin-tools/pull/401#discussion_r2103388541
##
maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/PluginDescriptorHelper.java:
##
Review Comment:
We could, but I still think being ab
Guillaume Nodet created MNG-8740:
Summary: Bump jlineVersion from 3.30.0 to 3.30.3
Key: MNG-8740
URL: https://issues.apache.org/jira/browse/MNG-8740
Project: Maven
Issue Type: Task
[
https://issues.apache.org/jira/browse/MNG-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8738.
Resolution: Fixed
> Bump mockitoVersion from 5.17.0 to 5.18.0
> -
slawekjaranowski commented on code in PR #401:
URL:
https://github.com/apache/maven-plugin-tools/pull/401#discussion_r2103394138
##
maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/PluginDescriptorHelper.java:
##
Review Comment:
so should we do it in bran
cstamas opened a new pull request, #2380:
URL: https://github.com/apache/maven/pull/2380
Simple ability to make Maven 4 "work like Maven 3" would. TBD "inliner"
transformer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gnodet commented on code in PR #401:
URL:
https://github.com/apache/maven-plugin-tools/pull/401#discussion_r2103440094
##
maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/PluginDescriptorHelper.java:
##
Review Comment:
> so should we do it in branch: mave
lbruun opened a new pull request, #166:
URL: https://github.com/apache/maven-wrapper/pull/166
The "This code is licensed to ASF" license header on the generated
`./mvn/wrapper/maven-wrapper.properties` file does not make sense. The file is
the user's, not ASF's. It is generated as a conveni
[
https://issues.apache.org/jira/browse/MWRAPPER-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953385#comment-17953385
]
ASF GitHub Bot commented on MWRAPPER-158:
-
lbruun opened a new pull request, #1
[
https://issues.apache.org/jira/browse/MWRAPPER-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953387#comment-17953387
]
ASF GitHub Bot commented on MWRAPPER-158:
-
lbruun commented on PR #166:
URL: ht
[
https://issues.apache.org/jira/browse/MWRAPPER-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Bruun-Hansen updated MWRAPPER-158:
---
Priority: Major (was: Trivial)
> Remove ASF header on generated maven-wrapper.prop
lbruun commented on PR #166:
URL: https://github.com/apache/maven-wrapper/pull/166#issuecomment-2900598668
CI pipeline currently blocked by
[MWRAPPER-159](https://issues.apache.org/jira/browse/MWRAPPER-159)
--
This is an automated message from the Apache Git Service.
To respond to the mes
Pankraz76 opened a new pull request, #2375:
URL: https://github.com/apache/maven/pull/2375
provide only fixup for UnusedLocalVariable, no refactoring like in
- https://github.com/apache/maven/pull/2365
--
This is an automated message from the Apache Git Service.
To respond to the me
hboutemy commented on issue #726:
URL: https://github.com/apache/maven-site/issues/726#issuecomment-2900251468
great view: we just need to start simple with the 2 index pages for (future)
Maven 4
we act as if Maven 3 was obsolete: it's the default, and will remain, we
just need to create
Pankraz76 commented on PR #2365:
URL: https://github.com/apache/maven/pull/2365#issuecomment-2900310652
its the same topic like done in:
- https://github.com/apache/maven/pull/2367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Pankraz76 commented on PR #2367:
URL: https://github.com/apache/maven/pull/2367#issuecomment-2900312063
whats he issue with this one?
- https://github.com/apache/maven/pull/2365
assuming its the same solution for common problem.
--
This is an automated message from the Apache Git
Pankraz76 commented on PR #2364:
URL: https://github.com/apache/maven/pull/2364#issuecomment-2900369354
> avoid noise and unnecessary notifications
why cant we apply this valuable pattern inside the code too?
`true ? false`
is the logically same like
`((true) ? (((false)))
Pankraz76 closed pull request #2371: chore: `DefaultArtifactDeployer` PMD-Rule:
`EmptyControlStatement`
URL: https://github.com/apache/maven/pull/2371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Pankraz76 closed pull request #2372: chore:
`PluginParameterExpressionEvaluator` PMD-Rule: `EmptyControlStatement`
URL: https://github.com/apache/maven/pull/2372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Pankraz76 commented on PR #2371:
URL: https://github.com/apache/maven/pull/2371#issuecomment-2900409558
reopen when capa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Pankraz76 commented on PR #2372:
URL: https://github.com/apache/maven/pull/2372#issuecomment-2900409359
reopen when capa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Pankraz76 commented on code in PR #2347:
URL: https://github.com/apache/maven/pull/2347#discussion_r2102002464
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java:
##
@@ -191,18 +210,14 @@ public DependencyResolverResult
resolve(DependencyResol
Pankraz76 opened a new pull request, #2376:
URL: https://github.com/apache/maven/pull/2376
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
Pankraz76 opened a new pull request, #2377:
URL: https://github.com/apache/maven/pull/2377
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for t
lbruun commented on PR #144:
URL: https://github.com/apache/maven-wrapper/pull/144#issuecomment-2900434354
If user has already set the `JAVA_HOME` then this code will not take that
into account.
In other words, the step need to surrounded by:
```bash
if [ -z "$JAVA_HOME" ]; then
Pankraz76 commented on PR #2377:
URL: https://github.com/apache/maven/pull/2377#issuecomment-2900448273
waiting for https://github.com/apache/maven/pull/2376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Pankraz76 closed pull request #2377: chore: `DefaultUpdateCheckManager` unused
parameter `RepositoryMetadata metadata`
URL: https://github.com/apache/maven/pull/2377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sparsick commented on code in PR #846:
URL: https://github.com/apache/maven-surefire/pull/846#discussion_r2101847427
##
pom.xml:
##
@@ -376,6 +376,11 @@
+
+ org.apache.maven.plugins
+ maven-changes-plugin
+ 2
sparsick commented on code in PR #846:
URL: https://github.com/apache/maven-surefire/pull/846#discussion_r2101849887
##
pom.xml:
##
@@ -376,6 +376,11 @@
+
+ org.apache.maven.plugins
+ maven-changes-plugin
+ 2
sparsick commented on issue #726:
URL: https://github.com/apache/maven-site/issues/726#issuecomment-2900228178
> Some thoughts about some points you suggest:
>
> Articles of the page are constantly updated, because most of it applies to
all Maven version. So I don't think we should re
michael-o commented on code in PR #2346:
URL: https://github.com/apache/maven/pull/2346#discussion_r2103815665
##
maven-settings/src/main/mdo/settings.mdo:
##
@@ -581,7 +581,18 @@
]]>
-
+
+ ids
+ 1.3.0+
+
kwin commented on code in PR #2346:
URL: https://github.com/apache/maven/pull/2346#discussion_r2103812902
##
maven-settings/src/main/mdo/settings.mdo:
##
@@ -581,7 +581,18 @@
]]>
-
+
+ ids
+ 1.3.0+
+
+
slawekjaranowski commented on PR #24:
URL:
https://github.com/apache/maven-reporting-api/pull/24#issuecomment-2903339929
I don't see change in asf.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
slawekjaranowski commented on code in PR #25:
URL:
https://github.com/apache/maven-reporting-api/pull/25#discussion_r2103858747
##
.github/pull_request_template.md:
##
Review Comment:
I'm not sure if PR template can be maintained by branches
--
This is an automated mes
slawekjaranowski commented on code in PR #24:
URL:
https://github.com/apache/maven-reporting-api/pull/24#discussion_r2103861259
##
.github/release-drafter.yml:
##
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
slawekjaranowski commented on PR #68:
URL:
https://github.com/apache/maven-reporting-impl/pull/68#issuecomment-2903358917
similar here should we want to develop 3.x, such we have a release
version on master?
--
This is an automated message from the Apache Git Service.
To respond to
slawekjaranowski commented on code in PR #67:
URL:
https://github.com/apache/maven-reporting-impl/pull/67#discussion_r2103862530
##
.github/release-drafter.yml:
##
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agre
Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2103900101
##
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##
@@ -50,8 +50,6 @@ public class DefaultUpdateCheckManager exte
liangjihua opened a new issue, #274:
URL: https://github.com/apache/maven-archetype/issues/274
### Affected version
3.4.0
### Bug description
For example, I have an archetype like this:
```
|- __rootArtifactId__-openapi
|- api
| - index.ts
`
michael-o commented on PR #25:
URL:
https://github.com/apache/maven-reporting-api/pull/25#issuecomment-2903431849
> I'm not also sure if we want to develop 3.x
No, we don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
michael-o commented on PR #68:
URL:
https://github.com/apache/maven-reporting-impl/pull/68#issuecomment-2903432277
> similar here should we want to develop 3.x, such we have a release
version on master?
No
--
This is an automated message from the Apache Git Service.
To respon
Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2103909260
##
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##
@@ -50,8 +50,6 @@ public class DefaultUpdateCheckManager exte
Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2103910930
##
impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##
@@ -306,7 +306,7 @@ private void doExecute(MavenSession session, MojoExecutio
Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2103907689
##
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##
@@ -303,7 +301,7 @@ private Properties read(File touchfile) {
Pankraz76 commented on PR #2367:
URL: https://github.com/apache/maven/pull/2367#issuecomment-2903463035
> which includes questionable changes (e.g. the introduction of the
`assertHeader` method).
yes not applied SOC, sorry.
> Addressing all PMD warnings should not be a goal.
Bukama opened a new issue, #208:
URL: https://github.com/apache/maven-pmd-plugin/issues/208
### New feature, improvement proposal
The PMD plugin has a goal
[`aggregate-pmd-no-fork`](https://maven.apache.org/plugins/maven-pmd-plugin/aggregate-pmd-no-fork-mojo.html)
to generate a site
Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2103910930
##
impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##
@@ -306,7 +306,7 @@ private void doExecute(MavenSession session, MojoExecutio
84 matches
Mail list logo
