desruisseaux commented on PR #2367: URL: https://github.com/apache/maven/pull/2367#issuecomment-2901515985
This pull request provides small changes addressing exactly the discussion point, while #2365 is a larger set of changes which includes questionable changes (e.g. the introduction of the `assertHeader` method). Addressing all PMD warnings should not be a goal. Many of them are harmless, and sometime complying to the rule make the code less understandable. Some warnings are indeed real issues (e.g. the `while (vector.isEmpty())` loop in another PR), but the evaluation is on a case-by-case basis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
