Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2103907689
##########
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##########
@@ -303,7 +301,7 @@ private Properties read(File touchfile) {
Properties props = new Properties();
try (FileInputStream in = new FileInputStream(touchfile)) {
- try (FileLock lock = in.getChannel().lock(0,
Long.MAX_VALUE, true)) {
+ try (FileLock ignored = in.getChannel().lock(0,
Long.MAX_VALUE, true)) {
Review Comment:
really? check out the usage. Its **unused for sure**, or the last 15 years i
have done everything wrong, not even understood basics in pointer and reference.
https://www.geeksforgeeks.org/reference-variable-in-java/
##########
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##########
@@ -303,7 +301,7 @@ private Properties read(File touchfile) {
Properties props = new Properties();
try (FileInputStream in = new FileInputStream(touchfile)) {
- try (FileLock lock = in.getChannel().lock(0,
Long.MAX_VALUE, true)) {
Review Comment:
the block is super small its **defacto** unused or im not Vincent Potucek.
<img width="1137" alt="image"
src="https://github.com/user-attachments/assets/130bce87-a928-4ede-bf4e-bef2e88a50c7";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
