[
https://issues.apache.org/jira/browse/MWRAPPER-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953385#comment-17953385
]
ASF GitHub Bot commented on MWRAPPER-158:
-----------------------------------------
lbruun opened a new pull request, #166:
URL: https://github.com/apache/maven-wrapper/pull/166
The "This code is licensed to ASF" license header on the generated
`./mvn/wrapper/maven-wrapper.properties` file does not make sense. The file is
the user's, not ASF's. It is generated as a convenience for the user.
The file is logically part of the user's own code. We don't know what
license that has so adding a license header is bound to be wrong. Therefore
removed completely.
I'm guessing the code comes from a time when the Plugin was only (meant to
be) used internally in the Apache Maven
project. Then it would make sense.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x ] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Remove ASF header on generated maven-wrapper.properties
> -------------------------------------------------------
>
> Key: MWRAPPER-158
> URL: https://issues.apache.org/jira/browse/MWRAPPER-158
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
> Reporter: Lars Bruun-Hansen
> Priority: Trivial
>
> The Maven Wrapper Plugin will add an ASF license header on the generated
> {{maven-wrapper.properties}} file. I believe this is incorrect. It should
> have no license header.
> Reasoning: While the wrapper itself is licensed under ASF code, when used in
> a project (which may use any license!) the config for the wrapper's execution
> is surely not ASF (or even AL2). The file is generated by the plugin as a
> convenience. Similar to how some archetypes generate skeleton code.
> (comparison: Maven's own archetypes do _not_ add such a header)
> By contrast it makes sense to retain the license header on the script files.
> These for sure are ASF and the user is not meant to alter them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
