[GitHub] [maven] cstamas merged pull request #1038: [3.9.x] [MNG-7720] Wrong build order of forked projects

2023-03-08 Thread via GitHub
cstamas merged PR #1038: URL: https://github.com/apache/maven/pull/1038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[jira] [Commented] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697768#comment-17697768 ] ASF GitHub Bot commented on MNG-7720: - cstamas merged PR #1038: URL: https://github.com

[GitHub] [maven] cstamas merged pull request #1039: [3.8.x] [MNG-7720] Wrong build order of forked projects

2023-03-08 Thread via GitHub
cstamas merged PR #1039: URL: https://github.com/apache/maven/pull/1039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] cstamas merged pull request #1040: [MNG-7720] Wrong build order of forked projects

2023-03-08 Thread via GitHub
cstamas merged PR #1040: URL: https://github.com/apache/maven/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[jira] [Commented] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697770#comment-17697770 ] ASF GitHub Bot commented on MNG-7720: - cstamas merged PR #1040: URL: https://github.com

[jira] [Commented] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697769#comment-17697769 ] ASF GitHub Bot commented on MNG-7720: - cstamas merged PR #1039: URL: https://github.com

[jira] [Closed] (MNG-7720) [REGRESSION] Build order is incorrect and does not respect Reactor Build Order

2023-03-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7720. Resolution: Fixed > [REGRESSION] Build order is incorrect and does not respect Reactor Build Order >

[GitHub] [maven] gnodet opened a new pull request, #1045: Remove references to Xpp3DomBuilder and use XmlNodeBuilder instead

2023-03-08 Thread via GitHub
gnodet opened a new pull request, #1045: URL: https://github.com/apache/maven/pull/1045 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

2023-03-08 Thread via GitHub
gnodet commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459705561 > I'm not sure I understand the purpose of this. This also is singificant enough to deserve a JIRA issue. The purpose is to: * remove references to plexus-utils * fix encoding

[GitHub] [maven] gnodet commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

2023-03-08 Thread via GitHub
gnodet commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459707799 > Does this make sense to fiddle with compat although we want to get rid of it? Well, we want to get rid of it, but I think that won't be tomorrow. So in the mean time -- This

[jira] [Created] (MPOM-396) upgrade Maven Assembly Plugin to 3.5.0

2023-03-08 Thread Herve Boutemy (Jira)
Herve Boutemy created MPOM-396: -- Summary: upgrade Maven Assembly Plugin to 3.5.0 Key: MPOM-396 URL: https://issues.apache.org/jira/browse/MPOM-396 Project: Maven POMs Issue Type: Task

[GitHub] [maven] michael-o commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

2023-03-08 Thread via GitHub
michael-o commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459747839 > > Does this make sense to fiddle with compat although we want to get rid of it? > > Well, we want to get rid of it, but I think that won't be tomorrow. So in the mean time

[GitHub] [maven] gnodet commented on pull request #1005: Replace some old, pre-Java 7 Plexus code

2023-03-08 Thread via GitHub
gnodet commented on PR #1005: URL: https://github.com/apache/maven/pull/1005#issuecomment-1459770337 > I'm not sold on either #1043 or #1044. Just maybe we can kill the class completely but leaving it in place while making it return null seems the worst of both worlds. The autoclose

[GitHub] [maven] gnodet commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

2023-03-08 Thread via GitHub
gnodet commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1459791564 @elharo would you prefer removing the `DefaultMavenProfilesBuilder` implementation class completely ? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] adjust log level for the message when no known binding is found in Slf4jConfigurationFactory

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129153394 ## maven-embedder/src/test/java/org/apache/maven/cli/logging/Slf4jConfigurationFactoryTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[jira] [Commented] (MNG-7724) Slf4jConfigurationFactory should use info level when there is no exception and the logger type is unknown

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697793#comment-17697793 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] adjust log level for the message when no known binding is found in Slf4jConfigurationFactory

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129155652 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(

[jira] [Commented] (MNG-7724) Slf4jConfigurationFactory should use info level when there is no exception and the logger type is unknown

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697795#comment-17697795 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[jira] [Commented] (MNG-7724) Slf4jConfigurationFactory should use info level when there is no exception and the logger type is unknown

2023-03-08 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697798#comment-17697798 ] Romain Manni-Bucau commented on MNG-7724: - No guys, this means maven does not allow

[jira] [Reopened] (MNG-7724) Slf4jConfigurationFactory should use info level when there is no exception and the logger type is unknown

2023-03-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reopened MNG-7724: -- > Slf4jConfigurationFactory should use info level when there is no exception > and the logger type i

[jira] [Comment Edited] (MNG-7724) Slf4jConfigurationFactory should use info level when there is no exception and the logger type is unknown

2023-03-08 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697798#comment-17697798 ] Romain Manni-Bucau edited comment on MNG-7724 at 3/8/23 9:33 AM:

[GitHub] [maven] gnodet commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

2023-03-08 Thread via GitHub
gnodet commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1129178097 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven-surefire] olamy commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

2023-03-08 Thread via GitHub
olamy commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129203092 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java: ## @@ -59,7 +62,10 @@ * @author Stephen Connolly * @auth

[jira] [Updated] (MNG-7710) Upgrade plexus-utils to 3.5.1

2023-03-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7710: - Fix Version/s: 4.0.0 4.0.0-alpha-5 > Upgrade plexus-utils to 3.5.1 > ---

[GitHub] [maven-surefire] slachiewicz commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

2023-03-08 Thread via GitHub
slachiewicz commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129237191 ## maven-surefire-common/pom.xml: ## @@ -52,6 +52,12 @@ maven-core provided + + org.eclipse.aether + aether-util + Rev

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

2023-03-08 Thread via GitHub
slawekjaranowski commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299228 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java: ## @@ -59,7 +62,10 @@ * @author Stephen Connoll

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

2023-03-08 Thread via GitHub
slawekjaranowski commented on code in PR #617: URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1129299455 ## maven-surefire-common/pom.xml: ## @@ -52,6 +52,12 @@ maven-core provided + + org.eclipse.aether + aether-util +

[jira] [Commented] (MPOM-394) Upgrade Maven Project Info Reports Plugin to 3.4.2

2023-03-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPOM-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697866#comment-17697866 ] Michael Osipov commented on MPOM-394: - There is already MPOM-389, what did I miss? > U

[jira] [Updated] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau updated MNG-7724: Summary: Don't log warnings when runtime is not broken (slf4j integrations) (was: Slf4jConfi

[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #45: [MPIR-429] disable plugin processing when building projects

2023-03-08 Thread via GitHub
michael-o commented on PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#issuecomment-1460103694 Nice one. Does it make sense to revert MPIR-374? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (MPIR-429) avoid warning on "Unknown packaging: bundle"

2023-03-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPIR-429: --- Assignee: Herve Boutemy > avoid warning on "Unknown packaging: bundle" > -

[jira] [Commented] (MNG-7705) Sporadic failures on multiple builds sharing the same local repo when writing the .lastUpdated file

2023-03-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697877#comment-17697877 ] Michael Osipov commented on MNG-7705: - FTR: https://access.redhat.com/documentation/en

[GitHub] [maven] elharo commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

2023-03-08 Thread via GitHub
elharo commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1129389367 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129397818 ## maven-embedder/src/test/java/org/apache/maven/cli/logging/Slf4jConfigurationFactoryTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697885#comment-17697885 ] ASF GitHub Bot commented on MNG-7724: - elharo commented on code in PR #1041: URL: https

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r112947 ## maven-embedder/src/test/java/org/apache/maven/cli/logging/Slf4jConfigurationFactoryTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129400840 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(ILogg

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697886#comment-17697886 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697887#comment-17697887 ] ASF GitHub Bot commented on MNG-7724: - elharo commented on code in PR #1041: URL: https

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697888#comment-17697888 ] Elliotte Rusty Harold commented on MNG-7724: One more time: if a project choose

[GitHub] [maven] elharo commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

2023-03-08 Thread via GitHub
elharo commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1460135546 When did we deprecate it? If we can simply remove it in 4.0.0, that solves all problems. I will raise a question on the dev mailing list about whether we should start ripping out the depreca

[jira] [Commented] (MRESOLVER-338) Drop FileTransform API

2023-03-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697894#comment-17697894 ] Elliotte Rusty Harold commented on MRESOLVER-338: - This should not be

[GitHub] [maven] rmannibucau commented on pull request #1044: Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles

2023-03-08 Thread via GitHub
rmannibucau commented on PR #1044: URL: https://github.com/apache/maven/pull/1044#issuecomment-1460149135 @elharo it already returns null in 99% of the cases so guess this is not a behavior change -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129421297 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java: ## @@ -65,8 +67,14 @@ public static Slf4jConfiguration getConfiguration(

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697898#comment-17697898 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129424545 ## maven-embedder/pom.xml: ## @@ -140,6 +140,12 @@ under the License. slf4j-simple true + + org.slf4j + slf4j-jdk14 Review Comment: D

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697904#comment-17697904 ] ASF GitHub Bot commented on MNG-7724: - elharo commented on code in PR #1041: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1043: Fix callee closing streams and readers instead of callers

2023-03-08 Thread via GitHub
gnodet commented on code in PR #1043: URL: https://github.com/apache/maven/pull/1043#discussion_r1129437408 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -84,14 +81,9 @@ public static XmlNodeImpl build(Reader reader, boolean trim) thro

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on pull request #45: [MPIR-429] disable plugin processing when building projects

2023-03-08 Thread via GitHub
hboutemy commented on PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#issuecomment-1460164276 I think that MPIR-374 still makes sense: no need to add eventual noise -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129441351 ## maven-embedder/pom.xml: ## @@ -140,6 +140,12 @@ under the License. slf4j-simple true + + org.slf4j + slf4j-jdk14 Review Comment:

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697909#comment-17697909 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129443535 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/JDKConfiguration.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697910#comment-17697910 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[GitHub] [maven-site] michael-o opened a new pull request, #395: Add release notes for Maven 3.8.8

2023-03-08 Thread via GitHub
michael-o opened a new pull request, #395: URL: https://github.com/apache/maven-site/pull/395 This closes #395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [maven] rmannibucau commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129447663 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/NoopConfiguration.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven] elharo commented on a diff in pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
elharo commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129448236 ## maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/JDKConfiguration.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697915#comment-17697915 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on code in PR #1041: URL:

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697916#comment-17697916 ] ASF GitHub Bot commented on MNG-7724: - elharo commented on code in PR #1041: URL: https

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #45: [MPIR-429] disable plugin processing when building projects

2023-03-08 Thread via GitHub
michael-o commented on code in PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#discussion_r1129449003 ## src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java: ## @@ -206,6 +206,7 @@ private void renderSectionPluginManage

[GitHub] [maven-site] michael-o commented on pull request #395: Add release notes for Maven 3.8.8

2023-03-08 Thread via GitHub
michael-o commented on PR #395: URL: https://github.com/apache/maven-site/pull/395#issuecomment-1460200268 What I don't like is that 3.8.x is not visible anymore. I guess we should add a section for 3.8.x as well, at least until 3.9.x is stable. -- This is an automated message from the Ap

[GitHub] [maven-site] michael-o opened a new pull request, #396: Remove currentStableReleaseDate value

2023-03-08 Thread via GitHub
michael-o opened a new pull request, #396: URL: https://github.com/apache/maven-site/pull/396 This value was used in the days when the Maven distro included a buld date. This closes #396 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697929#comment-17697929 ] Romain Manni-Bucau commented on MNG-7724: - > One more time: if a project chooses to

[GitHub] [maven-build-cache-extension] atsteffen commented on a diff in pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

2023-03-08 Thread via GitHub
atsteffen commented on code in PR #43: URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1129557444 ## src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java: ## @@ -173,11 +173,14 @@ public CacheResult findCachedBuild( LOGG

[jira] [Commented] (MBUILDCACHE-46) Add maven.build.cache.remote.enabled parameter

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697937#comment-17697937 ] ASF GitHub Bot commented on MBUILDCACHE-46: --- atsteffen commented on code in

[GitHub] [maven-build-cache-extension] atsteffen commented on a diff in pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

2023-03-08 Thread via GitHub
atsteffen commented on code in PR #43: URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1129560328 ## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ## @@ -452,28 +453,29 @@ public boolean isEnabled() { @Override publ

[jira] [Commented] (MBUILDCACHE-46) Add maven.build.cache.remote.enabled parameter

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697938#comment-17697938 ] ASF GitHub Bot commented on MBUILDCACHE-46: --- atsteffen commented on code in

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697939#comment-17697939 ] Elliotte Rusty Harold commented on MNG-7724: I've heard the claim that "You mus

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697946#comment-17697946 ] Elliotte Rusty Harold commented on MNG-7724: The code in question is a bit of a

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697950#comment-17697950 ] Elliotte Rusty Harold commented on MNG-7724: Also we shouldn't call ex.printSta

[GitHub] [maven] rmannibucau commented on pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on PR #1041: URL: https://github.com/apache/maven/pull/1041#issuecomment-1460329789 @elharo jul is jdk14 one (the PR adds its support, was not there not sure why), noop is kind of built-in but defeats the fact to log a warning on a random logger (but this is another ti

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697954#comment-17697954 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on PR #1041: URL: https://

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on a diff in pull request #45: [MPIR-429] disable plugin processing when building projects

2023-03-08 Thread via GitHub
hboutemy commented on code in PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#discussion_r1129631263 ## src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java: ## @@ -206,6 +206,7 @@ private void renderSectionPluginManagem

[jira] [Commented] (MASFRES-20) switch to Git

2023-03-08 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MASFRES-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697969#comment-17697969 ] Herve Boutemy commented on MASFRES-20: -- {noformat} git svn clone -s https://svn.apac

[jira] [Comment Edited] (MASFRES-20) switch to Git

2023-03-08 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MASFRES-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697969#comment-17697969 ] Herve Boutemy edited comment on MASFRES-20 at 3/8/23 3:39 PM: -

[jira] [Commented] (MPOM-200) remove Apache Resource Bundles parent POM

2023-03-08 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697970#comment-17697970 ] Herve Boutemy commented on MPOM-200: [~slachiewicz] [~elharo] please review the draft g

[GitHub] [maven-project-info-reports-plugin] hboutemy commented on a diff in pull request #45: [MPIR-429] disable plugin processing when building projects

2023-03-08 Thread via GitHub
hboutemy commented on code in PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45#discussion_r1129650811 ## src/main/java/org/apache/maven/report/projectinfo/PluginsReport.java: ## @@ -192,6 +192,7 @@ private void renderSectionPlugins( boolean isPlu

[GitHub] [maven-project-info-reports-plugin] hboutemy merged pull request #45: [MPIR-429] disable plugin processing when building projects

2023-03-08 Thread via GitHub
hboutemy merged PR #45: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Closed] (MPIR-429) avoid warning on "Unknown packaging: bundle"

2023-03-08 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPIR-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MPIR-429. -- Resolution: Fixed PR merged in https://github.com/apache/maven-project-info-reports-plugin/commit/5757c0

[jira] [Commented] (MPOM-200) remove Apache Resource Bundles parent POM

2023-03-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697981#comment-17697981 ] Elliotte Rusty Harold commented on MPOM-200: On first glance, I'm thoroughly co

[GitHub] [maven] elharo commented on pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
elharo commented on PR #1041: URL: https://github.com/apache/maven/pull/1041#issuecomment-1460414960 Why does Maven add that layer? Can it simply remove it instead? If I had a greenfield, I'd just use java.util.logging and not allow any other log libraries within ten dependency chains of co

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697984#comment-17697984 ] ASF GitHub Bot commented on MNG-7724: - elharo commented on PR #1041: URL: https://githu

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697985#comment-17697985 ] Romain Manni-Bucau commented on MNG-7724: - > Warnings are warnings and not errors f

[GitHub] [maven] rmannibucau commented on pull request #1041: [MNG-7724] Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread via GitHub
rmannibucau commented on PR #1041: URL: https://github.com/apache/maven/pull/1041#issuecomment-1460420631 Fully agree JUL is way saner for products like maven but this is a long debate. If we remove it we drop the `--fail-on-severity` flag so not sure we can in 4.x. -- This is an auto

[jira] [Commented] (MNG-7724) Don't log warnings when runtime is not broken (slf4j integrations)

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697986#comment-17697986 ] ASF GitHub Bot commented on MNG-7724: - rmannibucau commented on PR #1041: URL: https://

[GitHub] [maven] gnodet commented on pull request #1037: [MNG-7723] Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread via GitHub
gnodet commented on PR #1037: URL: https://github.com/apache/maven/pull/1037#issuecomment-1460471083 Please create a similar PR for `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (MNG-7723) Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698001#comment-17698001 ] ASF GitHub Bot commented on MNG-7723: - gnodet commented on PR #1037: URL: https://githu

[jira] [Updated] (MNG-7723) Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7723: - Fix Version/s: 4.0.0 4.0.0-alpha-5 > Upgrade to Maven Resolver 1.9.7 > -

[GitHub] [maven] cstamas opened a new pull request, #1046: [MNG-7723] Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread via GitHub
cstamas opened a new pull request, #1046: URL: https://github.com/apache/maven/pull/1046 That carries mostly transport-http bugfixes and improvements. --- https://issues.apache.org/jira/browse/MNG-7723 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven] cstamas commented on pull request #1037: [MNG-7723] Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread via GitHub
cstamas commented on PR #1037: URL: https://github.com/apache/maven/pull/1037#issuecomment-1460479206 Created https://github.com/apache/maven/pull/1046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (MNG-7723) Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698006#comment-17698006 ] ASF GitHub Bot commented on MNG-7723: - cstamas opened a new pull request, #1046: URL: h

[jira] [Commented] (MNG-7723) Upgrade to Maven Resolver 1.9.7

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698007#comment-17698007 ] ASF GitHub Bot commented on MNG-7723: - cstamas commented on PR #1037: URL: https://gith

[jira] [Commented] (MPOM-200) remove Apache Resource Bundles parent POM

2023-03-08 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698022#comment-17698022 ] Herve Boutemy commented on MPOM-200: what's happening here is MASFRES-20 = svn 2 git mi

[jira] [Created] (MNG-7725) Update surefire to 3.0.0-M10 in default binding

2023-03-08 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNG-7725: Summary: Update surefire to 3.0.0-M10 in default binding Key: MNG-7725 URL: https://issues.apache.org/jira/browse/MNG-7725 Project: Maven Issue Type:

[GitHub] [maven-surefire] cstamas commented on pull request #617: [SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

2023-03-08 Thread via GitHub
cstamas commented on PR #617: URL: https://github.com/apache/maven-surefire/pull/617#issuecomment-1460572120 Another example of insane overhead of all legacy stuff: 800 lines less! Great job @slawekjaranowski -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (MNG-7725) Update surefire to 3.0.0-M10 in default binding

2023-03-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7725: - Fix Version/s: 4.0.x-candidate > Update surefire to 3.0.0-M10 in default binding >

[GitHub] [maven-wrapper] slawekjaranowski opened a new pull request, #94: [MWRAPPER-85] Mention only-script type for binary less installations

2023-03-08 Thread via GitHub
slawekjaranowski opened a new pull request, #94: URL: https://github.com/apache/maven-wrapper/pull/94 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) file

[jira] [Commented] (MWRAPPER-85) Docs do not mention distributionType for MavenWrapperDownloader.jar

2023-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698058#comment-17698058 ] ASF GitHub Bot commented on MWRAPPER-85: slawekjaranowski opened a new pull requ

[jira] [Created] (MPH-194) Upgrade Parent to 39

2023-03-08 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPH-194: --- Summary: Upgrade Parent to 39 Key: MPH-194 URL: https://issues.apache.org/jira/browse/MPH-194 Project: Maven Help Plugin Issue Type: Dependency upgrade

[jira] [Created] (MRRESOURCES-126) Get rid of Maven 3.9.1 warning about deprecated parameter

2023-03-08 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRRESOURCES-126: --- Summary: Get rid of Maven 3.9.1 warning about deprecated parameter Key: MRRESOURCES-126 URL: https://issues.apache.org/jira/browse/MRRESOURCES-126 Projec

[jira] [Updated] (MRRESOURCES-116) Upgrade Apache Velocity due to vulnerability in commons-collections v3.2.1

2023-03-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRRESOURCES-116: Fix Version/s: 3.1.0 > Upgrade Apache Velocity due to vulnerability in commons

  1   2   >