[GitHub] [maven-invoker] slawekjaranowski commented on a diff in pull request #55: [MSHARED-1150] - Add ps1 as detectable file type for PowerShell

2022-10-10 Thread GitBox
slawekjaranowski commented on code in PR #55: URL: https://github.com/apache/maven-invoker/pull/55#discussion_r990969809 ## src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java: ## @@ -251,7 +251,7 @@ public void testShouldFindDummyMavenExecutable()

[jira] [Created] (MPOM-347) Allow custom Release Distribution Repository

2022-10-10 Thread Cheng Pan (Jira)
Cheng Pan created MPOM-347: -- Summary: Allow custom Release Distribution Repository Key: MPOM-347 URL: https://issues.apache.org/jira/browse/MPOM-347 Project: Maven POMs Issue Type: Improvement

[GitHub] [maven-apache-parent] pan3793 opened a new pull request, #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
pan3793 opened a new pull request, #111: URL: https://github.com/apache/maven-apache-parent/pull/111 Same as snapshots, this makes developers deploy a release version to a custom repo easily. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven-apache-parent] michael-o commented on pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
michael-o commented on PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111#issuecomment-1272887188 Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-apache-parent] pan3793 commented on pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
pan3793 commented on PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111#issuecomment-127278 why does the snapshot repo allow custom but the release does not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [maven-apache-parent] michael-o commented on pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
michael-o commented on PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111#issuecomment-1272894832 Good question... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r990982218 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java: ## @@ -426,6 +442,14 @@ else if ( local.getFile() != null )

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614938#comment-17614938 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r990983348 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java: ## @@ -117,14 +111,47 @@ protected Map perfor

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614940#comment-17614940 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-apache-parent] pan3793 commented on pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
pan3793 commented on PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111#issuecomment-1272897544 one use case: some users/developers may want to have a quick patched version to deploy to private repo based on a released version, e.g. someone wants a v1.2.3-1 w/ some intern

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r990984438 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/FileTrustedChecksumsSourceSupport.java: ## @@ -93,24 +94,48 @@ public Map getTrustedA

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614942#comment-17614942 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-mvnd] orpiske commented on issue #337: Add Apple M1 build.

2022-10-10 Thread GitBox
orpiske commented on issue #337: URL: https://github.com/apache/maven-mvnd/issues/337#issuecomment-1272905130 > @mprimeaux Also, a candidate release of `mvnd` 0.8.2 with M1 builds is available for review at https://dist.apache.org/repos/dist/dev/maven/mvnd/0.8.2/. It would be nice to have

[GitHub] [maven-resolver] cstamas commented on pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on PR #200: URL: https://github.com/apache/maven-resolver/pull/200#issuecomment-1272999195 @michael-o rebased/squashed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614980#comment-17614980 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on PR #200: URL

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-10-10 Thread Bertrand Martin (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614986#comment-17614986 ] Bertrand Martin commented on DOXIA-617: --- I understand your point, and I agree with y

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-10-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614991#comment-17614991 ] Michael Osipov commented on DOXIA-617: -- I plan to write an extensive CHANGES when Dox

[GitHub] [maven-mvnd] xtu2014551617 commented on issue #642: Support for musl library on linux-amd64 (Alpine)

2022-10-10 Thread GitBox
xtu2014551617 commented on issue #642: URL: https://github.com/apache/maven-mvnd/issues/642#issuecomment-1273052704 > > Dockerfile add > > _**RUN mkdir /lib64 && ln -s /lib/libc.musl-x86_64.so.1 /lib64/ld-linux-x86-64.so.2**_ > > Adding the link to the `musl` library s

[jira] [Assigned] (MNGSITE-496) Outline all means to load extensions and clarify differences

2022-10-10 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned MNGSITE-496: --- Assignee: Konrad Windszus > Outline all means to load extensions and clarify differ

[GitHub] [maven-site] kwin opened a new pull request, #326: [MNGSITE-496] Outline all means to load extensions and clarify

2022-10-10 Thread GitBox
kwin opened a new pull request, #326: URL: https://github.com/apache/maven-site/pull/326 differences -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNGSITE-496) Outline all means to load extensions and clarify differences

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615013#comment-17615013 ] ASF GitHub Bot commented on MNGSITE-496: kwin opened a new pull request, #326: U

[GitHub] [maven-apache-parent] pan3793 commented on pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
pan3793 commented on PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111#issuecomment-1273139422 Yes, @olamy we have done the same thing in Apache Kyuubi (Incubating) https://github.com/apache/incubator-kyuubi/blob/2cb34c4d007ac19b359767963225ee422d765618/pom.xml#L281-L292

[GitHub] [maven-apache-parent] pan3793 commented on pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-10 Thread GitBox
pan3793 commented on PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111#issuecomment-1273143490 I use "releases" for consistency as we already used "snapshots", are you inclined towards "release" or "releases"? -- This is an automated message from the Apache Git Service

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-10-10 Thread Andrzej Jarmoniuk (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615040#comment-17615040 ] Andrzej Jarmoniuk commented on MNG-7559: As pointed out by [~pzygielo], the behavio

[GitHub] [maven-site] cstamas commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-10-10 Thread GitBox
cstamas commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1273252524 Thanks for feedback, but am closing this PR as I have a feeling that this PR will not help, just mess things up, and these are the reasons: * PR can be created by "anybody" (whoever ha

[GitHub] [maven-site] cstamas closed pull request #321: [MNGSITE-491] Update commit policy related document

2022-10-10 Thread GitBox
cstamas closed pull request #321: [MNGSITE-491] Update commit policy related document URL: https://github.com/apache/maven-site/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615088#comment-17615088 ] ASF GitHub Bot commented on MNGSITE-491: cstamas commented on PR #321: URL: http

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615089#comment-17615089 ] ASF GitHub Bot commented on MNGSITE-491: cstamas closed pull request #321: [MNGS

[GitHub] [maven-site] michael-o commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-10-10 Thread GitBox
michael-o commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1273257422 @cstamas I don't think that master should necessarily CTR because there are already a LOT of changes in this branch and chaotic merging and reverts will make it worse. I still consider

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615094#comment-17615094 ] ASF GitHub Bot commented on MNGSITE-491: michael-o commented on PR #321: URL: ht

[GitHub] [maven-site] cstamas commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-10-10 Thread GitBox
cstamas commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1273271125 And a LOT are yet to land to master, so I don't see why "a LOT of changes present" implies "make it RTC". I don't see why we want to "hold back" the pace of progress (as RTC does exactly

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615099#comment-17615099 ] ASF GitHub Bot commented on MNGSITE-491: cstamas commented on PR #321: URL: http

[GitHub] [maven] MartinKanters commented on pull request #809: Consider inactive profiles for validation

2022-10-10 Thread GitBox
MartinKanters commented on PR #809: URL: https://github.com/apache/maven/pull/809#issuecomment-1273421800 I think it's a nice change, but I'm not sure if it's fully compatible with the changes we did in master (for Maven 4). Can you verify what the behaviour is for Maven 4? Perhaps we have

[GitHub] [maven] MartinKanters commented on a diff in pull request #809: Consider inactive profiles for validation

2022-10-10 Thread GitBox
MartinKanters commented on code in PR #809: URL: https://github.com/apache/maven/pull/809#discussion_r991365450 ## maven-core/src/main/java/org/apache/maven/DefaultMaven.java: ## @@ -466,7 +468,9 @@ private void validatePrerequisitesForNonMavenPluginProjects( List }

[GitHub] [maven] pzygielo commented on a diff in pull request #809: Consider inactive profiles for validation

2022-10-10 Thread GitBox
pzygielo commented on code in PR #809: URL: https://github.com/apache/maven/pull/809#discussion_r991376962 ## maven-core/src/main/java/org/apache/maven/DefaultMaven.java: ## @@ -466,7 +468,9 @@ private void validatePrerequisitesForNonMavenPluginProjects( List } }

[GitHub] [maven] pzygielo commented on pull request #809: Consider inactive profiles for validation

2022-10-10 Thread GitBox
pzygielo commented on PR #809: URL: https://github.com/apache/maven/pull/809#issuecomment-1273440622 > Can you verify what the behaviour is for Maven 4? Using maven 4 (2a9f39336cec1d8e52d30cc48503d51ed8672536) it works fine - build succeeds and does not complain about missing profile

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
gnodet commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991385100 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/ArtifactResolverPostProcessorSupport.java: ## @@ -0,0 +1,64 @@ +package org.eclipse.

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615152#comment-17615152 ] ASF GitHub Bot commented on MRESOLVER-276: -- gnodet commented on code in PR #2

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991396899 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/ArtifactResolverPostProcessorSupport.java: ## @@ -0,0 +1,64 @@ +package org.eclipse

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615155#comment-17615155 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
gnodet commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991402501 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/ArtifactResolverPostProcessorSupport.java: ## @@ -0,0 +1,64 @@ +package org.eclipse.

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615161#comment-17615161 ] ASF GitHub Bot commented on MRESOLVER-276: -- gnodet commented on code in PR #2

[GitHub] [maven-invoker] michael-o commented on a diff in pull request #55: [MSHARED-1150] - Add ps1 as detectable file type for PowerShell

2022-10-10 Thread GitBox
michael-o commented on code in PR #55: URL: https://github.com/apache/maven-invoker/pull/55#discussion_r991441221 ## src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java: ## @@ -663,6 +663,12 @@ private File detectMavenExecutablePerOs( File baseDirectory,

[GitHub] [maven-invoker] iofit commented on a diff in pull request #55: [MSHARED-1150] - Add ps1 as detectable file type for PowerShell

2022-10-10 Thread GitBox
iofit commented on code in PR #55: URL: https://github.com/apache/maven-invoker/pull/55#discussion_r991477666 ## src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java: ## @@ -663,6 +663,12 @@ private File detectMavenExecutablePerOs( File baseDirectory, Stri

[GitHub] [maven-mvnd] mprimeaux commented on issue #337: Add Apple M1 build.

2022-10-10 Thread GitBox
mprimeaux commented on issue #337: URL: https://github.com/apache/maven-mvnd/issues/337#issuecomment-1273578995 It seems the [brew formula for mvnd](https://github.com/mvndaemon/homebrew-mvnd) was updated to `0.8.2`. Oddly, however, I'm still receiving the same exception as [before

[GitHub] [maven-mvnd] gnodet commented on issue #337: Add Apple M1 build.

2022-10-10 Thread GitBox
gnodet commented on issue #337: URL: https://github.com/apache/maven-mvnd/issues/337#issuecomment-1273615375 When I released 0.8.2, i used the usual formula which had not been updated wrt to the new M1 binaries. I think you still have the `mvnd` being replaced by the `mvnd.sh` script which

[GitHub] [maven-mvnd] mprimeaux commented on issue #337: Add Apple M1 build.

2022-10-10 Thread GitBox
mprimeaux commented on issue #337: URL: https://github.com/apache/maven-mvnd/issues/337#issuecomment-1273616803 Yes. Let me try that now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-integration-testing] gnodet commented on pull request #184: Modernize IT plugins to use annotations

2022-10-10 Thread GitBox
gnodet commented on PR #184: URL: https://github.com/apache/maven-integration-testing/pull/184#issuecomment-1273641816 @slawekjaranowski would you mind having another look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-ear-plugin] slawekjaranowski opened a new pull request, #78: Refresh download page

2022-10-10 Thread GitBox
slawekjaranowski opened a new pull request, #78: URL: https://github.com/apache/maven-ear-plugin/pull/78 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MEAR) filed

[GitHub] [maven-ear-plugin] slawekjaranowski commented on pull request #78: Refresh download page

2022-10-10 Thread GitBox
slawekjaranowski commented on PR #78: URL: https://github.com/apache/maven-ear-plugin/pull/78#issuecomment-1273662473 Now looks as ![image](https://user-images.githubusercontent.com/3578921/194928771-80dee4ba-474b-4da5-a6ca-39195f85d212.png) -- This is an automated message from

[GitHub] [maven] gnodet merged pull request #818: v4 api enhancements

2022-10-10 Thread GitBox
gnodet merged PR #818: URL: https://github.com/apache/maven/pull/818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[jira] [Commented] (MNG-7553) New clean API with immutable model

2022-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615276#comment-17615276 ] Hudson commented on MNG-7553: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
michael-o commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991598876 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java: ## @@ -159,9 +178,63 @@ private ConcurrentH

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615288#comment-17615288 ] ASF GitHub Bot commented on MRESOLVER-276: -- michael-o commented on code in PR

[jira] [Commented] (MNG-7553) New clean API with immutable model

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615334#comment-17615334 ] ASF GitHub Bot commented on MNG-7553: - michael-o commented on code in PR #819: URL: htt

[GitHub] [maven] michael-o commented on a diff in pull request #819: [MNG-7553] Restore compatibility on SettingsBuilder, ToolchainsBuilder and MojoDescriptorCreator

2022-10-10 Thread GitBox
michael-o commented on code in PR #819: URL: https://github.com/apache/maven/pull/819#discussion_r991605833 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/SettingsBuilder.java: ## @@ -0,0 +1,71 @@ +package org.apache.maven.api.services; + +/* + * Licensed to t

[GitHub] [maven-integration-testing] michael-o commented on pull request #184: Modernize IT plugins to use annotations

2022-10-10 Thread GitBox
michael-o commented on PR #184: URL: https://github.com/apache/maven-integration-testing/pull/184#issuecomment-1273773077 Looking through... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] gnodet merged pull request #811: [MNG-6801] MavenXpp3Writer doesn't retain order of properties

2022-10-10 Thread GitBox
gnodet merged PR #811: URL: https://github.com/apache/maven/pull/811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[jira] [Commented] (MNG-6801) MavenXpp3Writer doesn't retain order of properties

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615337#comment-17615337 ] ASF GitHub Bot commented on MNG-6801: - gnodet merged PR #811: URL: https://github.com/a

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991616229 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java: ## @@ -410,6 +425,11 @@ else if ( local.getFile() != null )

[jira] [Closed] (MNG-6801) MavenXpp3Writer doesn't retain order of properties

2022-10-10 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-6801. Resolution: Fixed > MavenXpp3Writer doesn't retain order of properties >

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615338#comment-17615338 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991617082 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java: ## @@ -159,9 +178,63 @@ private ConcurrentHas

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991617468 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumArtifactResolverPostProcessor.java: ## @@ -0,0 +1,231 @@ +package or

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615339#comment-17615339 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615340#comment-17615340 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-site] slawekjaranowski merged pull request #327: Use the latest Maven version in example

2022-10-10 Thread GitBox
slawekjaranowski merged PR #327: URL: https://github.com/apache/maven-site/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #184: Modernize IT plugins to use annotations

2022-10-10 Thread GitBox
michael-o commented on code in PR #184: URL: https://github.com/apache/maven-integration-testing/pull/184#discussion_r991616440 ## core-it-suite/src/test/resources/mng-3703/project/pom.xml: ## @@ -19,7 +19,7 @@ maven-site-plugin - 3.3 +

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
michael-o commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991632848 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java: ## @@ -159,9 +178,63 @@ private ConcurrentH

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615345#comment-17615345 ] ASF GitHub Bot commented on MRESOLVER-276: -- michael-o commented on code in PR

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

2022-10-10 Thread GitBox
cstamas commented on code in PR #200: URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991641318 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java: ## @@ -159,9 +178,63 @@ private ConcurrentHas

[jira] [Commented] (MRESOLVER-276) Resolver post-processor

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615348#comment-17615348 ] ASF GitHub Bot commented on MRESOLVER-276: -- cstamas commented on code in PR #

[GitHub] [maven-invoker] slawekjaranowski merged pull request #55: [MSHARED-1150] Add ps1 as detectable file type for PowerShell

2022-10-10 Thread GitBox
slawekjaranowski merged PR #55: URL: https://github.com/apache/maven-invoker/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (MSHARED-1150) Support for PowerShell Maven executable

2022-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615349#comment-17615349 ] Hudson commented on MSHARED-1150: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[jira] [Closed] (MSHARED-1150) Support for PowerShell Maven executable

2022-10-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1150. Fix Version/s: maven-invoker-3.2.1 Assignee: Slawomir Jaranowski R

[jira] [Created] (MSHARED-1151) Upgrade Parent to 37

2022-10-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1151: Summary: Upgrade Parent to 37 Key: MSHARED-1151 URL: https://issues.apache.org/jira/browse/MSHARED-1151 Project: Maven Shared Components Issu

[jira] [Updated] (MSHARED-1151) Upgrade Parent to 37

2022-10-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1151: - Labels: up-for-grabs (was: ) > Upgrade Parent to 37 > > >

[jira] [Updated] (MSHARED-1152) Switch project unit tests to JUnit 5

2022-10-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1152: - Labels: up-for-grabs (was: ) > Switch project unit tests to JUnit 5 >

[jira] [Created] (MSHARED-1152) Switch project unit tests to JUnit 5

2022-10-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1152: Summary: Switch project unit tests to JUnit 5 Key: MSHARED-1152 URL: https://issues.apache.org/jira/browse/MSHARED-1152 Project: Maven Shared Component

[jira] [Commented] (MNG-6801) MavenXpp3Writer doesn't retain order of properties

2022-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615354#comment-17615354 ] Hudson commented on MNG-6801: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven-invoker] slawekjaranowski closed pull request #51: Bump maven-shared-components from 35 to 37

2022-10-10 Thread GitBox
slawekjaranowski closed pull request #51: Bump maven-shared-components from 35 to 37 URL: https://github.com/apache/maven-invoker/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-invoker] dependabot[bot] commented on pull request #51: Bump maven-shared-components from 35 to 37

2022-10-10 Thread GitBox
dependabot[bot] commented on PR #51: URL: https://github.com/apache/maven-invoker/pull/51#issuecomment-1273833145 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, l

[GitHub] [maven-invoker] slawekjaranowski closed pull request #53: Bump maven-pmd-plugin from 3.18.0 to 3.19.0

2022-10-10 Thread GitBox
slawekjaranowski closed pull request #53: Bump maven-pmd-plugin from 3.18.0 to 3.19.0 URL: https://github.com/apache/maven-invoker/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-invoker] dependabot[bot] commented on pull request #53: Bump maven-pmd-plugin from 3.18.0 to 3.19.0

2022-10-10 Thread GitBox
dependabot[bot] commented on PR #53: URL: https://github.com/apache/maven-invoker/pull/53#issuecomment-1273833242 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, l

[jira] [Updated] (MNG-6801) MavenXpp3Writer doesn't retain order of properties

2022-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6801: -- Fix Version/s: 3.8.x-candidate > MavenXpp3Writer doesn't retain order of properties > ---

[GitHub] [maven] elharo commented on a diff in pull request #819: [MNG-7553] Restore compatibility on SettingsBuilder, ToolchainsBuilder and MojoDescriptorCreator

2022-10-10 Thread GitBox
elharo commented on code in PR #819: URL: https://github.com/apache/maven/pull/819#discussion_r991663543 ## api/maven-api-core/src/main/java/org/apache/maven/api/Session.java: ## @@ -56,9 +56,21 @@ @Nonnull SessionData getData(); +/** + * Gets the user proper

[jira] [Commented] (MNG-7553) New clean API with immutable model

2022-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615367#comment-17615367 ] ASF GitHub Bot commented on MNG-7553: - elharo commented on code in PR #819: URL: https:

[jira] [Commented] (MWAR-456) Latest maven-war-plugin causing vulnerable .jars to be downloaded

2022-10-10 Thread Brent Shikoski (Jira)
[ https://issues.apache.org/jira/browse/MWAR-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615374#comment-17615374 ] Brent Shikoski commented on MWAR-456: - I believe it is fixed on master, the version of

[jira] [Commented] (SUREFIRE-2115) Unable to execute specific inner class test in Surefire

2022-10-10 Thread Andreas Pabst (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615375#comment-17615375 ] Andreas Pabst commented on SUREFIRE-2115: - This is not a bug. If you are runn

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #251: Bump logback.version from 1.2.11 to 1.4.4

2022-10-10 Thread GitBox
dependabot[bot] opened a new pull request, #251: URL: https://github.com/apache/maven-indexer/pull/251 Bumps `logback.version` from 1.2.11 to 1.4.4. Updates `logback-classic` from 1.2.11 to 1.4.4 Commits https://github.com/qos-ch/logback/commit/d2a9ddba63e3b9590fdb9f71c77c9b4

[GitHub] [maven-indexer] dependabot[bot] commented on pull request #250: Bump logback.version from 1.2.11 to 1.4.3

2022-10-10 Thread GitBox
dependabot[bot] commented on PR #250: URL: https://github.com/apache/maven-indexer/pull/250#issuecomment-1274056014 Superseded by #251. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-indexer] dependabot[bot] closed pull request #250: Bump logback.version from 1.2.11 to 1.4.3

2022-10-10 Thread GitBox
dependabot[bot] closed pull request #250: Bump logback.version from 1.2.11 to 1.4.3 URL: https://github.com/apache/maven-indexer/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SUREFIRE-2103) and causing Java heap space issue.

2022-10-10 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615454#comment-17615454 ] Christoph Läubrich commented on SUREFIRE-2103: -- Similar to https://issues

[jira] [Commented] (SUREFIRE-2112) Surefire not using toolchain JDK during test execution

2022-10-10 Thread Laurie C (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615456#comment-17615456 ] Laurie C commented on SUREFIRE-2112: For the plugin to honour the toolchain, it mu

[jira] [Commented] (SUREFIRE-2072) Surefire retains too much heap in some case, leading to OutOfMemory

2022-10-10 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615458#comment-17615458 ] Christoph Läubrich commented on SUREFIRE-2072: -- Can someone please explai

[jira] [Commented] (SUREFIRE-2094) Leaked file descriptors

2022-10-10 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615460#comment-17615460 ] Christoph Läubrich commented on SUREFIRE-2094: -- Is this maybe fixed with

[jira] [Commented] (SUREFIRE-2094) Leaked file descriptors

2022-10-10 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615462#comment-17615462 ] Christoph Läubrich commented on SUREFIRE-2094: -- See,s fixed by https://is

[jira] [Commented] (SUREFIRE-2072) Surefire retains too much heap in some case, leading to OutOfMemory

2022-10-10 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615461#comment-17615461 ] Christoph Läubrich commented on SUREFIRE-2072: -- [~tibordigana] could it b

[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #184: Modernize IT plugins to use annotations

2022-10-10 Thread GitBox
gnodet commented on code in PR #184: URL: https://github.com/apache/maven-integration-testing/pull/184#discussion_r991848926 ## core-it-support/core-it-plugins/maven-it-plugin-parameter-implementation/pom.xml: ## @@ -42,7 +42,35 @@ under the License. org.apache.mav

  1   2   >