[
https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614940#comment-17614940
]
ASF GitHub Bot commented on MRESOLVER-276:
------------------------------------------
cstamas commented on code in PR #200:
URL: https://github.com/apache/maven-resolver/pull/200#discussion_r990983348
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java:
##########
@@ -117,14 +111,47 @@ protected Map<String, String> performLookup(
RepositorySystemSession session,
return checksums;
}
- private ConcurrentHashMap<String, String> loadProvidedChecksums( Path
checksumsFile )
+ @Override
+ protected Writer getWriter( RepositorySystemSession session, Path basedir )
+ {
+ final boolean originAware = isOriginAware( session );
+ return ( artifact, artifactRepository, checksumAlgorithmFactories,
trustedArtifactChecksums ) ->
+ {
+ try
+ {
+ for ( ChecksumAlgorithmFactory checksumAlgorithmFactory :
checksumAlgorithmFactories )
+ {
+ String checksum = requireNonNull(
+ trustedArtifactChecksums.get(
checksumAlgorithmFactory.getName() ) );
+ String summaryLine = ArtifactIdUtils.toId( artifact ) + "
" + checksum + "\n";
Review Comment:
If System.lineSeparator() would be used, we could not exhange properly the
recoorded files for example. This way, you could "record" and I could consume
it (even validate it based on checksum). Again, this is internal matter of
implementation, nothing OS specific here.
> Resolver post-processor
> -----------------------
>
> Key: MRESOLVER-276
> URL: https://issues.apache.org/jira/browse/MRESOLVER-276
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: resolver-next
>
>
> Introduce new feature, resolver post-processor that is able to post process
> resolution results just before artifact resolver returns them to caller. Post
> processor should be able to signal resolution failure (along with errors)
> just like existing resolution may fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
