cstamas commented on code in PR #200:
URL: https://github.com/apache/maven-resolver/pull/200#discussion_r990983348
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/checksum/SummaryFileTrustedChecksumsSource.java:
##########
@@ -117,14 +111,47 @@ protected Map<String, String> performLookup(
RepositorySystemSession session,
return checksums;
}
- private ConcurrentHashMap<String, String> loadProvidedChecksums( Path
checksumsFile )
+ @Override
+ protected Writer getWriter( RepositorySystemSession session, Path basedir )
+ {
+ final boolean originAware = isOriginAware( session );
+ return ( artifact, artifactRepository, checksumAlgorithmFactories,
trustedArtifactChecksums ) ->
+ {
+ try
+ {
+ for ( ChecksumAlgorithmFactory checksumAlgorithmFactory :
checksumAlgorithmFactories )
+ {
+ String checksum = requireNonNull(
+ trustedArtifactChecksums.get(
checksumAlgorithmFactory.getName() ) );
+ String summaryLine = ArtifactIdUtils.toId( artifact ) + "
" + checksum + "\n";
Review Comment:
If System.lineSeparator() would be used, we could not exhange properly the
recoorded files for example. This way, you could "record" and I could consume
it (even validate it based on checksum). Again, this is internal matter of
implementation, nothing OS specific here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
