[
https://issues.apache.org/jira/browse/MRESOLVER-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615338#comment-17615338
]
ASF GitHub Bot commented on MRESOLVER-276:
------------------------------------------
cstamas commented on code in PR #200:
URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991616229
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:
##########
@@ -410,6 +425,11 @@ else if ( local.getFile() != null )
performDownloads( session, group );
}
+ for ( ArtifactResolverPostProcessor artifactResolverPostProcessor :
artifactResolverPostProcessors.values() )
+ {
+ artifactResolverPostProcessor.postProcess( session, results );
Review Comment:
The outcome is not needed at all, as post processor communicate with
resolver via `results` (just like before), and as I wrote several rounds
before, decided to move PP invocation before final "processing" of resolver,
where failures (basically, unresolved artifacts) are detected. Hence, if PP
wants to fail resolution, all it should do (and was doing before) is to
"decorate" result with exception, and make artifact unresolved, and from this
moment on, there is really no need for any "outcome", as all the information is
passed via results.
> Resolver post-processor
> -----------------------
>
> Key: MRESOLVER-276
> URL: https://issues.apache.org/jira/browse/MRESOLVER-276
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: resolver-next
>
>
> Introduce new feature, resolver post-processor that is able to post process
> resolution results just before artifact resolver returns them to caller. Post
> processor should be able to signal resolution failure (along with errors)
> just like existing resolution may fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
