Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-02-09 Thread via GitHub
elharo merged PR #2071: URL: https://github.com/apache/maven/pull/2071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-02-09 Thread via GitHub
elharo commented on PR #2071: URL: https://github.com/apache/maven/pull/2071#issuecomment-2646327459 Flaky CI; [main] ERROR org.apache.maven.cling.invoker.mvn.resident.ResidentMavenInvoker - Failed to read artifact descriptor for org.apache.maven:maven-archiver:jar:3.6.2: Faile

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-02-09 Thread via GitHub
elharo commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1948095528 ## compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -222,6 +222,33 @@ void testLeadingZeroes() { checkVe

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-02-02 Thread via GitHub
gnodet commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1938927274 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
elharo commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1936291152 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
elharo commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935531948 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
elharo commented on PR #2071: URL: https://github.com/apache/maven/pull/2071#issuecomment-2624357433 Probably worth filing a related bug for the resolver issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
elharo commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935516594 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
gnodet commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935325435 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
gnodet commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935310390 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
gnodet commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935310390 ## compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -687,7 +700,8 @@ public final void parseVersion(String version) {

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
gnodet commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935292267 ## compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -222,6 +222,33 @@ void testLeadingZeroes() { checkVe

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
gnodet commented on code in PR #2071: URL: https://github.com/apache/maven/pull/2071#discussion_r1935291980 ## compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -222,6 +222,33 @@ void testLeadingZeroes() { checkVe

Re: [PR] [MNG-8241] Handle non-BMP characters when comparing versions [maven]

2025-01-30 Thread via GitHub
gnodet commented on PR #2071: URL: https://github.com/apache/maven/pull/2071#issuecomment-2623956334 It would make sense to also fix the behavior of the resolver related class: https://github.com/apache/maven-resolver/blob/fa639fe1e76abc774d5ffd298c3dfa501cf305fc/maven-resolver-util/s