elharo commented on code in PR #2071:
URL: https://github.com/apache/maven/pull/2071#discussion_r1935531948
##########
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -687,7 +700,8 @@ public final void parseVersion(String version) {
stack.push(list);
}
isCombination = false;
- } else if (Character.isDigit(c)) {
+ // TODO we might not want to use isDigit here; just check for
ASCII digits only
+ } else if (c >= '0' && c <= '9') {
Review Comment:
OK, looks like Character.isDigit is checking specifically for decimal
digits, not non-decimal digits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
