elharo commented on code in PR #2071:
URL: https://github.com/apache/maven/pull/2071#discussion_r1948095528
##########
compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##########
@@ -222,6 +222,33 @@ void testLeadingZeroes() {
checkVersionsOrder("0.2", "1.0.7");
}
+ @Test
+ void testDigitGreaterThanNonAscii() {
+ ComparableVersion c1 = new ComparableVersion("1");
+ ComparableVersion c2 = new ComparableVersion("é");
+ assertTrue(c1.compareTo(c2) > 0, "expected " + "1" + " > " +
"\uD835\uDFE4");
Review Comment:
fixed
##########
compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##########
@@ -222,6 +222,33 @@ void testLeadingZeroes() {
checkVersionsOrder("0.2", "1.0.7");
}
+ @Test
+ void testDigitGreaterThanNonAscii() {
+ ComparableVersion c1 = new ComparableVersion("1");
+ ComparableVersion c2 = new ComparableVersion("é");
+ assertTrue(c1.compareTo(c2) > 0, "expected " + "1" + " > " +
"\uD835\uDFE4");
+ assertTrue(c2.compareTo(c1) < 0, "expected " + "\uD835\uDFE4" + " < "
+ "1");
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
