elharo commented on code in PR #2071:
URL: https://github.com/apache/maven/pull/2071#discussion_r1936291152
##########
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -687,7 +700,8 @@ public final void parseVersion(String version) {
stack.push(list);
}
isCombination = false;
- } else if (Character.isDigit(c)) {
+ // TODO we might not want to use isDigit here; just check for
ASCII digits only
+ } else if (c >= '0' && c <= '9') {
Review Comment:
Ran into a problem with that approach. It treats different versions of
digits as the same. E.g. 7 is the same as Arabic-Indic digit 7 even though they
are different characters.
I can see an argument for normalizing all these digits to ASCII digits for
Maven purposes, but that would touch a lot of different places in the code and
ecosystem including things like file names and artifact URLs in Maven Central.
I'm going to think about this a little more, but for the moment it feels
safer to treat all the non-ASCII digits as distinct non-numeric characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
