desruisseaux commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2094235663
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##
@@ -79,7 +79,12 @@ public DefaultSourceRoot(final Session session, final Path
base
slachiewicz merged PR #38:
URL: https://github.com/apache/maven-ejb-plugin/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ma
slachiewicz merged PR #37:
URL: https://github.com/apache/maven-ejb-plugin/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ma
slachiewicz merged PR #34:
URL: https://github.com/apache/maven-ejb-plugin/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ma
Pankraz76 closed pull request #2344: [ERROR] High: Found reliance on default
encoding in `org.apache.maven.di.tool.DiIndexProcessor.updateFileIfChanged()`:
new java.io.InputStreamReader(InputStream)
[org.apache.maven.di.tool.DiIndexProcessor] At DiIndexProcessor.java:[line 129]
DM_DEFAULT_ENC
Pankraz76 opened a new pull request, #2344:
URL: https://github.com/apache/maven/pull/2344
fix errors found by spotbugs:
- [ERROR] High: Found reliance on default encoding in
org.apache.maven.di.tool.DiIndexProcessor.updateFileIfChanged(): new
java.io.InputStreamReader(InputStream)
Pankraz76 commented on PR #2344:
URL: https://github.com/apache/maven/pull/2344#issuecomment-2888562815
wip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952390#comment-17952390
]
ASF GitHub Bot commented on SCM-1028:
-
hboutemy commented on PR #237:
URL: https://gith
hboutemy commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888540089
@michael-o it seems @pzygielo 's explanation is right, and it was the case 4
years ago: see #120
PR's commit https://github.com/apache/maven-scm/pull/120/commits is
different form mas
slawekjaranowski opened a new pull request, #203:
URL: https://github.com/apache/maven-pmd-plugin/pull/203
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MPMD) file
slawekjaranowski commented on issue #780:
URL: https://github.com/apache/maven-site/issues/780#issuecomment-2888463952
generated site contains:
```html
See Also
Guide to Using
Toolchains
Toolchains
Descriptor
```
acocrding to site descriptor should be:
slawekjaranowski commented on issue #780:
URL: https://github.com/apache/maven-site/issues/780#issuecomment-2888456295
Site https://maven.apache.org/plugins/maven-toolchains-plugin/index.html
Is generated as plugin documentation from project:
https://github.com/apache/maven-toolchain
slawekjaranowski closed issue #781: link to "Toolchains Descriptor" broken
URL: https://github.com/apache/maven-site/issues/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
slawekjaranowski commented on issue #781:
URL: https://github.com/apache/maven-site/issues/781#issuecomment-2888456774
The same source of problem like in: #780 so I close this one as duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
slawekjaranowski merged PR #782:
URL: https://github.com/apache/maven-site/pull/782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@m
slachiewicz commented on PR #37:
URL: https://github.com/apache/maven-ejb-plugin/pull/37#issuecomment-2888445293
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
slachiewicz commented on PR #34:
URL: https://github.com/apache/maven-ejb-plugin/pull/34#issuecomment-2888445427
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
slachiewicz commented on PR #38:
URL: https://github.com/apache/maven-ejb-plugin/pull/38#issuecomment-2888445165
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
slachiewicz merged PR #41:
URL: https://github.com/apache/maven-ejb-plugin/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ma
slawekjaranowski commented on PR #2333:
URL: https://github.com/apache/maven/pull/2333#issuecomment-2888441618
As I see from my testing only unparsable settings.xml break a Maven build at
all
settings.xml with correct xml syntax, but with unkown tags are processed,
all recognized setting
slawekjaranowski opened a new pull request, #782:
URL: https://github.com/apache/maven-site/pull/782
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
- [
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952369#comment-17952369
]
ASF GitHub Bot commented on SCM-1028:
-
michael-o commented on PR #237:
URL: https://git
michael-o commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888392969
> > any idea from anybody on what magic was adding the "asfgit merged
commit" step? = what seems currently broken
>
> * I think it might be the matter of pushing commit KNOWN
cstamas commented on PR #2333:
URL: https://github.com/apache/maven/pull/2333#issuecomment-2888358388
> For older Maven warning will be printed.
I am aware of warning, but am unaware what exactly happens when that warning
is printed: is whole settings ignored, is only the server (with
Pankraz76 commented on PR #2322:
URL: https://github.com/apache/maven/pull/2322#issuecomment-2888309850
then checkstyle stack using PMD/spotbugs seems only option.
Might use rewrite to fix legacy, by using `old version`. This should be
**legal** as in past is **was open source**. With
Pankraz76 closed pull request #2322: [POC] `rewrite-maven-plugin`: Introduce
OpenRewrite by Moderne
URL: https://github.com/apache/maven/pull/2322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
slawekjaranowski merged PR #86:
URL: https://github.com/apache/maven-invoker/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
slawekjaranowski commented on PR #2333:
URL: https://github.com/apache/maven/pull/2333#issuecomment-2888303723
> I am still unconvinced that this change is backward compatible. Or the
idea is that whoever uses this feature must use Maven 4 or latest (upcoming)
Maven 3.9.10? What happens if
Pankraz76 commented on code in PR #202:
URL: https://github.com/apache/maven-pmd-plugin/pull/202#discussion_r2094093672
##
src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java:
##
@@ -293,6 +293,14 @@ public int compare(Violation o1, Violation o2) {
if (fil
Pankraz76 commented on code in PR #202:
URL: https://github.com/apache/maven-pmd-plugin/pull/202#discussion_r2094093672
##
src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java:
##
@@ -293,6 +293,14 @@ public int compare(Violation o1, Violation o2) {
if (fil
Pankraz76 commented on PR #202:
URL: https://github.com/apache/maven-pmd-plugin/pull/202#issuecomment-2888299600
is this any good @oowekyala?
A simple log to support manual c&p would fix quick fix. without breaking
anything as just logging. Then writing the keys into file could be ne
Pankraz76 commented on code in PR #202:
URL: https://github.com/apache/maven-pmd-plugin/pull/202#discussion_r2094093672
##
src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java:
##
@@ -293,6 +293,14 @@ public int compare(Violation o1, Violation o2) {
if (fil
Pankraz76 opened a new pull request, #202:
URL: https://github.com/apache/maven-pmd-plugin/pull/202
- https://github.com/pmd/pmd/issues/5735
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](htt
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952355#comment-17952355
]
ASF GitHub Bot commented on SCM-1028:
-
pzygielo commented on PR #237:
URL: https://gith
pzygielo commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888294863
> any idea from anybody on what magic was adding the "asfgit merged commit"
step? = what seems currently broken
- I think it might be the matter of pushing commit KNOWN to GitHub i
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952354#comment-17952354
]
ASF GitHub Bot commented on SCM-1028:
-
michael-o commented on PR #237:
URL: https://git
michael-o commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888287173
> searching for pointers, I see Jena project seems to have clearly
documented the PR merge process via GH or via GitBas =
https://cwiki.apache.org/confluence/pages/viewpage.action?pageI
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952353#comment-17952353
]
ASF GitHub Bot commented on SCM-1028:
-
hboutemy commented on PR #237:
URL: https://gith
hboutemy commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888282584
searching for pointers, I see Jena project seems to have clearly documented
the PR merge process via GH or via GitBas =
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=7
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952350#comment-17952350
]
ASF GitHub Bot commented on SCM-1028:
-
hboutemy commented on PR #237:
URL: https://gith
hboutemy commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888281404
any idea from anybody on what magic was adding the "asfgit merged commit"
step?
= what seems currently broken
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952345#comment-17952345
]
ASF GitHub Bot commented on SCM-1028:
-
hboutemy commented on PR #237:
URL: https://gith
hboutemy commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888273629
writing down the factual differences:
- in 2022 for #151, there were 2 messages with the expected successful GH PR
conclusion:
 Maven
3.9.10? What happens if by mistake
slawekjaranowski merged PR #282:
URL: https://github.com/apache/maven-invoker-plugin/pull/282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
slawekjaranowski opened a new pull request, #86:
URL: https://github.com/apache/maven-invoker/pull/86
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
-
slawekjaranowski merged PR #85:
URL: https://github.com/apache/maven-invoker/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
slawekjaranowski commented on PR #2333:
URL: https://github.com/apache/maven/pull/2333#issuecomment-2888205461
@gnodet @cstamas any more comments for it?
I will cleanups from comments and will be ready.
--
This is an automated message from the Apache Git Service.
To respond to the m
52 matches
Mail list logo
