michael-o commented on PR #237: URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2888392969
> > any idea from anybody on what magic was adding the "asfgit merged commit" step? = what seems currently broken > > * I think it might be the matter of pushing commit KNOWN to GitHub in context of PR (like in referenced [[SCM-991] GitDiffConsumer cannot parse moved files #151](https://github.com/apache/maven-scm/pull/151) - the same commit present in PR was pushed to the target branch) or UNKNOWN (like here - [8b44e4f](https://github.com/apache/maven-scm/commit/8b44e4f6745e7bd677428be093921267317b8fe8) was brand new commit (re-committed content) pushed to target branch with closing keyword - so the PR was closed as commanded, but not recognized as being merged; the commit comment just closed the PR for some, perhaps unreladed, reason, but it was not _merged_.) > > > > This is basically what I have been doing: "This closes #NNN". > > And such comment "closes" issues/PRs as requested. If merged "correctly" - there would be no reason to add such comment. > > With merge being fast-forwarded or squashed or done with merge commit, in GitHub or externally to GitHub - there are many possibilities to be considered. Technically not necessary, but for reference helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
