desruisseaux commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2094235663


##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##########
@@ -79,7 +79,12 @@ public DefaultSourceRoot(final Session session, final Path 
baseDir, final Source
         if (value != null) {
             directory = baseDir.resolve(value);
         } else {
-            directory = 
baseDir.resolve("src").resolve(scope.id()).resolve(language.id());
+            Path src = baseDir.resolve("src");
+            if (moduleName != null) {
+                directory = 
src.resolve(language.id()).resolve(moduleName).resolve(scope.id());
+            } else {
+                directory = src.resolve(scope.id()).resolve(language.id());
+            }

Review Comment:
   Changed the default to `src/${module}/${scope}/${lang}` which seems to be 
the preferred layout in the [thread on the developer mailing 
list](https://lists.apache.org/thread/dzvpyfr667z0bwmwn0tdjn6nlmnx1gcx) (choice 
1 in the initial email).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to