Pankraz76 commented on code in PR #202:
URL: https://github.com/apache/maven-pmd-plugin/pull/202#discussion_r2094093672


##########
src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java:
##########
@@ -293,6 +293,14 @@ public int compare(Violation o1, Violation o2) {
         if (fileSectionStarted) {
             endFileSection();
         }
+        logExcludeFromFailureFileSuppressions();
+    }
+
+    private void logExcludeFromFailureFileSuppressions() {
+        log.info("logExcludeFromFailureFileSuppressions");
+        log.info(violations.stream()
+                .map(violation -> String.format("%s:%s", 
violation.getViolationClass(), violation.getRule()))

Review Comment:
   ```suggestion
                   .map(violation -> String.format("%s=%s", 
violation.getViolationClass(), violation.getRule()))
   ```
   only works for one, having collision: 
   ```
   org.apache.maven.building.DefaultProblem=MissingOverride
   org.apache.maven.model.merge.MavenModelMerger=ForLoopVariableCount
   org.apache.maven.model.merge.MavenModelMerger=OneDeclarationPerLine
   ```
   merge:
   ```
   org.apache.maven.building.DefaultProblem=MissingOverride
   
org.apache.maven.model.merge.MavenModelMerger=ForLoopVariableCount,OneDeclarationPerLine
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to