olamy commented on PR #2309:
URL: https://github.com/apache/maven/pull/2309#issuecomment-2868158949
https://hamcrest.org/JavaHamcrest/ is really nice
This will turn into preferences discussion :)
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dependabot[bot] commented on PR #108:
URL:
https://github.com/apache/maven-resources-plugin/pull/108#issuecomment-2867968727
Superseded by #118.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dependabot[bot] closed pull request #108: Bump
org.apache.maven.resolver:maven-resolver-api from 1.6.3 to 1.9.22
URL: https://github.com/apache/maven-resources-plugin/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dependabot[bot] opened a new pull request, #118:
URL: https://github.com/apache/maven-resources-plugin/pull/118
Bumps
[org.apache.maven.resolver:maven-resolver-api](https://github.com/apache/maven-resolver)
from 1.6.3 to 1.9.23.
Release notes
Sourced from https://github.com/apache
desruisseaux commented on PR #2236:
URL: https://github.com/apache/maven/pull/2236#issuecomment-2867965021
Rebasing done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Pankraz76 opened a new pull request, #2314:
URL: https://github.com/apache/maven/pull/2314
Align module and dir structure of modules
- https://github.com/apache/maven/pull/2313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Pankraz76 commented on PR #2309:
URL: https://github.com/apache/maven/pull/2309#issuecomment-2867859886
no i have not done that as im not aware of ATM. I heave tried to pitch an
issue but its not possible like on any project i know. Please excuse my
pragmatism. Im just making offers and try
Pankraz76 commented on PR #2313:
URL: https://github.com/apache/maven/pull/2313#issuecomment-2867846021
one could argue to avoid DRY prefix `maven_` as we have therefore package id
to group `org.apache.maven` but this is a bigger change of course.
https://github.com/user-attachments/a
Pankraz76 commented on PR #2313:
URL: https://github.com/apache/maven/pull/2313#issuecomment-2867840853
lets embrace our new strength in `4.0` and evolve to greatness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Pankraz76 opened a new pull request, #2313:
URL: https://github.com/apache/maven/pull/2313
Align module and dir structure of module `maven-impl-modules`
lets fix last few gaps:
its almost in sync unless in other big projects. Lets give dedication and
pay tribute to maven making
Bukama commented on PR #2309:
URL: https://github.com/apache/maven/pull/2309#issuecomment-2867799299
> I would suggest to go with one single source of truth and not pay double
the cost of carry and raising questions.
Where was the question about migrating to AssertJ risen and discusse
Pankraz76 commented on PR #2309:
URL: https://github.com/apache/maven/pull/2309#issuecomment-2867796184
For me its only about asking and avoiding overhead. JUnit will work fine as
well as they have modern API as well im sure. Just going for syntax assetJ
might be better in story telling:
[
https://issues.apache.org/jira/browse/MNG-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger reassigned MNG-8723:
Assignee: Matthias Bünger
> Bump org.eclipse.jetty:jetty-server from 9.4.55.v20240627 to 9.4
[
https://issues.apache.org/jira/browse/MNG-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger closed MNG-8723.
Resolution: Fixed
https://github.com/apache/maven/pull/2305
> Bump org.eclipse.jetty:jetty-server fr
Bukama merged PR #2305:
URL: https://github.com/apache/maven/pull/2305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
Matthias Bünger created MNG-8723:
Summary: Bump org.eclipse.jetty:jetty-server from 9.4.55.v20240627
to 9.4.56.v20240826 in /its/core-it-suite
Key: MNG-8723
URL: https://issues.apache.org/jira/browse/MNG-8723
Bukama commented on PR #2309:
URL: https://github.com/apache/maven/pull/2309#issuecomment-2867789373
Have we decided to go away from JUnit assertions and add AssertJ?
That's not about if they are "better" or not, but I have in mind that Maven
only uses core JUnit ones?
--
This is a
Pankraz76 commented on PR #2302:
URL: https://github.com/apache/maven/pull/2302#issuecomment-2867783744
should add rule via checkstyle and then only make ci happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Bukama commented on code in PR #268:
URL: https://github.com/apache/maven-archetype/pull/268#discussion_r2082433554
##
archetype-models/archetype-descriptor/pom.xml:
##
@@ -39,7 +39,9 @@
org.codehaus.modello
modello-maven-plugin
- 1.1.0
+
Pankraz76 opened a new pull request, #2312:
URL: https://github.com/apache/maven/pull/2312
follow up of:
- https://github.com/apache/maven/pull/2303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Pankraz76 commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2867779730
> Your first commit what correct
sorry for high pace. Now bug and test with minimal fix ready to merge and
follow up to dig deeper.
- https://github.com/apache/maven/pull/231
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2082428093
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2082428093
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cstamas opened a new pull request, #2311:
URL: https://github.com/apache/maven/pull/2311
The upcoming Eclipse Sisu will not provide anymore "shaded" JARs (with out
without ASM).
Also, fixed the `maven-executor` test that failed on "unexpected stderr
output" that now happens with Java 24
desruisseaux commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082405722
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the PO
Pankraz76 commented on PR #2310:
URL: https://github.com/apache/maven/pull/2310#issuecomment-2867674031
[INFO] BUILD SUCCESS
https://github.com/user-attachments/assets/e43fdf94-591d-4fd7-9897-b960e9170f66";
/>
--
This is an automated message from the Apache Git Service.
To respond
Pankraz76 opened a new pull request, #2310:
URL: https://github.com/apache/maven/pull/2310
-
https://docs.openrewrite.org/recipes/staticanalysis/removeunusedprivatemethods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
gnodet commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082324824
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the POM file
elharo commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082254538
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the POM file
timtebeek commented on PR #2291:
URL: https://github.com/apache/maven/pull/2291#issuecomment-2867537086
Thanks all! Indeed we should not be making changes to an API that was
explicitly marked as protected with exceptions declared;
- https://github.com/openrewrite/rewrite-static-analysis/
elharo commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082254538
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the POM file
gnodet commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082243943
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the POM file
gnodet commented on PR #2236:
URL: https://github.com/apache/maven/pull/2236#issuecomment-2867486282
@desruisseaux can you rebase or merge master branch to fix the conflict ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] opened a new pull request, #601:
URL: https://github.com/apache/maven-deploy-plugin/pull/601
Bumps `resolverVersion` from 1.9.22 to 1.9.23.
Updates `org.apache.maven.resolver:maven-resolver-api` from 1.9.22 to 1.9.23
Release notes
Sourced from https://github.com/a
slawekjaranowski merged PR #113:
URL: https://github.com/apache/maven-archetype/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
Pankraz76 commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2867117890
bug
missing dependency check: `assertj-core`
```
org.assertj
assertj-core
test
```
```
--
[E
slawekjaranowski opened a new pull request, #776:
URL: https://github.com/apache/maven-site/pull/776
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
cstamas merged PR #2308:
URL: https://github.com/apache/maven/pull/2308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.
slawekjaranowski merged PR #40:
URL: https://github.com/apache/maven-archetypes/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
Pankraz76 commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2867066640
build success
https://github.com/user-attachments/assets/14cafcbd-586f-464c-8969-bfb102afde37";
/>
--
This is an automated message from the Apache Git Service.
To respond to
Pankraz76 commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2867056212
bug:
[ERROR] ReflectionValueExtractorTest.mappedIndexed:227
expected: "a-value"
but was: null
--
This is an automated message from the Apache Git Service.
To respond
Pankraz76 commented on PR #2291:
URL: https://github.com/apache/maven/pull/2291#issuecomment-2866958143
how to fix this permanent @timtebeek ?
Do we have the (local) `dry run causing build failure check` available?
I do not want to overload and spam PR´s like its done in rewrite
Pankraz76 opened a new pull request, #2307:
URL: https://github.com/apache/maven/pull/2307
why having 2 if one is enough?
https://docs.openrewrite.org/recipes/java/testing/assertj/junittoassertj
I always had ether or but never the need to pay cost of carry twice for same
concer
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r208185
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081842972
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081845012
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
dependabot[bot] closed pull request #34: Bump resolverVersion from 1.4.1 to
1.9.22
URL: https://github.com/apache/maven-doap-plugin/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] commented on PR #34:
URL: https://github.com/apache/maven-doap-plugin/pull/34#issuecomment-2866631762
Superseded by #40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] opened a new pull request, #40:
URL: https://github.com/apache/maven-doap-plugin/pull/40
Bumps `resolverVersion` from 1.4.1 to 1.9.23.
Updates `org.apache.maven.resolver:maven-resolver-connector-basic` from
1.4.1 to 1.9.23
Release notes
Sourced from https://githu
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081584446
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081581566
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
elharo commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081582064
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
request)
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081578208
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081581566
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081581566
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081578208
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081578208
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081570702
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -93,7 +89,7 @@ public void write(XmlWriterRequest request)
throws XmlWriterE
elharo commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081563275
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Pankraz76 commented on PR #2283:
URL: https://github.com/apache/maven/pull/2283#issuecomment-2866357677
awesome, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
elharo merged PR #2283:
URL: https://github.com/apache/maven/pull/2283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
Pankraz76 commented on PR #2306:
URL: https://github.com/apache/maven/pull/2306#issuecomment-2866339660
But it's redundant then, as the behavior is now the same, and the end result
is just without being overly complex and duplicating it—making the default
exception explicit.
When the
Pankraz76 commented on PR #2306:
URL: https://github.com/apache/maven/pull/2306#issuecomment-2866334924
So no, this is not a dead branch - it serves an important purpose in the
API's flexibility.
Conclusion:
✅ The else block is reachable and necessary.
It serves as a fallback wh
Pankraz76 commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2866327707
why is flaky build sometimes, not working on master too please?
https://github.com/user-attachments/assets/34ef1d0b-a1b1-4cf7-abb7-2023cd8d3261";
/>
https://github.com/user-
Pankraz76 commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2866272988
> Not sure what you mean, but you removed support for URLs for no good
reason. Your first commit what correct, now the PRs is not acceptable.
yes im sorry. lets SOC this merge and c
Pankraz76 commented on code in PR #2303:
URL: https://github.com/apache/maven/pull/2303#discussion_r2081506551
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
reque
Pankraz76 opened a new pull request, #2306:
URL: https://github.com/apache/maven/pull/2306
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for t
Pankraz76 commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2866228905
and its DRY anyway so it should resolve:
https://github.com/user-attachments/assets/d2cf1681-2411-47b1-b8c9-0f4535d89cca";
/>
--
This is an automated message from the Apache Git
dependabot[bot] opened a new pull request, #119:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/119
Bumps `resolverVersion` from 1.4.1 to 1.9.23.
Updates `org.apache.maven.resolver:maven-resolver-api` from 1.4.1 to 1.9.23
Release notes
Sourced from https://
dependabot[bot] closed pull request #111: Bump resolverVersion from 1.4.1 to
1.9.22
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
dependabot[bot] commented on PR #111:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/111#issuecomment-2866228818
Superseded by #119.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Pankraz76 commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2866224314
imho, this branch can never happen:
because of early exit check before its to much defensive over here resulting
in unreachable code.
https://github.com/user-attachments/assets/e
Pankraz76 commented on PR #2283:
URL: https://github.com/apache/maven/pull/2283#issuecomment-2866182164
whats your call on this @gnodet?
might be rdy to merge and gain feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2081466671
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -94,50 +97,45 @@ public Path locateExistingPom(Path projectDirectory) {
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2081387417
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -77,67 +80,69 @@ public DefaultModelProcessor(ModelXmlFactory
modelXmlFa
Pankraz76 commented on code in PR #2304:
URL: https://github.com/apache/maven/pull/2304#discussion_r2081386336
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -77,67 +80,69 @@ public DefaultModelProcessor(ModelXmlFactory
modelXmlFa
Pankraz76 commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2081384120
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -69,25 +72,31 @@
public class DefaultModelProcessor implements ModelProc
Pankraz76 commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2081376498
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -69,25 +72,31 @@
public class DefaultModelProcessor implements ModelProc
Pankraz76 commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2081373513
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -97,47 +101,50 @@ public Path locateExistingPom(Path projectDirectory) {
Pankraz76 commented on PR #72:
URL:
https://github.com/apache/maven-shared-resources/pull/72#issuecomment-2865851036
is this any good? @gnodet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Pankraz76 commented on PR #2302:
URL: https://github.com/apache/maven/pull/2302#issuecomment-2865850423
> This hinders readability.
> To keep readability, maybe put `` on its own line.
yes.
> Also, if you want to enforce checkstyle rules, this need to be done in the
dependabot[bot] opened a new pull request, #212:
URL: https://github.com/apache/maven-build-cache-extension/pull/212
Bumps org.apache.maven.resolver:maven-resolver-transport-http from 1.9.22 to
1.9.23.
[ throws
IO
84 matches
Mail list logo
