elharo commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081582064
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
request) throws XmlReader
return xml.read(inputStream, request.isStrict());
} else if (reader != null) {
return xml.read(reader, request.isStrict());
- } else if (path != null) {
- try (InputStream is = Files.newInputStream(path)) {
- return xml.read(is, request.isStrict());
- }
- } else {
- try (InputStream is = url.openStream()) {
- return xml.read(is, request.isStrict());
- }
+ }
Review Comment:
I still don't like how the code flows here. If this case really isn't
possible remove it or just maybe throw an IllegalStateException or something
like that. requireNonNull doesn't seem helpful here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
