desruisseaux commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082405722
##########
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##########
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the <abbr>POM</abbr> file.
*
* <h4>Default implementation</h4>
- * The default value is <code>src/{@linkplain #scope() scope}/{@linkplain
#language() language}</code>
- * as a relative path. Implementation classes may override this default
with an absolute path instead.
+ * The default value depends on whether a {@linkplain #module() module
name} is specified in this source root:
+ * <ul>
+ * <li>
+ * If no module name, then the default directory is
Review Comment:
Indeed, the rational is as Guillaume said. While we try to avoid disruption
for users who are not interested in JPMS, those who want to embrace fully JPMS
will have to change some habits anyway, some of them out of our control (e.g.,
the directory layout of `javac` output).
There is a difficulty with resources, which are considered as a language and
therefore would be stored apart with a `src/${lang}/${module}/${scope}` layout
if the users do not specify the directory themselves. An alternative staying
closer to current Maven practice may be `src/${module}/${scope}/${lang}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
