Pankraz76 commented on code in PR #2306:
URL: https://github.com/apache/maven/pull/2306#discussion_r2081581566
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -62,14 +63,9 @@ public PluginDescriptor read(@Nonnull XmlReaderRequest
request) throws XmlReader
return xml.read(inputStream, request.isStrict());
} else if (reader != null) {
return xml.read(reader, request.isStrict());
- } else if (path != null) {
- try (InputStream is = Files.newInputStream(path)) {
- return xml.read(is, request.isStrict());
- }
- } else {
- try (InputStream is = url.openStream()) {
- return xml.read(is, request.isStrict());
- }
+ }
Review Comment:
early exit then tho IDE makes warning here too, requesting `requireNonNull`.
If path is null like you tell, whats `impossible` imho, then it will exit
here again with runtime error.
<img width="799" alt="image"
src="https://github.com/user-attachments/assets/27d1e055-d4e2-495f-91a4-2d893a84a9c2";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
