[jira] [Commented] (MARTIFACT-80) `ignore` doesn't work on the main module artifact

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911360#comment-17911360 ] ASF GitHub Bot commented on MARTIFACT-80: - facboy commented on code in PR #71:

Re: [PR] [MARTIFACT-80] Apply ignore configuration to main project artifact as well [maven-artifact-plugin]

2025-01-08 Thread via GitHub
facboy commented on code in PR #71: URL: https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908308988 ## src/it/compare-ignore/modA/pom.xml: ## @@ -0,0 +1,61 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
kwin commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908279481 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- Review Comment: This PR has two commits for exactly that reason -- This is an automated

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
kwin commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908278960 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- +title: Apache Software Foundation Parent POM +author: + - Benson Margulies + - Hervé Boutem

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908267404 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- Review Comment: I wonder if we should use two commits to somehow force the git history to

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908266832 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- +title: Apache Software Foundation Parent POM +author: + - Benson Margulies + - Hervé Bout

[jira] [Commented] (MARTIFACT-80) `ignore` doesn't work on the main module artifact

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911345#comment-17911345 ] ASF GitHub Bot commented on MARTIFACT-80: - hboutemy commented on code in PR #71

Re: [PR] [MARTIFACT-80] Apply ignore configuration to main project artifact as well [maven-artifact-plugin]

2025-01-08 Thread via GitHub
hboutemy commented on code in PR #71: URL: https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908258500 ## src/it/compare-ignore/modA/pom.xml: ## @@ -0,0 +1,61 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc

[jira] [Commented] (MARTIFACT-80) `ignore` doesn't work on the main module artifact

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911344#comment-17911344 ] ASF GitHub Bot commented on MARTIFACT-80: - hboutemy commented on code in PR #71

Re: [PR] [MARTIFACT-80] Apply ignore configuration to main project artifact as well [maven-artifact-plugin]

2025-01-08 Thread via GitHub
hboutemy commented on code in PR #71: URL: https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908256555 ## src/it/compare-ignore/modA/pom.xml: ## @@ -0,0 +1,61 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc

[jira] [Commented] (MNG-8418) regression: maven 4: Duplicate key default

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911264#comment-17911264 ] Guillaume Nodet commented on MNG-8418: -- [~hohwille] the errors seems to point at multi

Re: [PR] Drop additional configuration for requirementsHistories [maven-site-plugin]

2025-01-08 Thread via GitHub
slawekjaranowski merged PR #221: URL: https://github.com/apache/maven-site-plugin/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Closed] (MNG-8491) Make DIIndexProcessor opt-in

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8491. Resolution: Won't Fix I'll close this one as won't fix. I think it started with a misunderstanding a

[jira] [Closed] (MNG-8455) WARNING deprecated method in sun.misc.Unsafe has been called

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8455. Fix Version/s: (was: 4.0.0) Assignee: Guillaume Nodet Resolution: Won't Fix > WAR

[jira] [Commented] (MNG-8455) WARNING deprecated method in sun.misc.Unsafe has been called

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911256#comment-17911256 ] Guillaume Nodet commented on MNG-8455: -- Not calling guava is not doable. As [~cstamas]

[jira] [Closed] (MNG-8505) WARNING: A terminally deprecated method in sun.misc.Unsafe has been called

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8505. Resolution: Duplicate > WARNING: A terminally deprecated method in sun.misc.Unsafe has been called >

Re: [PR] Just an IT run for PR 2018 [maven]

2025-01-08 Thread via GitHub
cstamas closed pull request #2033: Just an IT run for PR 2018 URL: https://github.com/apache/maven/pull/2033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Fix typos in issue templates [maven-gh-actions-shared]

2025-01-08 Thread via GitHub
slawekjaranowski merged PR #125: URL: https://github.com/apache/maven-gh-actions-shared/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

Re: [PR] [MNG-8482] Use instanceof assignments to get rid of casting expressions [maven]

2025-01-08 Thread via GitHub
breun commented on PR #2018: URL: https://github.com/apache/maven/pull/2018#issuecomment-2578833724 Changes to IT codebase have been undone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [MNG-8482] Use instanceof assignments to get rid of casting expressions [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2018: URL: https://github.com/apache/maven/pull/2018#issuecomment-2578779971 In short: let apply this change to _maven codebase_ only, and IT codebase should remain untouched for now (as many of those are still release=8 despite surrounding reactor of maven is 17)

Re: [PR] [MNG-8482] Use instanceof assignments to get rid of casting expressions [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2018: URL: https://github.com/apache/maven/pull/2018#issuecomment-2578778134 @breun for you: in my PR there are two changes you need to pick. One of those two undos any IT code change -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [MNG-8482] Use instanceof assignments to get rid of casting expressions [maven]

2025-01-08 Thread via GitHub
breun commented on PR #2018: URL: https://github.com/apache/maven/pull/2018#issuecomment-2578777189 @gnodet Is that question about splitting directed at @cstamas or me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Closed] (MNG-8431) Lifecycle doc broken

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8431. Assignee: Tamas Cservenak Resolution: Fixed > Lifecycle doc broken > > >

Re: [PR] [MNG-8473] Site fixes [maven]

2025-01-08 Thread via GitHub
cstamas merged PR #2010: URL: https://github.com/apache/maven/pull/2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[jira] [Closed] (MNG-8473) Site and XSD/doco generation fixed

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8473. Resolution: Fixed > Site and XSD/doco generation fixed > -- > >

[jira] [Commented] (MNG-8505) WARNING: A terminally deprecated method in sun.misc.Unsafe has been called

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911242#comment-17911242 ] Tamas Cservenak commented on MNG-8505: -- Maven 3 uses Eclipse Sisu/Plexus that uses Gui

Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2024.8 to 1.2025.0 [maven-site]

2025-01-08 Thread via GitHub
slachiewicz commented on PR #633: URL: https://github.com/apache/maven-site/pull/633#issuecomment-2578701010 If we could find some ready diff action to compare - master vs proposed generated site. With plantuml I saw many changes in the SVG files - for me it was hard to say how much it d

[jira] [Created] (MNG-8505) WARNING: A terminally deprecated method in sun.misc.Unsafe has been called

2025-01-08 Thread Keith E Campbell (Jira)
Keith E Campbell created MNG-8505: - Summary: WARNING: A terminally deprecated method in sun.misc.Unsafe has been called Key: MNG-8505 URL: https://issues.apache.org/jira/browse/MNG-8505 Project: Maven

Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2024.8 to 1.2025.0 [maven-site]

2025-01-08 Thread via GitHub
slawekjaranowski commented on PR #633: URL: https://github.com/apache/maven-site/pull/633#issuecomment-2578671107 GH build store site as atachemnt can be downloaded https://github.com/apache/maven-site/actions/runs/12660925691 -- This is an automated message from the Apache Git Serv

Re: [PR] [MNG-8482] Use instanceof assignments to get rid of casting expressions [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2018: URL: https://github.com/apache/maven/pull/2018#issuecomment-2578622288 What about splitting this PR ? Let's keep aside the changes targeting ITs for now, so that we can merge the others. -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (MRESOLVER-652) Resolver 2.x renamed some properties like split repo

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-652: -- Description: But IDEA IDE supports only 1.x properties, while Maven 4 (Resolver 2) o

[PR] (doc) Close links tag in links parameter javadoc example [maven-javadoc-plugin]

2025-01-08 Thread via GitHub
sixcorners opened a new pull request, #355: URL: https://github.com/apache/maven-javadoc-plugin/pull/355 Teeny tiny change to add a / to the end tag in an example in a javadoc for the links configuration. - [x] I hereby declare this contribution to be licensed under the [Apache Lice

[jira] [Commented] (DOXIA-771) Markdown: Generated anchors of headings are incompatible with "regular" inpage-links

2025-01-08 Thread Jira
[ https://issues.apache.org/jira/browse/DOXIA-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911226#comment-17911226 ] Matthias Bünger commented on DOXIA-771: --- Ok wrote two tests 1. The custom-html anch

Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2024.8 to 1.2025.0 [maven-site]

2025-01-08 Thread via GitHub
slachiewicz commented on PR #633: URL: https://github.com/apache/maven-site/pull/633#issuecomment-2578562548 Would be good to verify diff between new and old site generated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Convert to Guice @Inject [maven-jarsigner-plugin]

2025-01-08 Thread via GitHub
pzygielo commented on PR #42: URL: https://github.com/apache/maven-jarsigner-plugin/pull/42#issuecomment-2578468234 Can `guice` be deleted now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Remove unused method [maven-install-plugin]

2025-01-08 Thread via GitHub
pzygielo commented on PR #97: URL: https://github.com/apache/maven-install-plugin/pull/97#issuecomment-2578359390 It's even listed here: https://maven.apache.org/plugins/maven-install-plugin/pmd.html ![image](https://github.com/user-attachments/assets/1fd02526-5996-4cb7-b391-f0cf9b0

[PR] Remove unused method [maven-install-plugin]

2025-01-08 Thread via GitHub
pzygielo opened a new pull request, #97: URL: https://github.com/apache/maven-install-plugin/pull/97 - left in #81 - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2

[jira] [Commented] (MCOMPILER-529) Improve the docs about usage 1.8 vs. 8 for source/target

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911192#comment-17911192 ] ASF GitHub Bot commented on MCOMPILER-529: -- slachiewicz commented on PR #245:

Re: [PR] [MCOMPILER-529] information that it's possible to use "8" as source/target [maven-compiler-plugin]

2025-01-08 Thread via GitHub
slachiewicz commented on PR #245: URL: https://github.com/apache/maven-compiler-plugin/pull/245#issuecomment-2578317952 It's possible to set .release property not only for Java 9+ but also do or Java 8. Plugin will skip passing this parameter to compiler for Java 8 -- This is an automat

[jira] [Created] (MSKINS-264) dark mode?

2025-01-08 Thread Stephen Buergler (Jira)
Stephen Buergler created MSKINS-264: --- Summary: dark mode? Key: MSKINS-264 URL: https://issues.apache.org/jira/browse/MSKINS-264 Project: Maven Skins Issue Type: New Feature Compon

Re: [PR] Just an IT run for PR 2018 [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2033: URL: https://github.com/apache/maven/pull/2033#issuecomment-2578304880 The ITs are NOT part of current reactor (the "maven build") and they are still building projects mostly with Java=8, so those classes and resources should not be modified. -- This is an

Re: [PR] Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.3 [maven-artifact-plugin]

2025-01-08 Thread via GitHub
slachiewicz commented on PR #69: URL: https://github.com/apache/maven-artifact-plugin/pull/69#issuecomment-2578298651 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2031: URL: https://github.com/apache/maven/pull/2031#issuecomment-2578270193 These are literally copies of Maven 3 classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Just an IT run for PR 2018 [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2033: URL: https://github.com/apache/maven/pull/2033#issuecomment-2578267853 @breun @gnodet applied some fixes (and there was also a conflict) to Nils PR, let's see IT. IF OK, Nils you can pick changes from here. -- This is an automated message from the Apache Git

[PR] Just an IT run for PR 2018 [maven]

2025-01-08 Thread via GitHub
cstamas opened a new pull request, #2033: URL: https://github.com/apache/maven/pull/2033 Fixes https://github.com/apache/maven/pull/2018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #2031: URL: https://github.com/apache/maven/pull/2031#discussion_r1907552641 ## compat/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -33,31 +34,177 @@ */ @Deprecated public abstract class A

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2031: URL: https://github.com/apache/maven/pull/2031#issuecomment-2578233432 99% of the code here is copy/pasted from maven-3.9.x branch to restore compatibility... so I'm fine with any change you suggest, but I really don't expect you to closely review all the chang

Re: [PR] [MNG-8483] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2578223876 Also title: "Prefer Objects.requireNonNull" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [MNG-8483] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2578221517 perso i like it, one nit: i usually static import the method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911170#comment-17911170 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907535037 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911169#comment-17911169 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

[jira] [Assigned] (MNG-8475) In the loop scenario, StringBuilder is used instead of concatenation

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8475: Assignee: Zhongming Hua > In the loop scenario, StringBuilder is used instead of concatenati

[jira] [Closed] (MNG-8475) In the loop scenario, StringBuilder is used instead of concatenation

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8475. Resolution: Fixed > In the loop scenario, StringBuilder is used instead of concatenation > --

Re: [PR] [MNG-8475] In the loop scenario, StringBuilder is used instead of concatenation [maven]

2025-01-08 Thread via GitHub
cstamas merged PR #2014: URL: https://github.com/apache/maven/pull/2014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907535037 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911166#comment-17911166 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907523702 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907523702 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911165#comment-17911165 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 [maven-mvnd]

2025-01-08 Thread via GitHub
cstamas merged PR #1239: URL: https://github.com/apache/maven-mvnd/pull/1239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911163#comment-17911163 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907512869 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[jira] [Updated] (MNG-8502) The "embedded" executor does not obey MAVEN_ARGS env variable

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8502: - Summary: The "embedded" executor does not obey MAVEN_ARGS env variable (was: The "embeded" executo

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911161#comment-17911161 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907487620 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2024.8 to 1.2025.0 [maven-site]

2025-01-08 Thread via GitHub
elharo merged PR #633: URL: https://github.com/apache/maven-site/pull/633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [I] Spotless application broke at least one page [maven-site]

2025-01-08 Thread via GitHub
elharo commented on issue #632: URL: https://github.com/apache/maven-site/issues/632#issuecomment-2578104530 Haven't seen that page before but there are some good things in it (and some bad ones). I suggest merging the good parts into the official FAQ and deleting what remains. -- This

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.0.BETA4 to 2.44.1 [maven-site]

2025-01-08 Thread via GitHub
elharo merged PR #634: URL: https://github.com/apache/maven-site/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [I] Update Articles links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 commented on issue #631: URL: https://github.com/apache/maven-site/issues/631#issuecomment-2578082540 I have created pull request. Happy to receive feedback and changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[PR] Updated the article resources links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 opened a new pull request, #635: URL: https://github.com/apache/maven-site/pull/635 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Resolved] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MENFORCER-511. - Resolution: Fixed > RequireUpperBoundDeps: ExcludedScopes typo in docs

[jira] [Closed] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MENFORCER-511. --- > RequireUpperBoundDeps: ExcludedScopes typo in docs > ---

[PR] Grammar nits [maven-enforcer]

2025-01-08 Thread via GitHub
elharo opened a new pull request, #342: URL: https://github.com/apache/maven-enforcer/pull/342 "Setup" is a noun. "Set up" is a verb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911152#comment-17911152 ] ASF GitHub Bot commented on MENFORCER-511: -- elharo merged PR #341: URL: https

Re: [PR] [MENFORCER-511] Match start-tag to end-tag [maven-enforcer]

2025-01-08 Thread via GitHub
elharo merged PR #341: URL: https://github.com/apache/maven-enforcer/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[jira] [Closed] (MNG-8502) The "embeded" executor does not obey MAVEN_ARGS env variable

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8502. Resolution: Fixed > The "embeded" executor does not obey MAVEN_ARGS env variable > --

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
elharo commented on code in PR #2031: URL: https://github.com/apache/maven/pull/2031#discussion_r1907411612 ## api/maven-api-toolchain/src/main/mdo/toolchains.mdo: ## @@ -102,6 +102,18 @@ + + + 1.0.0/1.1.0 + +

Re: [PR] [MNG-8502] Embedded executor should obey MAVEN_ARGS env variable [maven]

2025-01-08 Thread via GitHub
cstamas merged PR #2032: URL: https://github.com/apache/maven/pull/2032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [I] Update Articles links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 commented on issue #631: URL: https://github.com/apache/maven-site/issues/631#issuecomment-2578020041 If anyone find any valuable new resources we can add those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] Update Articles links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 commented on issue #631: URL: https://github.com/apache/maven-site/issues/631#issuecomment-2578017425 > can be interesting: > > https://analytics.apache.org/index.php?module=Overlay&period=month&date=today&idSite=3#?l=https$3A$2F$2Fmaven.apache.org$2Farticles.html Ba

Re: [PR] Fix comparisons against null in PathSource.equals [maven]

2025-01-08 Thread via GitHub
elharo merged PR #2026: URL: https://github.com/apache/maven/pull/2026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911148#comment-17911148 ] ASF GitHub Bot commented on MSHARED-1454: - elharo commented on code in PR #50:

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
elharo commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907400797 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean origina

Re: [PR] [MNG-8493] 'serialVersionUID' can be annotated with '@Serial' annotation [maven]

2025-01-08 Thread via GitHub
Stellar1999 commented on code in PR #2025: URL: https://github.com/apache/maven/pull/2025#discussion_r1907404189 ## impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenBaseLogger.java: ## @@ -146,6 +147,7 @@ */ public class MavenBaseLogger extends LegacyAbstractLogge

Re: [PR] [MNGSITE-393] Remove references to Maven 2.x [maven]

2025-01-08 Thread via GitHub
elharo commented on code in PR #2024: URL: https://github.com/apache/maven/pull/2024#discussion_r1907399068 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -542,9 +542,9 @@ String

Re: [PR] [MNG-8483] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
elharo commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2577992616 yep, should be MNG-8483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911140#comment-17911140 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907385225 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -16,7 +16,7 @@ * specific language governing permissions and limitatio

Re: [PR] [MHG-8471] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2577918295 `MHG-8471` ? [`MNG-8471](https://issues.apache.org/jira/browse/MNG-8471) looks unrelated to me -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Delete unused mode constants [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2022: URL: https://github.com/apache/maven/pull/2022#issuecomment-2577911087 > Or throw an exception? Throwing an exception would indeed be easier. We'd need to assess that not too many POMs using invalid values... -- This is an automated message from the A

Re: [PR] [MNGSITE-393] Remove references to Maven 2.x [maven]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #2024: URL: https://github.com/apache/maven/pull/2024#discussion_r1907339251 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -542,9 +542,9 @@ String

Re: [PR] MCOMPILER-579 allow module-version configuration [maven-compiler-plugin]

2025-01-08 Thread via GitHub
mguillem commented on PR #273: URL: https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2577891415 Is there a chance to see this merged and released? Otherwise we'll have to start working with our own private version of the plugin what is never a pleasure to maintain. -

[jira] [Commented] (MCOMPILER-579) JPMS modules and `--module-version`

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911129#comment-17911129 ] ASF GitHub Bot commented on MCOMPILER-579: -- mguillem commented on PR #273: UR

[jira] [Updated] (MNG-8504) Maven deploy with "release-profile" fails due to exception in plugin validation

2025-01-08 Thread Dieter Deforce (Jira)
[ https://issues.apache.org/jira/browse/MNG-8504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dieter Deforce updated MNG-8504: Description: Since Maven version 3.9.3 we are running into an exception when trying to release Maven

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911128#comment-17911128 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

[jira] [Assigned] (MNG-8494) Restore Maven 3 compatibility

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8494: Assignee: Guillaume Nodet > Restore Maven 3 compatibility > - >

[jira] [Updated] (MNG-8503) Configure logging using maven.logging.* properties rather than org.slf4j.simpleLogger.*

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8503: - Description: The {{MavenBaseLogger}} is a clone of the slf4j simple logger. However, it slightly di

[jira] [Updated] (MNG-8503) Configure logging using maven.logging.* properties rather than org.slf4j.simpleLogger.*

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8503: - Affects Version/s: 4.0.0-rc-2 > Configure logging using maven.logging.* properties rather than > o

[jira] [Created] (MNG-8504) Maven deploy with "release-profile" fails due to exception in plugin validation

2025-01-08 Thread Dieter Deforce (Jira)
Dieter Deforce created MNG-8504: --- Summary: Maven deploy with "release-profile" fails due to exception in plugin validation Key: MNG-8504 URL: https://issues.apache.org/jira/browse/MNG-8504 Project: Mave

  1   2   >