[
https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911344#comment-17911344
]
ASF GitHub Bot commented on MARTIFACT-80:
-----------------------------------------
hboutemy commented on code in PR #71:
URL:
https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908256555
##########
src/it/compare-ignore/modA/pom.xml:
##########
@@ -0,0 +1,61 @@
+<?xml version='1.0' encoding='UTF-8'?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.maven.plugins.it</groupId>
+ <artifactId>ignore</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>ignore-modA</artifactId>
+ <packaging>jar</packaging>
+ <name>ignore module A</name>
+
+ <build>
+ <resources>
+ <resource>
+ <directory>src/main/resources</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+
+ <plugins>
+ <plugin>
+ <groupId>@project.groupId@</groupId>
+ <artifactId>@project.artifactId@</artifactId>
+ <version>@project.version@</version>
+ <configuration>
+ <ignore>*/ignore-modA-*.jar</ignore>
Review Comment:
I never thought precisely at it in the past, but now I see it arises
naturally
I'd say, yes, that it's intended to be configured at top-level, because it's
a full build process that has to be checked. Partial checks run one one single
module are just partial executions: it's useful to get faster feedback when
testing, but at the end, it's the whole build that counts
> `ignore` doesn't work on the main module artifact
> -------------------------------------------------
>
> Key: MARTIFACT-80
> URL: https://issues.apache.org/jira/browse/MARTIFACT-80
> Project: Maven Artifact Plugin
> Issue Type: Bug
> Components: artifact:compare
> Affects Versions: 3.5.3
> Reporter: Christopher Ng
> Priority: Major
> Labels: pull-request-available
>
> The `ignore` configuration option doesn't work on the main artifact of the
> module, only on additional attached artifacts.
> Use case I have is that we're building RPMs on a (very) old CentOS version
> and they have attributes that aren't easily 'fixable' to be cleanly rebuilt.
> I ignore 'failures' in those individual modules, but when the plugin tries to
> do the aggregated `buildInfo` on the last module those RPMs aren't ignored,
> and I don't want to ignore failures for every module in the aggregator.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
