[
https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911128#comment-17911128
]
ASF GitHub Bot commented on MSHARED-1454:
-----------------------------------------
LogFlames commented on code in PR #50:
URL:
https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907320106
##########
src/test/java/org/apache/maven/shared/dependency/graph/internal/DefaultDependencyNodeTest.java:
##########
@@ -42,4 +42,12 @@ public void
nodeString_for_mandatory_depenendency_does_not_contain_optional_info
new DefaultDependencyNode(null, artifact, "1.0", "compile",
"1.0", false, emptyList());
assertEquals("group:artifact:jar:1.2:compile",
optionalNode.toNodeString());
}
+
+ @Test
+ public void defaultDependencyNode_should_return_null_conflict_data() {
Review Comment:
Want to doublecheck: `defaultDependencyNodeShouldReturnNullConflictData`?
Should I rename the other tests in this file as well
(`nodeString_for_mandatory_depenendency_does_not_contain_optional_information`
and `nodeString_should_display_if_dependency_is_optonal`)?
> Conflict Data on VerboseDependencyNode is hidden
> ------------------------------------------------
>
> Key: MSHARED-1454
> URL: https://issues.apache.org/jira/browse/MSHARED-1454
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-dependency-tree
> Reporter: Elias Lundell
> Priority: Minor
> Labels: pull-request-available
>
> In maven-dependency-plugin there are multiple export formats for the
> dependency tree, these include Json, DOT, GraphML etc. When creating the
> normal tree all information is there to format it nicely as e.g. Json.
> However, when running `{{{}mvn dependency:tree -Dverbose{}}}`, all nodes are
> included (as they are VerboseDependencyNode) but since VerboseDependencyNode
> is internal in maven-dependency-tree there is no (clean) way to include
> information of which nodes are included or not (see
> https://issues.apache.org/jira/browse/MDEP-962).
> The only current way to include this information would be to parse the
> `{{{}toNodeString(){}}}` output (where excluded nodes are wrapped in
> parenthesis).
> I propose to expose ConflictData on the DependencyNode and make it null for
> DefaultDependencyNode to allow for more detailed information in the
> machine-readable formats.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
