[
https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911140#comment-17911140
]
ASF GitHub Bot commented on MSHARED-1454:
-----------------------------------------
LogFlames commented on code in PR #50:
URL:
https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907385225
##########
src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java:
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.maven.shared.dependency.graph.internal;
+package org.apache.maven.shared.dependency.graph;
Review Comment:
Added javadoc comments for all public methods and constructor.
> Conflict Data on VerboseDependencyNode is hidden
> ------------------------------------------------
>
> Key: MSHARED-1454
> URL: https://issues.apache.org/jira/browse/MSHARED-1454
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-dependency-tree
> Reporter: Elias Lundell
> Priority: Minor
> Labels: pull-request-available
>
> In maven-dependency-plugin there are multiple export formats for the
> dependency tree, these include Json, DOT, GraphML etc. When creating the
> normal tree all information is there to format it nicely as e.g. Json.
> However, when running `{{{}mvn dependency:tree -Dverbose{}}}`, all nodes are
> included (as they are VerboseDependencyNode) but since VerboseDependencyNode
> is internal in maven-dependency-tree there is no (clean) way to include
> information of which nodes are included or not (see
> https://issues.apache.org/jira/browse/MDEP-962).
> The only current way to include this information would be to parse the
> `{{{}toNodeString(){}}}` output (where excluded nodes are wrapped in
> parenthesis).
> I propose to expose ConflictData on the DependencyNode and make it null for
> DefaultDependencyNode to allow for more detailed information in the
> machine-readable formats.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
