[jira] [Closed] (MNG-7822) Add support for TRACE logging level (with style "bold,magenta")

2023-08-25 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7822. Fix Version/s: 4.0.0-alpha-8 Resolution: Fixed > Add support for TRACE logging level (with sty

[jira] [Commented] (MNG-7822) Add support for TRACE logging level (with style "bold,magenta")

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759090#comment-17759090 ] ASF GitHub Bot commented on MNG-7822: - gnodet merged PR #1215: URL: https://github.com/

[GitHub] [maven-mvnd] khmarbaise commented on pull request #882: Removed superfluous public for tests

2023-08-25 Thread via GitHub
khmarbaise commented on PR #882: URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1693429591 Are those windows build not stable? Looks like that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven-mvnd] khmarbaise opened a new pull request, #882: Removed superfluous public for tests

2023-08-25 Thread via GitHub
khmarbaise opened a new pull request, #882: URL: https://github.com/apache/maven-mvnd/pull/882 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (MNG-7822) Add support for TRACE logging level (with style "bold,magenta")

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759047#comment-17759047 ] ASF GitHub Bot commented on MNG-7822: - gnodet commented on code in PR #1215: URL: https

[jira] [Commented] (MNG-7822) Add support for TRACE logging level (with style "bold,magenta")

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759046#comment-17759046 ] ASF GitHub Bot commented on MNG-7822: - gnodet commented on code in PR #1215: URL: https

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759045#comment-17759045 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on PR #1208: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1693347546 @CrazyHZM I've seen the `Os` stuff copied multiple times. Could the class be copied into maven-core and reused instead of duplicating this bits 3/4 times ? -- This is an automated messa

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759043#comment-17759043 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759042#comment-17759042 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305645835 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305645105 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759037#comment-17759037 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305624838 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -122,12 +153,54 @@ private boolean determineFamilyMatch(Stri

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759036#comment-17759036 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305624838 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -122,12 +153,54 @@ private boolean determineFamilyMatch(Stri

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759032#comment-17759032 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305616342 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -122,12 +153,54 @@ private boolean determineFamilyMatch(Stri

[jira] [Commented] (MNG-7822) Add support for TRACE logging level (with style "bold,magenta")

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759029#comment-17759029 ] ASF GitHub Bot commented on MNG-7822: - elharo commented on code in PR #1215: URL: https

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759028#comment-17759028 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305598002 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758853#comment-17758853 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on PR #1208: URL: https://git

[GitHub] [maven] CrazyHZM commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-25 Thread via GitHub
CrazyHZM commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1692879432 > Nice, thx ! I think we can also revert the dependency on `commons-io` which was moved from `test` scope to `runtime`. Afaik, it's not used at runtime anymore with the recent changes.