[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759032#comment-17759032
]
ASF GitHub Bot commented on MNG-7820:
-------------------------------------
gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1305616342
##########
maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java:
##########
@@ -122,12 +153,54 @@ private boolean determineFamilyMatch(String family) {
test = test.substring(1);
}
- boolean result = Os.isFamily(test);
+ boolean result = isFamily(test);
if (reverse) {
return !result;
} else {
return result;
}
}
+
+ private boolean isFamily(String family) {
Review Comment:
Mmh, could the reason be that you're considering this code as new code,
whereas I consider it as a code move from plexus-utils ? If it was good to be
used there, I assume it's good to be used in maven too as-is...
So which ones do you want to remove support for exactly ?
> Remove dependency on plexus-utils
> ---------------------------------
>
> Key: MNG-7820
> URL: https://issues.apache.org/jira/browse/MNG-7820
> Project: Maven
> Issue Type: Task
> Reporter: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
