gnodet commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1305616342
##########
maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java:
##########
@@ -122,12 +153,54 @@ private boolean determineFamilyMatch(String family) {
test = test.substring(1);
}
- boolean result = Os.isFamily(test);
+ boolean result = isFamily(test);
if (reverse) {
return !result;
} else {
return result;
}
}
+
+ private boolean isFamily(String family) {
Review Comment:
Mmh, could the reason be that you're considering this code as new code,
whereas I consider it as a code move from plexus-utils ? If it was good to be
used there, I assume it's good to be used in maven too as-is...
So which ones do you want to remove support for exactly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
