[
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759036#comment-17759036
]
ASF GitHub Bot commented on MNG-7820:
-------------------------------------
elharo commented on code in PR #1208:
URL: https://github.com/apache/maven/pull/1208#discussion_r1305624838
##########
maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java:
##########
@@ -122,12 +153,54 @@ private boolean determineFamilyMatch(String family) {
test = test.substring(1);
}
- boolean result = Os.isFamily(test);
+ boolean result = isFamily(test);
if (reverse) {
return !result;
} else {
return result;
}
}
+
+ private boolean isFamily(String family) {
Review Comment:
Just moving code from plexus is not kosher, either technically or legally.
plexus-utils has iffy ownership and license status due to the Codehaus mess.
Nor has it had good maintenance or updates over the years. It should be
replaced de novo. Copy paste of the existing code is not OK.
> Remove dependency on plexus-utils
> ---------------------------------
>
> Key: MNG-7820
> URL: https://issues.apache.org/jira/browse/MNG-7820
> Project: Maven
> Issue Type: Task
> Reporter: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
