[GitHub] [maven-site] bmarwell merged pull request #353: [INFRA] add autolink refs

2022-12-09 Thread GitBox
bmarwell merged PR #353: URL: https://github.com/apache/maven-site/pull/353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

[jira] [Commented] (MNG-7563) Java system properties now override user properties in dependencies

2022-12-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645521#comment-17645521 ] Michael Osipov commented on MNG-7563: - User properties always override model regardless

[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645520#comment-17645520 ] ASF GitHub Bot commented on MNG-7505: - michael-o commented on PR #906: URL: https://git

[GitHub] [maven] michael-o commented on pull request #906: [MNG-7505] Disable reportPlugins processing if m-site-p >= 3.7.0 is used

2022-12-09 Thread GitBox
michael-o commented on PR #906: URL: https://github.com/apache/maven/pull/906#issuecomment-1344904179 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645519#comment-17645519 ] ASF GitHub Bot commented on MNGSITE-503: michael-o commented on code in PR #354:

[GitHub] [maven-site] michael-o commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
michael-o commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044919562 ## pom.xml: ## @@ -232,6 +232,32 @@ --> + + +org.codehaus.mojo +build-helper-maven-plugin +3.3.0 + +

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645518#comment-17645518 ] ASF GitHub Bot commented on MNGSITE-503: michael-o commented on code in PR #354:

[GitHub] [maven-site] michael-o commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
michael-o commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044919421 ## pom.xml: ## @@ -232,6 +232,32 @@ --> + + +org.codehaus.mojo +build-helper-maven-plugin +3.3.0 + +

[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645515#comment-17645515 ] ASF GitHub Bot commented on MNG-7505: - slawekjaranowski commented on PR #906: URL: http

[GitHub] [maven] slawekjaranowski commented on pull request #906: [MNG-7505] Disable reportPlugins processing if m-site-p >= 3.7.0 is used

2022-12-09 Thread GitBox
slawekjaranowski commented on PR #906: URL: https://github.com/apache/maven/pull/906#issuecomment-1344891165 Now we only move `outputDirectory` from reporting section to site plugin configuration ... but also this is not needed - plugin parameter has as default: `${project.reporting.outp

[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645512#comment-17645512 ] ASF GitHub Bot commented on MNG-7505: - gnodet commented on PR #906: URL: https://github

[GitHub] [maven] gnodet commented on pull request #906: [MNG-7505] Disable reportPlugins processing if m-site-p >= 3.7.0 is used

2022-12-09 Thread GitBox
gnodet commented on PR #906: URL: https://github.com/apache/maven/pull/906#issuecomment-1344884879 > It can be ... > but we have next workaround for plugin which was released 2017 This old ? @slawekjaranowski I've updated the PR to get rid of that code completely... -- This

[GitHub] [maven-mvnd] gnodet merged pull request #751: Fix daemon JVM start options (follow-up to #749)

2022-12-09 Thread GitBox
gnodet merged PR #751: URL: https://github.com/apache/maven-mvnd/pull/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645508#comment-17645508 ] ASF GitHub Bot commented on MNGSITE-503: bmarwell commented on code in PR #354:

[GitHub] [maven-site] bmarwell commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
bmarwell commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044897609 ## pom.xml: ## @@ -232,6 +232,32 @@ --> + + +org.codehaus.mojo +build-helper-maven-plugin +3.3.0 + +

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645504#comment-17645504 ] ASF GitHub Bot commented on MNGSITE-503: bmarwell commented on code in PR #354:

[GitHub] [maven-site] bmarwell commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
bmarwell commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044893006 ## pom.xml: ## @@ -232,6 +232,32 @@ --> + + +org.codehaus.mojo +build-helper-maven-plugin +3.3.0 + +

[jira] [Commented] (MNG-7615) Multithreaded model builder

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645502#comment-17645502 ] ASF GitHub Bot commented on MNG-7615: - gnodet commented on PR #893: URL: https://github

[GitHub] [maven] gnodet commented on pull request #893: [MNG-7615] Multithreaded model builder

2022-12-09 Thread GitBox
gnodet commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1344854328 So the PR works with 1 one thread here, but may deadlock irrespective on the number of threads. The deadlock happen in the following scenario : 3 projects P1, P2, P3, P3 depends on P2, P2 d

[jira] [Commented] (MNG-7563) Java system properties now override user properties in dependencies

2022-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645497#comment-17645497 ] Hervé Guillemet commented on MNG-7563: -- Ok, my bad about user property vs Java propert

[jira] [Updated] (MNG-7563) Java system properties now override user properties in dependencies

2022-12-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7563: Fix Version/s: waiting-for-feedback > Java system properties now override user properties in dependen

[jira] [Commented] (MNG-7563) Java system properties now override user properties in dependencies

2022-12-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645485#comment-17645485 ] Michael Osipov commented on MNG-7563: - I ran now your sample and understand its structu

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645484#comment-17645484 ] ASF GitHub Bot commented on MNGSITE-503: michael-o commented on code in PR #354:

[GitHub] [maven-site] michael-o commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
michael-o commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044864320 ## pom.xml: ## @@ -232,6 +232,32 @@ --> + + +org.codehaus.mojo +build-helper-maven-plugin +3.3.0 + +

[jira] [Commented] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Basil Crow (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645466#comment-17645466 ] Basil Crow commented on SUREFIRE-2087: -- bq. So this works as you expect in JUnit

[jira] [Commented] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645465#comment-17645465 ] Elliotte Rusty Harold commented on SUREFIRE-2087: - So this works as yo

[GitHub] [maven-site] slawekjaranowski merged pull request #350: Add link to shared-resources with code style formatters

2022-12-09 Thread GitBox
slawekjaranowski merged PR #350: URL: https://github.com/apache/maven-site/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645459#comment-17645459 ] ASF GitHub Bot commented on MNGSITE-503: slawekjaranowski commented on code in P

[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
slawekjaranowski commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044752527 ## content/filtered-resources/.well-known/security.txt: ## @@ -0,0 +1,6 @@ +Contact: mailto:secur...@apache.org +Contact: mailto:secur...@maven.apache.org Re

[jira] [Commented] (MCOMPILER-501) compileSourceRoots parameter should be writable

2022-12-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645450#comment-17645450 ] Hudson commented on MCOMPILER-501: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[GitHub] [maven-site] bmarwell commented on a diff in pull request #353: [INFRA] add autolink refs

2022-12-09 Thread GitBox
bmarwell commented on code in PR #353: URL: https://github.com/apache/maven-site/pull/353#discussion_r1044677425 ## .asf.yaml: ## @@ -9,6 +9,28 @@ github: squash: true merge: false rebase: true + autolink_jira: +- MNG +- MNGSITE +- MSITE +- MINSTA

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645415#comment-17645415 ] ASF GitHub Bot commented on MNGSITE-503: bmarwell commented on code in PR #354:

[GitHub] [maven-site] bmarwell commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
bmarwell commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044674863 ## content/filtered-resources/.well-known/security.txt: ## @@ -0,0 +1,6 @@ +Contact: mailto:secur...@apache.org +Contact: mailto:secur...@maven.apache.org Review Com

[jira] [Closed] (MCOMPILER-501) compileSourceRoots parameter should be writable

2022-12-09 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MCOMPILER-501. - Resolution: Fixed > compileSourceRoots parameter should be writable > ---

[GitHub] [maven-compiler-plugin] gnodet merged pull request #159: [MCOMPILER-501] compileSourceRoots parameter should be writable

2022-12-09 Thread GitBox
gnodet merged PR #159: URL: https://github.com/apache/maven-compiler-plugin/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Updated] (MCOMPILER-501) compileSourceRoots parameter should be writable

2022-12-09 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MCOMPILER-501: -- Fix Version/s: 3.11.0 > compileSourceRoots parameter should be writable > -

[jira] [Assigned] (MCOMPILER-501) compileSourceRoots parameter should be writable

2022-12-09 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MCOMPILER-501: - Assignee: Guillaume Nodet > compileSourceRoots parameter should be writable

[GitHub] [maven-surefire] elharo commented on pull request #581: Don't list minor bugs in specific outdated versions on the home page

2022-12-09 Thread GitBox
elharo commented on PR #581: URL: https://github.com/apache/maven-surefire/pull/581#issuecomment-1344565387 Jenkins passes. Many of the cloudbees CIs look broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Basil Crow (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645399#comment-17645399 ] Basil Crow commented on SUREFIRE-2087: -- The difference in behavior between the {{

[jira] [Commented] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645390#comment-17645390 ] Elliotte Rusty Harold commented on SUREFIRE-2087: - OK, maybe I see it.

[jira] [Commented] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645388#comment-17645388 ] Elliotte Rusty Harold commented on SUREFIRE-2087: - I have read it and

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645378#comment-17645378 ] ASF GitHub Bot commented on MRESOLVER-305: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
cstamas commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044618718 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector n

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645367#comment-17645367 ] ASF GitHub Bot commented on MRESOLVER-305: -- kwin commented on code in PR #228

[GitHub] [maven-resolver] kwin commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
kwin commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044594871 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector newR

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645365#comment-17645365 ] ASF GitHub Bot commented on MRESOLVER-305: -- kwin commented on code in PR #228

[GitHub] [maven-resolver] kwin commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
kwin commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044594871 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector newR

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645364#comment-17645364 ] ASF GitHub Bot commented on MRESOLVER-305: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
cstamas commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044593073 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector n

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645361#comment-17645361 ] ASF GitHub Bot commented on MRESOLVER-305: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
cstamas commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044588589 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector n

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645360#comment-17645360 ] ASF GitHub Bot commented on MRESOLVER-305: -- kwin commented on code in PR #228

[GitHub] [maven-resolver] kwin commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
kwin commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044590603 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector newR

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645358#comment-17645358 ] ASF GitHub Bot commented on MRESOLVER-305: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
cstamas commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044588589 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector n

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645350#comment-17645350 ] ASF GitHub Bot commented on MRESOLVER-305: -- kwin commented on code in PR #228

[GitHub] [maven-resolver] kwin commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
kwin commented on code in PR #228: URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044577421 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java: ## @@ -109,6 +109,20 @@ public RepositoryConnector newR

[jira] [Comment Edited] (MRESOLVER-306) Make GenericVersionScheme.parseVersionConstraint(...) throw exception when comma-separated version string not starting with "(" or "[" is passed

2022-12-09 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645347#comment-17645347 ] Konrad Windszus edited comment on MRESOLVER-306 at 12/9/22 3:36 PM:

[jira] [Closed] (MRESOLVER-306) Make GenericVersionScheme.parseVersionConstraint(...) throw exception when comma-separated version string not starting with "(" or "[" is passed

2022-12-09 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed MRESOLVER-306. - Resolution: Invalid > Make GenericVersionScheme.parseVersionConstraint(...) throw exce

[jira] [Commented] (MRESOLVER-306) Make GenericVersionScheme.parseVersionConstraint(...) throw exception when comma-separated version string not starting with "(" or "[" is passed

2022-12-09 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645347#comment-17645347 ] Konrad Windszus commented on MRESOLVER-306: --- It turned out that the ordering

[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645341#comment-17645341 ] ASF GitHub Bot commented on MNG-7505: - gnodet opened a new pull request, #906: URL: htt

[GitHub] [maven] gnodet opened a new pull request, #906: [MNG-7505] Disable reportPlugins processing if m-site-p >= 3.7.0 is used

2022-12-09 Thread GitBox
gnodet opened a new pull request, #906: URL: https://github.com/apache/maven/pull/906 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the ch

[jira] [Closed] (MPOM-379) Bump spotless-maven-plugin from 2.27.1 to 2.28.0

2022-12-09 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-379. Resolution: Fixed > Bump spotless-maven-plugin from 2.27.1 to 2.28.0 > --

[jira] [Created] (MPOM-379) Bump spotless-maven-plugin from 2.27.1 to 2.28.0

2022-12-09 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-379: Summary: Bump spotless-maven-plugin from 2.27.1 to 2.28.0 Key: MPOM-379 URL: https://issues.apache.org/jira/browse/MPOM-379 Project: Maven POMs Issue

[GitHub] [maven-parent] slawekjaranowski merged pull request #93: Bump spotless-maven-plugin from 2.27.1 to 2.28.0

2022-12-09 Thread GitBox
slawekjaranowski merged PR #93: URL: https://github.com/apache/maven-parent/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645335#comment-17645335 ] ASF GitHub Bot commented on MRESOLVER-305: -- cstamas opened a new pull request

[GitHub] [maven-resolver] cstamas opened a new pull request, #228: [MRESOLVER-305] Handle blocked state at connector level

2022-12-09 Thread GitBox
cstamas opened a new pull request, #228: URL: https://github.com/apache/maven-resolver/pull/228 As blocked is really about block remote access. Locally cached things should not be affected, but current solution did not cover all execution paths. --- https://issues.apache.org/ji

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645334#comment-17645334 ] Tamas Cservenak commented on MRESOLVER-305: --- I do think this is only about R

[jira] [Commented] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645333#comment-17645333 ] Tamas Cservenak commented on MRESOLVER-305: --- I don't get why MRESOLVER-166 d

[jira] [Comment Edited] (MRESOLVER-305) Evaluate blocked repositories also when retrieving metadata

2022-12-09 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645333#comment-17645333 ] Tamas Cservenak edited comment on MRESOLVER-305 at 12/9/22 3:04 PM:

[GitHub] [maven-invoker] psiroky commented on a diff in pull request #58: [MSHARED-1151] Upgrade parent to version 38

2022-12-09 Thread GitBox
psiroky commented on code in PR #58: URL: https://github.com/apache/maven-invoker/pull/58#discussion_r1044522392 ## src/main/java/org/apache/maven/shared/invoker/DefaultInvoker.java: ## @@ -63,99 +58,78 @@ private InvocationOutputHandler errorHandler = DEFAULT_OUTPUT_HANDLE

[GitHub] [maven-invoker] psiroky commented on a diff in pull request #58: [MSHARED-1151] Upgrade parent to version 38

2022-12-09 Thread GitBox
psiroky commented on code in PR #58: URL: https://github.com/apache/maven-invoker/pull/58#discussion_r1044518853 ## pom.xml: ## @@ -103,21 +103,6 @@ under the License. - Review Comment: Alright, I *think* I managed to replicate the fixes in this commit - https

[jira] [Commented] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Basil Crow (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645318#comment-17645318 ] Basil Crow commented on SUREFIRE-2087: -- {quote}A reproducible example might also

[GitHub] [maven-invoker] dependabot[bot] commented on pull request #57: Bump maven-shared-components from 35 to 38

2022-12-09 Thread GitBox
dependabot[bot] commented on PR #57: URL: https://github.com/apache/maven-invoker/pull/57#issuecomment-1344347752 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, l

[GitHub] [maven-invoker] slawekjaranowski closed pull request #57: Bump maven-shared-components from 35 to 38

2022-12-09 Thread GitBox
slawekjaranowski closed pull request #57: Bump maven-shared-components from 35 to 38 URL: https://github.com/apache/maven-invoker/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645306#comment-17645306 ] ASF GitHub Bot commented on MNGSITE-503: slawekjaranowski commented on code in P

[jira] [Commented] (MRESOLVER-300) Introduce new API as replacement for FileTransform API

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645307#comment-17645307 ] ASF GitHub Bot commented on MRESOLVER-300: -- cstamas commented on PR #226: URL

[jira] [Commented] (MRESOLVER-300) Introduce new API as replacement for FileTransform API

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645305#comment-17645305 ] ASF GitHub Bot commented on MRESOLVER-300: -- cstamas closed pull request #226:

[jira] [Commented] (MRESOLVER-300) Introduce new API as replacement for FileTransform API

2022-12-09 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645304#comment-17645304 ] Tamas Cservenak commented on MRESOLVER-300: --- This is on hold, and will be pr

[GitHub] [maven-resolver] cstamas commented on pull request #226: [MRESOLVER-300] Alternate transform API

2022-12-09 Thread GitBox
cstamas commented on PR #226: URL: https://github.com/apache/maven-resolver/pull/226#issuecomment-1344339917 This is on hold for now, more on related IIRA issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
slawekjaranowski commented on code in PR #354: URL: https://github.com/apache/maven-site/pull/354#discussion_r1044477516 ## content/filtered-resources/.well-known/security.txt: ## @@ -0,0 +1,6 @@ +Contact: mailto:secur...@apache.org +Contact: mailto:secur...@maven.apache.org Re

[GitHub] [maven-resolver] cstamas closed pull request #226: [MRESOLVER-300] Alternate transform API

2022-12-09 Thread GitBox
cstamas closed pull request #226: [MRESOLVER-300] Alternate transform API URL: https://github.com/apache/maven-resolver/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (MRESOLVER-300) Introduce new API as replacement for FileTransform API

2022-12-09 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-300: -- Fix Version/s: (was: 1.9.3) > Introduce new API as replacement for FileTransform

[GitHub] [maven-site] kwin commented on a diff in pull request #353: [INFRA] add autolink refs

2022-12-09 Thread GitBox
kwin commented on code in PR #353: URL: https://github.com/apache/maven-site/pull/353#discussion_r1044456788 ## .asf.yaml: ## @@ -9,6 +9,28 @@ github: squash: true merge: false rebase: true + autolink_jira: +- MNG +- MNGSITE +- MSITE +- MINSTALL +

[GitHub] [maven-scripting-plugin] rmannibucau commented on pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-12-09 Thread GitBox
rmannibucau commented on PR #5: URL: https://github.com/apache/maven-scripting-plugin/pull/5#issuecomment-1344282710 Anything pending on this one? (just trying to see if we should try to move it forward or not) -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [maven-surefire] elharo commented on pull request #581: Don't list minor bugs in specific outdated versions on the home page

2022-12-09 Thread GitBox
elharo commented on PR #581: URL: https://github.com/apache/maven-surefire/pull/581#issuecomment-1344273736 Some of the CI jobs might be broken: C:\Users\jenkins\AppData\Local\Temp\jenkins-Maven-maven-box-maven-surefire-PR-581-1\maven-failsafe-plugin\target\it does not exist. -- T

[GitHub] [maven-surefire] elharo commented on pull request #574: [SUREFIRE-1887] Trim stacktraces to include relevant lines

2022-12-09 Thread GitBox
elharo commented on PR #574: URL: https://github.com/apache/maven-surefire/pull/574#issuecomment-1344272774 I don't think this is right. Per docs, trimStackTrace controls "Whether to trim the stack trace in the reports to just the lines within the test, or show the full trace." This PR

[jira] [Commented] (SUREFIRE-1887) Test Failures should not dump stack.

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645287#comment-17645287 ] Elliotte Rusty Harold commented on SUREFIRE-1887: - I don't think this

[jira] [Commented] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645284#comment-17645284 ] ASF GitHub Bot commented on MNGSITE-503: bmarwell opened a new pull request, #35

[GitHub] [maven-site] bmarwell opened a new pull request, #354: [MNGSITE-503] add .well-known/security.txt

2022-12-09 Thread GitBox
bmarwell opened a new pull request, #354: URL: https://github.com/apache/maven-site/pull/354 References: * [.well-known/security.txt at maven.apache.org (mail-archive.com)](https://www.mail-archive.com/dev@maven.apache.org/msg128366.html) * [.well-known/security.txt at maven.apache

[jira] [Updated] (MNGSITE-503) add .well-known/security.txt

2022-12-09 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MNGSITE-503: - Description: As per consensus on the mailing list (+1 from [~rmannibucau] and me), we sh

[GitHub] [maven-surefire] elharo commented on a diff in pull request #574: [SUREFIRE-1887] Trim stacktraces to include relevant lines

2022-12-09 Thread GitBox
elharo commented on code in PR #574: URL: https://github.com/apache/maven-surefire/pull/574#discussion_r1044420785 ## surefire-api/src/test/java/org/apache/maven/surefire/api/report/LegacyPojoStackTraceWriterTest.java: ## @@ -64,14 +65,18 @@ public void testWriteTrimmedTraceToSt

[GitHub] [maven-invoker] psiroky commented on a diff in pull request #58: [MSHARED-1151] Upgrade parent to version 38

2022-12-09 Thread GitBox
psiroky commented on code in PR #58: URL: https://github.com/apache/maven-invoker/pull/58#discussion_r1044420174 ## pom.xml: ## @@ -103,21 +103,6 @@ under the License. - Review Comment: Will take a look. Thanks. -- This is an automated message from the Apac

[jira] [Resolved] (SUREFIRE-2123) Custom TestEngine Tests Not Counted in Result

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved SUREFIRE-2123. - Resolution: Cannot Reproduce > Custom TestEngine Tests Not Counted in

[jira] [Closed] (SUREFIRE-2123) Custom TestEngine Tests Not Counted in Result

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed SUREFIRE-2123. --- > Custom TestEngine Tests Not Counted in Result >

[GitHub] [maven-invoker] psiroky commented on a diff in pull request #58: [MSHARED-1151] Upgrade parent to version 38

2022-12-09 Thread GitBox
psiroky commented on code in PR #58: URL: https://github.com/apache/maven-invoker/pull/58#discussion_r1044416395 ## src/main/java/org/apache/maven/shared/invoker/CommandLineConfigurationException.java: ## @@ -1,3 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (SUREFIRE-1941) Allow overriding PpidChecker OS command line in POM configuration

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated SUREFIRE-1941: Priority: Major (was: Critical) > Allow overriding PpidChecker OS comma

[jira] [Commented] (SUREFIRE-2027) Flaky test AsyncSocketTest

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645279#comment-17645279 ] Elliotte Rusty Harold commented on SUREFIRE-2027: - Agreed this should

[jira] [Resolved] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved SUREFIRE-2087. - Resolution: Not A Problem "If 1st iteration of the test passes and the

[jira] [Closed] (SUREFIRE-2087) rerunFailingTestsCount incorrectly marks failed parametrized test as pass

2022-12-09 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed SUREFIRE-2087. --- > rerunFailingTestsCount incorrectly marks failed parametrized test as pass >

  1   2   >