psiroky commented on code in PR #58: URL: https://github.com/apache/maven-invoker/pull/58#discussion_r1044518853
########## pom.xml: ########## @@ -103,21 +103,6 @@ under the License. </dependencies> <build> - <pluginManagement> Review Comment: Alright, I *think* I managed to replicate the fixes in this commit - https://github.com/apache/maven-parent/pull/94/commits/7faf877810e4f37b40ff0c4b55dd3936b81d48d6. Please take a look, since I am not 100% sure about removing plugin configuration elements coming from parent (e.g. the header file via `headerLocation`). The checkstyle now only reports ~50 WARNs, which was the case before as well I believe (checked via `mvn site -Preporting`. The configuration override is somewhat messy, so alternative would be to wait with this upgrade until the parent version 39 is released. Or if you can think of a better way to do the override, I am all ears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
