bmarwell commented on code in PR #354:
URL: https://github.com/apache/maven-site/pull/354#discussion_r1044897609


##########
pom.xml:
##########
@@ -232,6 +232,32 @@
 -->
         </executions>
       </plugin>
+      <!--
+        used for timestamp of .well-known/security.txt file
+        Plugin-definition must be before resources-plugin to be
+        in the pre-site phase before 'copy-filtered-resources'.
+      -->
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>build-helper-maven-plugin</artifactId>
+        <version>3.3.0</version>
+        <executions>
+          <execution>
+            <id>create-security.txt-timestamp</id>
+            <phase>pre-site</phase>
+            <goals>
+              <goal>timestamp-property</goal>
+            </goals>
+            <configuration>
+              <name>maven.security.expires</name>
+              <locale>ROOT</locale>
+              <pattern>yyyy-MM-dd'T'HH:mm:ss'Z'</pattern>

Review Comment:
   Can do. But your answer doesn't make sense. I can change from literal `'Z'` 
to the TZ pattern `XXX`. But a literal XXX would not be a valid ISO-8601 time.  
Judging from other posts on GitHub, you didn't mean to include the single 
quotes and you do want the offset to be printed, so we don't lie about a few 
hours?
   
   Please note, currently we have a literal Z, not the pattern Z. Your answer 
would have made more sense without the quotes, which is why I ask.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to