[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499370719 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,155 @@ +package org.apache.maven.plugins.sign.pgp; + +/* + *

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499369027 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,155 @@ +package org.apache.maven.plugins.sign.pgp; + +

[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499364952 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,155 @@ +package org.apache.maven.plugins.sign.pgp; + +/* + *

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499363093 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,155 @@ +package org.apache.maven.plugins.sign.pgp; + +

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499361763 ## File path: src/main/java/org/apache/maven/plugins/sign/SignMojo.java ## @@ -0,0 +1,210 @@ +package org.apache.maven.plugins.sign; + +/* + * Li

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499360811 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,155 @@ +package org.apache.maven.plugins.sign.pgp; + +/* + *

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499360561 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromParams.java ## @@ -0,0 +1,80 @@ +package org.apache.maven.plugins.

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499360025 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,155 @@ +package org.apache.maven.plugins.sign.pgp; + +/* + *

[jira] [Closed] (MSTAGE-23) make build Reproducible

2020-10-04 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSTAGE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSTAGE-23. --- Resolution: Fixed thank you for the reminder > make build Reproducible > --- > >

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499359713 ## File path: src/main/java/org/apache/maven/plugins/sign/SignMojo.java ## @@ -0,0 +1,210 @@ +package org.apache.maven.plugins.sign; + +/* + * Licensed

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499359518 ## File path: src/main/java/org/apache/maven/plugins/sign/SignMojo.java ## @@ -0,0 +1,210 @@ +package org.apache.maven.plugins.sign; + +/* + * Licensed

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499358972 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromParams.java ## @@ -0,0 +1,80 @@ +package org.apache.maven.plugins.sign;

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499358031 ## File path: pom.xml ## @@ -0,0 +1,172 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499358256 ## File path: src/it/settings.xml ## @@ -0,0 +1,68 @@ + + + + + + + it-repo + +true + + + + local

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499357745 ## File path: README.md ## @@ -0,0 +1,16 @@ +# PGP sign plugin + +Create PGP signature for all artifacts in maven project + +## Assumptions + - first

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499357407 ## File path: .github/workflows/maven.yml ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

[jira] [Commented] (SUREFIRE-1851) NPE in SmartStackTraceParser causes false positive test results

2020-10-04 Thread Adam Jones (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207795#comment-17207795 ] Adam Jones commented on SUREFIRE-1851: -- PR up at https://github.com/apache/maven-

[jira] [Updated] (SUREFIRE-1851) NPE in SmartStackTraceParser causes false positive test results

2020-10-04 Thread Adam Jones (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Jones updated SUREFIRE-1851: - Description: If throwing an exception within a test where the stack trace is null, a core uti

[GitHub] [maven-surefire] domdomegg opened a new pull request #320: [SUREFIRE-1851] Prevent NPE in SmartStackTraceParser

2020-10-04 Thread GitBox
domdomegg opened a new pull request #320: URL: https://github.com/apache/maven-surefire/pull/320 JIRA: https://issues.apache.org/jira/browse/SUREFIRE-1851 SmartStackTraceParser is used in various places to parse throwables. However, if the throwable stack trace is null it will throw

[jira] [Updated] (SUREFIRE-1851) NPE in SmartStackTraceParser causes false positive test results

2020-10-04 Thread Adam Jones (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Jones updated SUREFIRE-1851: - Description: If throwing an exception within a test where the stack trace is null, a core uti

[jira] [Created] (SUREFIRE-1851) NPE in SmartStackTraceParser causes false positive test results

2020-10-04 Thread Adam Jones (Jira)
Adam Jones created SUREFIRE-1851: Summary: NPE in SmartStackTraceParser causes false positive test results Key: SUREFIRE-1851 URL: https://issues.apache.org/jira/browse/SUREFIRE-1851 Project: Maven Su

[jira] [Updated] (SUREFIRE-1851) NPE in SmartStackTraceParser causes false positive test results

2020-10-04 Thread Adam Jones (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Jones updated SUREFIRE-1851: - Attachment: junit5.7.0andsurefire3.0.0M5.txt junit4.11andsurefire2.22.2.txt >

[GitHub] [maven] michael-o commented on pull request #371: [MNG-5180] Fixes dangling snapshot versions in metadata after merge

2020-10-04 Thread GitBox
michael-o commented on pull request #371: URL: https://github.com/apache/maven/pull/371#issuecomment-703318708 Willing to merge when this one is addressed. This is an automated message from the Apache Git Service. To respond

[GitHub] [maven] michael-o commented on pull request #371: [MNG-5180] Fixes dangling snapshot versions in metadata after merge

2020-10-04 Thread GitBox
michael-o commented on pull request #371: URL: https://github.com/apache/maven/pull/371#issuecomment-703318176 I wonders me why this is pseudo-merged: https://github.com/apache/maven/blob/ecfff2626c719b916e37a685d5154cf2fa52b0ba/maven-resolver-provider/src/main/java/org/apache/maven/repo

[GitHub] [maven-script-interpreter] slachiewicz merged pull request #27: Javadoc fixes

2020-10-04 Thread GitBox
slachiewicz merged pull request #27: URL: https://github.com/apache/maven-script-interpreter/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-script-interpreter] slachiewicz opened a new pull request #27: Javadoc fixes

2020-10-04 Thread GitBox
slachiewicz opened a new pull request #27: URL: https://github.com/apache/maven-script-interpreter/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven] michael-o commented on a change in pull request #371: [MNG-5180] Fixes dangling snapshot versions in metadata after merge

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #371: URL: https://github.com/apache/maven/pull/371#discussion_r499288608 ## File path: maven-repository-metadata/src/main/mdo/metadata.mdo ## @@ -190,17 +192,24 @@ under the License. {

[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499287667 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromParams.java ## @@ -0,0 +1,80 @@ +package org.apache.maven.plugins.sign; +

[GitHub] [maven-script-interpreter] slachiewicz merged pull request #26: Update plugins to latest versions

2020-10-04 Thread GitBox
slachiewicz merged pull request #26: URL: https://github.com/apache/maven-script-interpreter/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-script-interpreter] slachiewicz opened a new pull request #26: Update plugins to latest versions

2020-10-04 Thread GitBox
slachiewicz opened a new pull request #26: URL: https://github.com/apache/maven-script-interpreter/pull/26 - fixes incorrect report generation - issues with javadoc:fix This is an automated message from the Apache Git Serv

[GitHub] [maven-studies] slawekjaranowski commented on pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on pull request #2: URL: https://github.com/apache/maven-studies/pull/2#issuecomment-703313151 Fixes for review was done. I hope we can merge this version, and then more people can work o it. I did also simple todo in readme. ---

[GitHub] [maven-script-interpreter] slachiewicz merged pull request #25: Run Github CI with Java 15

2020-10-04 Thread GitBox
slachiewicz merged pull request #25: URL: https://github.com/apache/maven-script-interpreter/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-script-interpreter] slachiewicz opened a new pull request #25: Run Github CI with Java 15

2020-10-04 Thread GitBox
slachiewicz opened a new pull request #25: URL: https://github.com/apache/maven-script-interpreter/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven-script-interpreter] slachiewicz merged pull request #24: Fix reported issues

2020-10-04 Thread GitBox
slachiewicz merged pull request #24: URL: https://github.com/apache/maven-script-interpreter/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-script-interpreter] slachiewicz opened a new pull request #24: Fix reported issues

2020-10-04 Thread GitBox
slachiewicz opened a new pull request #24: URL: https://github.com/apache/maven-script-interpreter/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499285147 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromSettings.java ## @@ -0,0 +1,68 @@ +package org.apache.maven.plugins.sign;

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499284702 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromSettings.java ## @@ -0,0 +1,68 @@ +package org.apache.maven.plugin

[GitHub] [maven] asfgit closed pull request #380: [MNG-6993] Upgrade SLF4J to 1.7.30

2020-10-04 Thread GitBox
asfgit closed pull request #380: URL: https://github.com/apache/maven/pull/380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath

2020-10-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207736#comment-17207736 ] Hudson commented on MNG-6965: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-6965

[jira] [Commented] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207735#comment-17207735 ] Michael Osipov commented on MNG-5180: - [~patope], looking at this. As far as I undertan

[jira] [Closed] (MNG-6992) Allow access to org.eclipse.aether.transform

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6992. --- Resolution: Fixed Fixed with [d5a5bc553a131f1ecca5503dde359dedcec4c506|https://gitbox.apache.org/repos

[GitHub] [maven] asfgit closed pull request #379: [MNG-6992] - Allow access to org.eclipse.aether.transform

2020-10-04 Thread GitBox
asfgit closed pull request #379: URL: https://github.com/apache/maven/pull/379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (MNG-6993) Upgrade SLF4J to 1.7.30

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6993: Fix Version/s: 3.7.0 > Upgrade SLF4J to 1.7.30 > --- > > Key: MNG

[jira] [Assigned] (MNG-6993) Upgrade SLF4J to 1.7.30

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6993: --- Assignee: Michael Osipov > Upgrade SLF4J to 1.7.30 > --- > >

[jira] [Updated] (MNG-6992) Allow access to org.eclipse.aether.transform

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6992: Fix Version/s: 3.7.0 > Allow access to org.eclipse.aether.transform > ---

[jira] [Assigned] (MNG-6992) Allow access to org.eclipse.aether.transform

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6992: --- Assignee: Michael Osipov > Allow access to org.eclipse.aether.transform >

[jira] [Commented] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207718#comment-17207718 ] Michael Osipov commented on MNG-6965: - Folks, PR and IT PR updated. Please have a look.

[GitHub] [maven-integration-testing] michael-o opened a new pull request #73: [MNG-6965] Extensions suddenly have org.codehaus.plexus:plexus-utils:…

2020-10-04 Thread GitBox
michael-o opened a new pull request #73: URL: https://github.com/apache/maven-integration-testing/pull/73 …jar:1.1 on their classpath Scope a few ITs for (,3.7.0). This closes #73 This is an automated message fr

[GitHub] [maven-archetype] michael-o commented on pull request #57: [MNG-6965] - Quick fix by adding dependency

2020-10-04 Thread GitBox
michael-o commented on pull request #57: URL: https://github.com/apache/maven-archetype/pull/57#issuecomment-703302927 The problem isn't rooted here. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-archetype] michael-o closed pull request #57: [MNG-6965] - Quick fix by adding dependency

2020-10-04 Thread GitBox
michael-o closed pull request #57: URL: https://github.com/apache/maven-archetype/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499279382 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromSettings.java ## @@ -0,0 +1,68 @@ +package org.apache.maven.plugins.sign;

[jira] [Updated] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6965: Summary: Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath (was:

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499278397 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromSettings.java ## @@ -0,0 +1,68 @@ +package org.apache.maven.plugin

[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499276012 ## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromSettings.java ## @@ -0,0 +1,68 @@ +package org.apache.maven.plugins.sign;

[GitHub] [maven-resolver] asfgit merged pull request #74: Move OSGi metadata generation to apache-release profile

2020-10-04 Thread GitBox
asfgit merged pull request #74: URL: https://github.com/apache/maven-resolver/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-stage-plugin] michaelboyles edited a comment on pull request #2: [MSTAGE-24] - set minimum maven version to 3.1

2020-10-04 Thread GitBox
michaelboyles edited a comment on pull request #2: URL: https://github.com/apache/maven-stage-plugin/pull/2#issuecomment-703293580 Problem is this plugin has no tests, except 1 which is ignored, so I'm hesitant to make any more changes than I have to. Suggest we raise a new jira to f

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499270860 ## File path: pom.xml ## @@ -0,0 +1,179 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [maven-stage-plugin] michaelboyles commented on pull request #2: [MSTAGE-24] - set minimum maven version to 3.1

2020-10-04 Thread GitBox
michaelboyles commented on pull request #2: URL: https://github.com/apache/maven-stage-plugin/pull/2#issuecomment-703293580 Problem is this plugin has no tests, except 1 which is ignored, so I'm hesitant to make any more changes than I have to. Suggest we raise a new jira to fix and

[jira] [Resolved] (MSHARED-956) Set minimum supported Maven version to 3.1.0

2020-10-04 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MSHARED-956. --- Fix Version/s: maven-reporting-impl-3.1.0 Resolution: Fixed > Set min

[jira] [Closed] (MSHARED-956) Set minimum supported Maven version to 3.1.0

2020-10-04 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MSHARED-956. - > Set minimum supported Maven version to 3.1.0 > ---

[jira] [Commented] (MSTAGE-24) set minimum maven version to 3.1

2020-10-04 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSTAGE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207706#comment-17207706 ] Elliotte Rusty Harold commented on MSTAGE-24: - What do we replace these import

[GitHub] [maven-studies] slawekjaranowski commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499270526 ## File path: .github/workflows/maven.yml ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[jira] [Commented] (MSTAGE-25) Modernize IO

2020-10-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSTAGE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207700#comment-17207700 ] Hudson commented on MSTAGE-25: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-stage-p

[GitHub] [maven-stage-plugin] michaelboyles commented on pull request #2: [MSTAGE-24] - set minimum maven version to 3.1

2020-10-04 Thread GitBox
michaelboyles commented on pull request #2: URL: https://github.com/apache/maven-stage-plugin/pull/2#issuecomment-703282353 Ah, maven-artifact-manager has been discontinued for Maven 3. I replaced it with maven-compat which seems like the right thing to do. Let me know if it's not --

[GitHub] [maven-studies] michael-o commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499260169 ## File path: src/main/java/org/apache/maven/plugins/sign/SignMojo.java ## @@ -0,0 +1,192 @@ +package org.apache.maven.plugins.sign; + +/* + * Licensed

[jira] [Commented] (MCOMPILER-275) Handle separate compilation of module-info.java

2020-10-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207493#comment-17207493 ] Hudson commented on MCOMPILER-275: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[jira] [Commented] (MSTAGE-23) make build Reproducible

2020-10-04 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MSTAGE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207487#comment-17207487 ] Piotr Zygielo commented on MSTAGE-23: - [~hboutemy] With [14014279|https://github.com/

[GitHub] [maven-resolver] michael-o commented on pull request #74: Move OSGi metadata generation to apache-release profile

2020-10-04 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-resolver/pull/74#issuecomment-703265077 Because Jenkins enforces Java 8. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [maven-studies] rfscholte commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
rfscholte commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499251283 ## File path: src/main/java/org/apache/maven/plugins/sign/SignMojo.java ## @@ -0,0 +1,192 @@ +package org.apache.maven.plugins.sign; + +/* + * Licensed

[GitHub] [maven-resolver] kwin commented on pull request #74: Move OSGi metadata generation to apache-release profile

2020-10-04 Thread GitBox
kwin commented on pull request #74: URL: https://github.com/apache/maven-resolver/pull/74#issuecomment-703262930 Why do you want to continue building with Java 7? This is an automated message from the Apache Git Service. To r

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499250274 ## File path: src/main/java/org/apache/maven/plugins/sign/pgp/PGPSigner.java ## @@ -0,0 +1,151 @@ +package org.apache.maven.plugins.sign.pgp; + +/* + *

[GitHub] [maven-studies] khmarbaise commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
khmarbaise commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499249824 ## File path: pom.xml ## @@ -0,0 +1,179 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499249873 ## File path: src/main/java/org/apache/maven/plugins/sign/SignMojo.java ## @@ -0,0 +1,192 @@ +package org.apache.maven.plugins.sign; + +/* + * Licensed

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499249498 ## File path: pom.xml ## @@ -0,0 +1,179 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [maven-studies] mthmulders commented on a change in pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499249293 ## File path: .github/workflows/maven.yml ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

[GitHub] [maven-stage-plugin] elharo opened a new pull request #6: [MSTAGE-25] fixup and modernize IO

2020-10-04 Thread GitBox
elharo opened a new pull request #6: URL: https://github.com/apache/maven-stage-plugin/pull/6 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [maven-studies] slawekjaranowski opened a new pull request #2: Maven sign plugin

2020-10-04 Thread GitBox
slawekjaranowski opened a new pull request #2: URL: https://github.com/apache/maven-studies/pull/2 First working version This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [maven-resolver] michael-o commented on pull request #74: Move OSGi metadata generation to apache-release profile

2020-10-04 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-resolver/pull/74#issuecomment-703251131 Something is fishy with my whitespace. Will fix before merge. This is an automated message from the Apache

[GitHub] [maven-resolver] michael-o opened a new pull request #74: Move OSGi metadata generation to apache-release profile

2020-10-04 Thread GitBox
michael-o opened a new pull request #74: URL: https://github.com/apache/maven-resolver/pull/74 Jenkins is failing because Java 8 is enforced. Now, we need Java 8 at release time only. This is an automated message from the

[jira] [Commented] (MSTAGE-25) Modernize IO

2020-10-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSTAGE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207329#comment-17207329 ] Hudson commented on MSTAGE-25: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-stage-p

[GitHub] [maven-stage-plugin] elharo merged pull request #4: [MSTAGE-25] use Java 7 file handling in test

2020-10-04 Thread GitBox
elharo merged pull request #4: URL: https://github.com/apache/maven-stage-plugin/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (MSTAGE-25) Modernize IO

2020-10-04 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MSTAGE-25: --- Summary: Modernize IO Key: MSTAGE-25 URL: https://issues.apache.org/jira/browse/MSTAGE-25 Project: Maven Stage Plugin Issue Type: Improvement

[jira] [Assigned] (MSTAGE-25) Modernize IO

2020-10-04 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSTAGE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSTAGE-25: --- Assignee: Elliotte Rusty Harold > Modernize IO > - > >

[GitHub] [maven-stage-plugin] elharo commented on pull request #2: [MSTAGE-24] - set minimum maven version to 3.1

2020-10-04 Thread GitBox
elharo commented on pull request #2: URL: https://github.com/apache/maven-stage-plugin/pull/2#issuecomment-703247682 Tests failed. :-( This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [maven-stage-plugin] elharo commented on a change in pull request #4: use Java 7 file handling in test

2020-10-04 Thread GitBox
elharo commented on a change in pull request #4: URL: https://github.com/apache/maven-stage-plugin/pull/4#discussion_r499240665 ## File path: src/test/java/org/apache/maven/plugins/stage/RepositoryCopierTest.java ## @@ -103,28 +103,28 @@ private void testMavenArtifact( File re

[GitHub] [maven-resolver] michael-o commented on pull request #71: [MRESOLVER-136] switch to bnd-maven-plugin for generating bundle headers

2020-10-04 Thread GitBox
michael-o commented on pull request #71: URL: https://github.com/apache/maven-resolver/pull/71#issuecomment-703247315 Working on this w/o giving up bnd-maven-plugin. This is an automated message from the Apache Git Service. T

[GitHub] [maven-stage-plugin] elharo merged pull request #5: ignore .checkstyle

2020-10-04 Thread GitBox
elharo merged pull request #5: URL: https://github.com/apache/maven-stage-plugin/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-stage-plugin] michael-o commented on a change in pull request #4: use Java 7 file handling in test

2020-10-04 Thread GitBox
michael-o commented on a change in pull request #4: URL: https://github.com/apache/maven-stage-plugin/pull/4#discussion_r499239085 ## File path: src/test/java/org/apache/maven/plugins/stage/RepositoryCopierTest.java ## @@ -103,28 +103,28 @@ private void testMavenArtifact( File

[GitHub] [maven-stage-plugin] elharo opened a new pull request #5: ignore .checkstyle

2020-10-04 Thread GitBox
elharo opened a new pull request #5: URL: https://github.com/apache/maven-stage-plugin/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-stage-plugin] elharo opened a new pull request #4: use Java 7 file handling in test

2020-10-04 Thread GitBox
elharo opened a new pull request #4: URL: https://github.com/apache/maven-stage-plugin/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin

2020-10-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207323#comment-17207323 ] Michael Osipov commented on MRESOLVER-136: -- There are several options. Move t

[GitHub] [maven-stage-plugin] elharo opened a new pull request #3: cleanup dependencies

2020-10-04 Thread GitBox
elharo opened a new pull request #3: URL: https://github.com/apache/maven-stage-plugin/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MRESOLVER-136) Migrate from maven-bundle-plugin to bnd-maven-plugin

2020-10-04 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207313#comment-17207313 ] Elliotte Rusty Harold commented on MRESOLVER-136: - This fails the Jenk