mthmulders commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499357745
########## File path: README.md ########## @@ -0,0 +1,16 @@ +# PGP sign plugin + +Create PGP signature for all artifacts in maven project + +## Assumptions + - first version require maven 3.7.0-SNAPSHOT + - use build/consumer feature + +## TODO + - documentations + - check if all artifacts are ready to sign - if package goal was running + - verify password encryption in settings.xml Review comment: ```suggestion - find a good approach to storing passwords ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org