michael-o commented on a change in pull request #2: URL: https://github.com/apache/maven-studies/pull/2#discussion_r499276012
########## File path: src/main/java/org/apache/maven/plugins/sign/PGPSecretKeyInfoFromSettings.java ########## @@ -0,0 +1,68 @@ +package org.apache.maven.plugins.sign; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.plugins.sign.pgp.PGPSecretKeyInfo; +import org.apache.maven.settings.Server; + +import java.io.File; +import java.math.BigInteger; +import java.util.Objects; + +/** + * Information about pgp key from settings server + * + * @author Slawomir Jaranowski + */ +public class PGPSecretKeyInfoFromSettings implements PGPSecretKeyInfo Review comment: Don't use servers for this, this is an abuse and they have a bad designed which I have layed out in several JIRA issues. Use a minimal set of information (properties) we need to solve this case. E.g, properties from settings for GPG during apache-release profile. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
