uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r208652
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086555819
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086555819
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086560622
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
stefanvodita merged PR #14656:
URL: https://github.com/apache/lucene/pull/14656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086528285
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086526348
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r208652
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r208652
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086541603
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086578233
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086578233
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2876103288
I am complete pissed off, bye! Do whatever you want. Damn!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2876119114
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086589925
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
thecoop commented on PR #14509:
URL: https://github.com/apache/lucene/pull/14509#issuecomment-2876771344
@ChrisHegarty @jpountz Does this look ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ChrisHegarty merged PR #14633:
URL: https://github.com/apache/lucene/pull/14633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
dsmiley commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2876638709
Thanks Dawid for the deep dive and Uwe for helping with the Eclipse support!
For this minor build improvement, I wasn't going to update CHANGES.txt but
let me know if you think I sh
vsop-479 commented on PR #12528:
URL: https://github.com/apache/lucene/pull/12528#issuecomment-2876395494
Performance with "inverse" visitor implemented:
box-points| baseline | candidate | Diff
-- | -- | -- | --
BEST M hits/sec | 500.14 | 513.51 | 2.6%
BEST QPS | 508.92 | 522.
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875450439
> The most important question here: Did you find out if "compliance" flag
uses release or not?
Looking at the code, it seems to be equivalent to setting the release flag.
h
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875439928
Also - the final cherry on top of this cake - why we can't see such
significant difference on main is very likely on this change:
https://bugs.openjdk.org/browse/JDK-8283336
If you
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875439078
P.S.: It could be that the newest version of the ct.sym generator uses the
Classfile API in a similar way like I refactored it last week. Have not checked
source code, the last time I
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875430075
> the compiler and also introduced an - undocumented? - 'ct.sym' file, which
is part of the JDK and is a zip file with class signatures from previous Java
version. Couldn't find the d
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875453187
There is a lot of complexity involved in checking this release
compatibility. I'd leave it out to javac and just use source/target here. No
need to double-check the same stuff twice and s
github-actions[bot] commented on PR #14656:
URL: https://github.com/apache/lucene/pull/14656#issuecomment-2875933483
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875948758
> There is a lot of complexity involved in checking this release
compatibility. I'd leave it out to javac and just use source/target here. No
need to double-check the same stuff twice
dweiss commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875734587
One would be probably enough. I'm also not sure we should require all
changes in changes.txt. The one in 14653 doesn't seem to be that important (it
applies to build infrastructure,
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875906960
I thought about it some more. The way we envisioned PR authors choosing not
to run the verifier is by adding the [`skip-changelog-check`
label](https://github.com/apache/lucene
rmuir commented on issue #14655:
URL: https://github.com/apache/lucene/issues/14655#issuecomment-2875770908
> So, I suggest a radical shift in the underlying posting format. Give up
log-structured format (LSM)! Give up segments. LSM aims for sequential I/O,
which is no longer relevant for N
shbakram commented on issue #14655:
URL: https://github.com/apache/lucene/issues/14655#issuecomment-2875790379
Lucene can support various I/O engines: mmap, io_uring, pmem, etc. This way
as storage technology improves, one can reuse all the latest developments in
Lucene (e.g., high-dimensio
rmuir commented on code in PR #14653:
URL: https://github.com/apache/lucene/pull/14653#discussion_r2086404395
##
gradle/hacks/downloader-retries.gradle:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreeme
epotyom commented on issue #14619:
URL: https://github.com/apache/lucene/issues/14619#issuecomment-2875780860
In my opinion, the new approach can eventually do everything the current
approach does, but there are quite a few gaps to cover, see Milestone 2 in [the
plan
document](https://docs
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875620327
The bot has processed one PR (#14653) and I already see something I'm not
sure I like - it will post a comment every time we push to the branch and are
missing a CHANGES entry.
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875507747
Thanks, so I'd like to revert those changes here with a clear warning next
to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on PR #14653:
URL: https://github.com/apache/lucene/pull/14653#issuecomment-2875511439
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on PR #14653:
URL: https://github.com/apache/lucene/pull/14653#issuecomment-2875512652
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875517286
Yep, I'd stick to using what was there before. Not a bad idea to replace
java properties if you've already done it though.
--
This is an automated message from the Apache Git Service.
T
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875398128
I dug deep into this, fascinating. So the problem is indeed in the release
check flag. Here is a flame graph from a slowed-down execution of ecj:
![image](https://github.com/user-attac
stefanvodita closed issue #13898: Create a bot to check if there is a CHANGES
entry for new PRs
URL: https://github.com/apache/lucene/issues/13898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
stefanvodita merged PR #14644:
URL: https://github.com/apache/lucene/pull/14644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875957427
But at end I don't care if we set source+target or just compliance. It is
effectively doing the same at end. We should just make sure to not set
"release".
Just to confirm that
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875971667
Ok, I think the second snippet of yours is spot-on - yes. Still, I'd prefer
using javac options. I understand them. Everyone who uses javac will. ecj's
"numeric" compliance options are a
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2875933174
#14656 is what I was suggesting as an immediate step. I wonder if all
contributors have permissions to add labels to their PRs though.
--
This is an automated message from th
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875975752
> Just to confirm that my observations are correct: Did you measure slowness
with this PR if executed in Java 25?
I don't see a lot of slowdown at all when I run on Java 21+. It is
rmuir commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875984812
Please don't enable this slowness, there is zero benefit as javac already
checks it.
We don't need it. Just avoid it.
--
This is an automated message from the Apache Git Service.
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086524077
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
github-actions[bot] commented on PR #14657:
URL: https://github.com/apache/lucene/pull/14657#issuecomment-2877137967
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the label to it and you
will stop receiving thi
Trey314159 opened a new pull request, #14657:
URL: https://github.com/apache/lucene/pull/14657
Remove Telugu normalization of vu వు to ma మ from IndicNormalizer.
### Description
Telugu vu వు and ma మ are visually similar—akin to English "rn" and "m"—but
they should not be confl
stefanvodita merged PR #14658:
URL: https://github.com/apache/lucene/pull/14658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
stefanvodita opened a new pull request, #14658:
URL: https://github.com/apache/lucene/pull/14658
Noticed on #14657 that the label wasn't being shown in the
[comment](https://github.com/apache/lucene/pull/14657#issuecomment-2877137967).
Sorry for the churn!
--
This is an automated message
Trey314159 opened a new issue, #14659:
URL: https://github.com/apache/lucene/issues/14659
### Description
Telugu vu వు and ma మ are visually similar—akin to English "rn" and "m"—but
they should not be conflated. Names like వెంకటరామ (Venkatarama) and వెంకటరావు
(Venkatarao) and words l
github-actions[bot] commented on PR #14657:
URL: https://github.com/apache/lucene/pull/14657#issuecomment-2877267036
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
Trey314159 closed pull request #14657: Update IndicNormalizer.java
URL: https://github.com/apache/lucene/pull/14657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
github-actions[bot] commented on PR #14658:
URL: https://github.com/apache/lucene/pull/14658#issuecomment-2877161916
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the label to it and you
will stop receiving thi
54 matches
Mail list logo
