Re: [I] apache jenkins: Failed to save the JUnit test result [lucene]

2025-05-12 Thread via GitHub
uschindler commented on issue #14617: URL: https://github.com/apache/lucene/issues/14617#issuecomment-2871366825 Policeman Jenkins gets it installed, ASF Jenkins needs to be pinged: ![Image](https://github.com/user-attachments/assets/16be6de7-aebe-4b74-86d5-764005932dcf) -- This is

Re: [I] apache jenkins: Failed to save the JUnit test result [lucene]

2025-05-12 Thread via GitHub
timja commented on issue #14617: URL: https://github.com/apache/lucene/issues/14617#issuecomment-2871353098 fix is available now: https://github.com/jenkinsci/junit-plugin/releases/tag/1334.vd3b_b_2094e438 -- This is an automated message from the Apache Git Service. To respond to the mess

[I] Filters cannot be set in Analysis [lucene]

2025-05-12 Thread via GitHub
raiAmagi opened a new issue, #14649: URL: https://github.com/apache/lucene/issues/14649 ### Description When I select a filter from the +Add pull-down menu for “Char Filter” and “Token Filters” in the bundled Luke Analysis settings under the environment described in “Version and envi

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dsmiley commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873711276 > The command line of ECJ should not be modified. Why; is it perfection? It seems the "compliance" wasn't being set. -- This is an automated message from the Apache Git Service.

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dsmiley commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085319708 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == p

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085322774 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085324735 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclips

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085333753 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

Re: [PR] Fix FuzzySet#getEstimatedNumberUniqueValuesAllowingForCollisions to account for hashCount [lucene]

2025-05-12 Thread via GitHub
gsmiller merged PR #14614: URL: https://github.com/apache/lucene/pull/14614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[PR] build: configure 3 retries for all gradle Download tasks [lucene]

2025-05-12 Thread via GitHub
rmuir opened a new pull request, #14653: URL: https://github.com/apache/lucene/pull/14653 The default value of retries is 0. Set it to 3, to improve reliability of downloads during builds. Closes #14652 Please review, and make sure I didn't miss any `Download` tasks. The goal

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
rmuir commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085353966 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pro

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085357012 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

Re: [PR] build: configure 3 retries for all gradle Download tasks [lucene]

2025-05-12 Thread via GitHub
dweiss commented on PR #14653: URL: https://github.com/apache/lucene/pull/14653#issuecomment-2873829504 This can be done by applying a single configuration to a task type, Rob (tasks.withType(Download).configureEach...). I'm away from the computer but will tweak it tomorrow. -- This is

Re: [PR] build: configure 3 retries for all gradle Download tasks [lucene]

2025-05-12 Thread via GitHub
dweiss commented on PR #14653: URL: https://github.com/apache/lucene/pull/14653#issuecomment-2873830885 something like this - https://github.com/apache/lucene/blob/main/gradle/hacks/gradle-archives.gradle -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Catch and re-throw Throwable rather than using a success boolean [lucene]

2025-05-12 Thread via GitHub
thecoop commented on PR #14633: URL: https://github.com/apache/lucene/pull/14633#issuecomment-2873415595 I definitely agree that having to have a separate `throw t` as part of the exception handling is trappy (although generally ok due to flow-control changes breaking the compile without it

Re: [PR] Early terminate visit BKD leaf when current value greater than upper point in sorted dim. [lucene]

2025-05-12 Thread via GitHub
vsop-479 commented on PR #12528: URL: https://github.com/apache/lucene/pull/12528#issuecomment-2872429486 > I would remove the "inverse" case as the inverse visitors are implementation details and IMHO should not be part of the API. FWIW, I implemented "inverse" case with `VisitState`

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084810166 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility ==

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
rmuir commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084808570 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -151,7 +149,6 @@ org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error org.eclipse.jdt.core.compiler.

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084815606 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -151,7 +149,6 @@ org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error org.eclipse.jdt.core.comp

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084813285 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclips

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dsmiley commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084819372 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == p

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084813285 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclips

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084825680 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclips

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
rmuir commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874569307 Sorry, I don't have a better idea other than, try it on branch_10x, using a JDK24 where the "target" is 21. Or maybe "template" the file the same way as is done for `gradle eclipse`

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-12 Thread via GitHub
mikemccand commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2874503575 Thanks @jpountz -- I had done a full system update (`pacman -Syyu`) on 2025-05-01, and lots of packages were updated, including kernel: ``` [2025-05-01T10:18:13-0400] [A

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874579010 Use Jdk 25 EA to check. Jenkins does this all the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085643653 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -151,7 +149,6 @@ org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error org.eclipse.jdt.core.comp

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085644555 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclips

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874398269 I fixed the eclipse setup in https://github.com/apache/lucene/pull/14651/commits/965a00b006a419288a4284be8ef1d2f365484fee It basically adds the follwoing to the settingss file g

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
rmuir commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874408782 > To me all is fine, just try to figure out with @dweiss and @rmuir if the release flag is enabled or not. Please don't do it here. Please make separate PR if you want to enable that

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874416695 > > To me all is fine, just try to figure out with @dweiss and @rmuir if the release flag is enabled or not. > > Please don't do it here. Please make separate PR if you want to

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874423257 But of course it may be different with the command line parameters. But to me it looks like Eclipse disables the release flag and compliance is just a combination of above pictures "s

Re: [PR] Enabling point range collector always if doc values not indexed [lucene]

2025-05-12 Thread via GitHub
github-actions[bot] commented on PR #14559: URL: https://github.com/apache/lucene/pull/14559#issuecomment-2874652171 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-12 Thread via GitHub
rmuir commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2874660497 Thats a big kernel jump. But it is hard to reason about, or declare a problem, because I'm still not sure what we are benchmarking here. See vmstat graphs: https://benchmarks.mikemcca

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dsmiley commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085289312 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclipse.j

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085278571 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dsmiley commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085285767 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == p

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085298100 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085295730 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085299262 ## gradle/validation/ecj-lint.gradle: ## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] +assert project.java.sourceCompatibility == pr

[I] asynchronous I/O + saturating NVMe bandwidth [lucene]

2025-05-12 Thread via GitHub
shbakram opened a new issue, #14655: URL: https://github.com/apache/lucene/issues/14655 ### Description The intersection of fast NVMe SSDs that offer high I/O concurrency and io_uring is leading to a momentum toward asynchronous request processing. For example, PostgreSQL is the late

[I] MMapDirectory.PRELOAD_HINT should also consider FileTypeHint.INDEX [lucene]

2025-05-12 Thread via GitHub
jpountz opened a new issue, #14650: URL: https://github.com/apache/lucene/issues/14650 ### Description Currently, `MMapDirectory.PRELOAD_HINT` only looks at the `PreloadHint.INSTANCE`. In my opinion, it should look at `FileTypeHint.INDEX` as well: index files are very small by contra

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-12 Thread via GitHub
jpountz commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2872249319 I tried to reproduce the slowdown locally by - comparing on the commit just before we started requiring Java 24, with the baseline on Java 23 and the contender on Java 24 (by pas

Re: [I] TopFieldCollector mistakenly assumes that all leaves share the same index sort [lucene]

2025-05-12 Thread via GitHub
jpountz commented on issue #14399: URL: https://github.com/apache/lucene/issues/14399#issuecomment-2872278104 What are the two cases that you have in mind? I don't think that having a collector with a cache makes sense since it has an assumption that leaves are uniform, which may not be cor

Re: [PR] Early terminate visit BKD leaf when current value greater than upper point in sorted dim. [lucene]

2025-05-12 Thread via GitHub
vsop-479 commented on PR #12528: URL: https://github.com/apache/lucene/pull/12528#issuecomment-2872432747 I will try to measure the performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2084813285 ## gradle/validation/ecj-lint/ecj.javadocs.prefs: ## @@ -15,9 +15,7 @@ org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin org.eclips

Re: [PR] Add instructions to help/IDEs.txt for VSCode and Neovim [lucene]

2025-05-12 Thread via GitHub
rmuir merged PR #14646: URL: https://github.com/apache/lucene/pull/14646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
dsmiley commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2872842933 I'm hoping an Eclipse user could improve this PR to address that side of the equation. I've never used Eclipse. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Don't perform additional KNN querying after timeout, fixes #14639 [lucene]

2025-05-12 Thread via GitHub
msokolov merged PR #14640: URL: https://github.com/apache/lucene/pull/14640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [I] Fix bad interaction between optimistic query and query timeout [lucene]

2025-05-12 Thread via GitHub
msokolov closed issue #14639: Fix bad interaction between optimistic query and query timeout URL: https://github.com/apache/lucene/issues/14639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873022378 > I'm hoping an Eclipse user could improve this PR to address that side of the equation. I've never used Eclipse. Not sure how, but if we remove the java version from the ecj ja

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873029220 Something like: ```groovy filter(ReplaceTokens, tokens: [ 'ecj-lint-config': ecjLintFile.getText('UTF-8').replaceAll(/=error\b/, '=' + errorMode)

Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

2025-05-12 Thread via GitHub
uschindler commented on PR #14651: URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873032572 But in general: Iw would keep the properties file as is and inject the Java version there. The command line of ECJ should not be modified. -- This is an automated message from the A